Skip to content

Commit 59278e3

Browse files
Add upload-artifact action to manually download the built installers (#6)
* Add upload-artifact action to manually download the built installers * temporarily also run the upload action on this branch for testing * syntax error * Use more general wildcards * Update readme as build action as it does not produce working binaries because no certificate is configured.
1 parent 6d90b72 commit 59278e3

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

.github/workflows/build.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@ on:
44
push:
55
branches:
66
- main
7-
tags:
8-
- 'v[0-9]+.[0-9]+.[0-9]+'
97
jobs:
10-
build_and_release:
8+
build:
119
runs-on: macos-14
1210

1311
env:
@@ -23,3 +21,14 @@ jobs:
2321
run: npm set "//npm.pkg.github.com/:_authToken=${GITHUB_TOKEN}"
2422
- run: npm ci
2523
- run: npm run dist
24+
- name: Upload installers to action runs
25+
uses: actions/upload-artifact@v4
26+
with:
27+
name: dist
28+
path: |
29+
dist/*.dmg
30+
dist/*.dmg.blockmap
31+
dist/*.exe
32+
dist/*.exe.blockmap
33+
dist/*.yaml
34+
dist/*.yml

Changelog.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@
33
This changelog summarises changes for minor and major version bumps that end users might need to be aware of. The commit log should provide a more detailed list of changes for developers; most changes to internal systems are not discussed here.
44

55
---
6-
# `0.23.1`
6+
# `0.23.1` (public release)
7+
_2025-01-29_
78
* Change location of support and log files to `~/Library/Application Support/Audio Orchestrator` / `%APPDATA%/Audio Orchestrator`
9+
* Change name of default export folder to begin with `audio-orchestrator`.
810

911
# `0.23.0`
1012
_2025-01-17_

Readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ All dependencies and scripts are listed in the single `package.json` at the top
7171

7272
## Releases and versions
7373

74-
A [GitHub action](.github/workflows/build.yml) automatically attaches built installers to a draft release when a PR is merged into the main branch, and a draft release with the tag name `v${version}` matching the package.json version exists.
74+
Pull requests should update the main `package.json` version and run `npm install && npm run credits` before they are merged to ensure the new version is used throughout. Changelog.md should also be manually updated.
7575

76-
NB apps built this way are not signed or notarized by Apple/Microsoft and may require additional authorization to run. This is the same as with the MakerBox installers distributed previously.
76+
Currently, releases are locally built (`npm run dist`) and manually uploaded to GitHub (macOS, macOS-arm64, Windows).
7777

7878
## History
7979

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"credits": "node scripts/credits.mjs",
1616
"dev": "concurrently \"npm run dev:react-frontend\" \"NODE_ENV=development electron --inspect=9229 .\"",
1717
"dev:react-frontend": "(cd react-frontend && webpack-dev-server --hot --host 0.0.0.0 --mode development)",
18-
"dist": "((rm -r ./dist || echo '') && npm run credits && cp electron-app/credits.html electron-app/credits2.html && npm run build:react-frontend && electron-builder --config electron-builder.json --mac --win)",
18+
"dist": "((rm -r ./dist || echo '') && npm run credits && cp electron-app/credits.html electron-app/credits2.html && npm run build:react-frontend && electron-builder --config electron-builder.json --mac --win --publish never)",
1919
"lint": "npm run lint:background-tasks && npm run lint:react-frontend && npm run lint:electron-app && npm run lint:logging",
2020
"lint:background-tasks": "cd background-tasks && eslint src test",
2121
"lint:electron-app": "cd electron-app && eslint src",

0 commit comments

Comments
 (0)