Skip to content

Commit 40f667e

Browse files
committed
Merge main
2 parents cc81b69 + b0e8551 commit 40f667e

File tree

4 files changed

+230
-110
lines changed

4 files changed

+230
-110
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "bigscreen-player",
3-
"version": "10.5.0",
3+
"version": "10.5.1",
44
"type": "module",
55
"description": "Simplified media playback for bigscreen devices.",
66
"main": "dist/esm/main.js",

src/playbackstrategy/msestrategy.js

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -514,13 +514,16 @@ function MSEStrategy(
514514
function onCurrentTrackChanged(event) {
515515
if (!isAudioDescribedAvailable()) return
516516

517+
audioDescribed.enable = isAudioDescribedEnabled()
517518
const mediaType = event.newMediaInfo.type
519+
518520
DebugTool.info(
519521
`${mediaType} track changed.${
520-
mediaType === "audio" ? (isAudioDescribedEnabled() ? " Audio Described on." : " Audio Described off.") : ""
522+
mediaType === "audio" ? (audioDescribed.enable ? " Audio Described on." : " Audio Described off.") : ""
521523
}`
522524
)
523-
audioDescribed.callback && audioDescribed.callback(isAudioDescribedEnabled())
525+
526+
audioDescribed.callback && audioDescribed.callback(audioDescribed.enable)
524527
}
525528

526529
function publishMediaState(mediaState) {
@@ -600,6 +603,16 @@ function MSEStrategy(
600603

601604
mediaPlayer.initialize(mediaElement, null)
602605

606+
modifySource(presentationTimeInSeconds, embeddedSubs)
607+
}
608+
609+
function modifySource(presentationTimeInSeconds, embeddedSubs) {
610+
if (mediaPlayer.isReady()) {
611+
// Reset source to apply media settings for the new source
612+
// dash.js will reset media settings if a new source is attached while its initialised with a source
613+
mediaPlayer.attachSource(null)
614+
}
615+
603616
mediaPlayer.setInitialMediaSettingsFor(
604617
"audio",
605618
audioDescribed.enable
@@ -612,18 +625,15 @@ function MSEStrategy(
612625
}
613626
)
614627

628+
const source = mediaSources.currentSource()
629+
const anchor = buildSourceAnchor(presentationTimeInSeconds)
630+
631+
mediaPlayer.attachSource(`${source}${anchor}`)
632+
615633
if (embeddedSubs) {
616634
setUpSubtitleElement(playbackElement)
617635
mediaPlayer.attachTTMLRenderingDiv(subtitleElement)
618636
}
619-
620-
modifySource(presentationTimeInSeconds)
621-
}
622-
623-
function modifySource(presentationTimeInSeconds) {
624-
const source = mediaSources.currentSource()
625-
const anchor = buildSourceAnchor(presentationTimeInSeconds)
626-
mediaPlayer.attachSource(`${source}${anchor}`)
627637
}
628638

629639
/**

0 commit comments

Comments
 (0)