Merge pull request #13596 from bbc/WS-222-clean-up-contentType

WS-222: Delete `componentTrackingContentType` & `contentType`  from e2e assertions

Author: alex-magana

cypress/e2e/pages/topicPage/index.cy.js

@@ -87,7 +87,6 @@ const atiAnalyticsTestSuites = [
     siteId: 59,
     applicationType: 'responsive',
     contentType: 'index-category',
-    componentTrackingContentType: 'topic-page',
     tests: [assertPageView],
   },
   {
@@ -98,7 +97,6 @@ const atiAnalyticsTestSuites = [
     siteId: 33,
     applicationType: 'responsive',
     contentType: 'index-category',
-    componentTrackingContentType: 'topic-page',
     tests: [
       assertPageView,
       assertScrollableNavigationComponentView,

cypress/e2e/specialFeatures/atiAnalytics/assertions/articleLiteSiteLink.js

@@ -5,7 +5,6 @@ const { ARTICLE_LITE_SITE_LINK } = COMPONENTS;
 
 export const assertArticleLiteSiteLinkComponentView = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -21,7 +20,6 @@ export const assertArticleLiteSiteLinkComponentView = ({
     assertATIComponentViewEvent({
       component: ARTICLE_LITE_SITE_LINK,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });
@@ -30,7 +28,6 @@ export const assertArticleLiteSiteLinkComponentView = ({
 
 export const assertArticleLiteSiteLinkComponentClick = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -49,7 +46,6 @@ export const assertArticleLiteSiteLinkComponentClick = ({
     assertATIComponentClickEvent({
       component: ARTICLE_LITE_SITE_LINK,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });

cypress/e2e/specialFeatures/atiAnalytics/assertions/featuresAnalysis.js

@@ -5,7 +5,6 @@ const { FEATURES } = COMPONENTS;
 
 export const assertFeaturesAnalysisComponentView = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -19,7 +18,6 @@ export const assertFeaturesAnalysisComponentView = ({
     assertATIComponentViewEvent({
       component: FEATURES,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });
@@ -28,7 +26,6 @@ export const assertFeaturesAnalysisComponentView = ({
 
 export const assertFeaturesAnalysisComponentClick = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -45,7 +42,6 @@ export const assertFeaturesAnalysisComponentClick = ({
     assertATIComponentClickEvent({
       component: FEATURES,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });

cypress/e2e/specialFeatures/atiAnalytics/assertions/index.js

@@ -270,7 +270,6 @@ const assertViewabilityModelViewEvent = ({
 export const assertATIComponentViewEvent = ({
   component,
   pageIdentifier,
-  contentType,
   applicationType,
   siteId,
 }) => {
@@ -284,7 +283,6 @@ export const assertATIComponentViewEvent = ({
       assertViewabilityModelViewEvent({
         component,
         pageIdentifier,
-        contentType,
         params,
         applicationType,
         siteId,
@@ -320,7 +318,6 @@ const assertViewabilityModelClickEvent = ({
 
 export const assertATIComponentClickEvent = ({
   component,
-  contentType,
   pageIdentifier,
   applicationType,
   siteId,
@@ -333,7 +330,6 @@ export const assertATIComponentClickEvent = ({
       const params = getATIParamsFromURL(url);
       assertViewabilityModelClickEvent({
         component,
-        contentType,
         pageIdentifier,
         params,
         applicationType,

cypress/e2e/specialFeatures/atiAnalytics/assertions/latestMedia.js

@@ -5,7 +5,6 @@ const { LATEST_MEDIA } = COMPONENTS;
 
 export const assertLatestMediaComponentView = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -19,7 +18,6 @@ export const assertLatestMediaComponentView = ({
     assertATIComponentViewEvent({
       component: LATEST_MEDIA,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });
@@ -28,7 +26,6 @@ export const assertLatestMediaComponentView = ({
 
 export const assertLatestMediaComponentClick = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -47,7 +44,6 @@ export const assertLatestMediaComponentClick = ({
     assertATIComponentClickEvent({
       component: LATEST_MEDIA,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });

cypress/e2e/specialFeatures/atiAnalytics/assertions/liteSiteSummary.js

@@ -6,8 +6,6 @@ const { LITE_SITE_SUMMARY } = COMPONENTS;
 // eslint-disable-next-line import/prefer-default-export
 export const assertLiteSiteSummaryComponentToMainSiteClick = ({
   pageIdentifier,
-  contentType,
-  componentTrackingContentType,
   path,
   applicationType,
   siteId,
@@ -26,7 +24,6 @@ export const assertLiteSiteSummaryComponentToMainSiteClick = ({
     assertATIComponentClickEvent({
       component: LITE_SITE_SUMMARY,
       pageIdentifier,
-      contentType: componentTrackingContentType || contentType,
       applicationType,
       siteId,
     });

cypress/e2e/specialFeatures/atiAnalytics/assertions/liveMedia.js

@@ -5,7 +5,6 @@ const { LIVE_MEDIA } = COMPONENTS;
 
 export const assertLiveMediaComponentView = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -21,7 +20,6 @@ export const assertLiveMediaComponentView = ({
     assertATIComponentViewEvent({
       component: LIVE_MEDIA,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });
@@ -30,7 +28,6 @@ export const assertLiveMediaComponentView = ({
 
 export const assertLiveMediaComponentClick = ({
   pageIdentifier,
-  contentType,
   path,
   applicationType,
   siteId,
@@ -48,7 +45,6 @@ export const assertLiveMediaComponentClick = ({
     assertATIComponentClickEvent({
       component: LIVE_MEDIA,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });

cypress/e2e/specialFeatures/atiAnalytics/assertions/messageBanner.js

@@ -5,8 +5,6 @@ const { MESSAGE_BANNER } = COMPONENTS;
 
 export const assertMessageBannerComponentView = ({
   pageIdentifier,
-  contentType,
-  componentTrackingContentType,
   path,
   applicationType,
   siteId,
@@ -22,7 +20,6 @@ export const assertMessageBannerComponentView = ({
     assertATIComponentViewEvent({
       component: MESSAGE_BANNER,
       pageIdentifier,
-      contentType: componentTrackingContentType || contentType,
       applicationType,
       siteId,
     });
@@ -31,8 +28,6 @@ export const assertMessageBannerComponentView = ({
 
 export const assertMessageBannerComponentClick = ({
   pageIdentifier,
-  contentType,
-  componentTrackingContentType,
   path,
   applicationType,
   siteId,
@@ -51,7 +46,6 @@ export const assertMessageBannerComponentClick = ({
     assertATIComponentClickEvent({
       component: MESSAGE_BANNER,
       pageIdentifier,
-      contentType: componentTrackingContentType || contentType,
       applicationType,
       siteId,
     });

cypress/e2e/specialFeatures/atiAnalytics/assertions/mostRead.js

@@ -6,7 +6,6 @@ const { MOST_READ } = COMPONENTS;
 
 export const assertMostReadComponentView = ({
   pageIdentifier,
-  contentType,
   path,
   service,
   applicationType,
@@ -27,7 +26,6 @@ export const assertMostReadComponentView = ({
     assertATIComponentViewEvent({
       component: MOST_READ,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });
@@ -36,7 +34,6 @@ export const assertMostReadComponentView = ({
 
 export const assertMostReadComponentClick = ({
   pageIdentifier,
-  contentType,
   path,
   service,
   applicationType,
@@ -60,7 +57,6 @@ export const assertMostReadComponentClick = ({
     assertATIComponentClickEvent({
       component: MOST_READ,
       pageIdentifier,
-      contentType,
       applicationType,
       siteId,
     });

cypress/e2e/specialFeatures/atiAnalytics/assertions/navigation.js

@@ -5,8 +5,6 @@ const { SCROLLABLE_NAVIGATION, DROPDOWN_NAVIGATION } = COMPONENTS;
 
 export const assertScrollableNavigationComponentView = ({
   pageIdentifier,
-  contentType,
-  componentTrackingContentType,
   path,
   applicationType,
   siteId,
@@ -22,7 +20,6 @@ export const assertScrollableNavigationComponentView = ({
     assertATIComponentViewEvent({
       component: SCROLLABLE_NAVIGATION,
       pageIdentifier,
-      contentType: componentTrackingContentType || contentType,
       applicationType,
       siteId,
     });
@@ -31,8 +28,6 @@ export const assertScrollableNavigationComponentView = ({
 
 export const assertScrollableNavigationComponentClick = ({
   pageIdentifier,
-  contentType,
-  componentTrackingContentType,
   path,
   applicationType,
   siteId,
@@ -51,7 +46,6 @@ export const assertScrollableNavigationComponentClick = ({
     assertATIComponentClickEvent({
       component: SCROLLABLE_NAVIGATION,
       pageIdentifier,
-      contentType: componentTrackingContentType || contentType,
       applicationType,
       siteId,
     });
@@ -61,8 +55,6 @@ export const assertScrollableNavigationComponentClick = ({
 // Assertions for nav bar at smaller breakpoints
 export const assertDropdownNavigationComponentView = ({
   pageIdentifier,
-  contentType,
-  componentTrackingContentType,
   path,
   applicationType,
   siteId,
@@ -77,7 +69,6 @@ export const assertDropdownNavigationComponentView = ({
     assertATIComponentViewEvent({
       component: DROPDOWN_NAVIGATION,
       pageIdentifier,
-      contentType: componentTrackingContentType || contentType,
       applicationType,
       siteId,
     });
@@ -86,8 +77,6 @@ export const assertDropdownNavigationComponentView = ({
 
 export const assertDropdownNavigationComponentClick = ({
   pageIdentifier,
-  contentType,
-  componentTrackingContentType,
   path,
   applicationType,
   siteId,
@@ -105,7 +94,6 @@ export const assertDropdownNavigationComponentClick = ({
     assertATIComponentClickEvent({
       component: DROPDOWN_NAVIGATION,
       pageIdentifier,
-      contentType: componentTrackingContentType || contentType,
       applicationType,
       siteId,
     });