fix: further improve stringifyError

Author: nytamin

packages/shared-lib/src/lib/stringifyError.ts

@@ -11,13 +11,13 @@ export function stringifyError(error: unknown, noStack = false): string {
 			// Has a custom toString() method
 			str = `${(error as any).toString()}`
 		} else {
-			const strings: string[] = []
-			if (typeof (error as any).rawError === 'string') strings.push(`${(error as any).rawError}`) // Is an UserError
-			if (typeof (error as Error).message === 'string') strings.push(`${(error as Error).message}`) // Is an Error
-			if (typeof (error as any).reason === 'string') strings.push(`${(error as any).reason}`) // Is a Meteor.Error
-			if (typeof (error as any).details === 'string') strings.push(` ${(error as any).details}`)
-
-			str = strings.join(', ')
+			const strings: (string | undefined)[] = [
+				stringify((error as any).rawError), // UserError
+				stringify((error as Error).message), // Error
+				stringify((error as any).reason), // Meteor.Error
+				stringify((error as any).details),
+			]
+			str = strings.filter(Boolean).join(', ')
 		}
 
 		if (!str) {
@@ -46,3 +46,15 @@ export function stringifyError(error: unknown, noStack = false): string {
 
 	return str
 }
+
+function stringify(v: any): string | undefined {
+	// Tries to stringify objects if they have a toString() that returns something sensible
+	if (v === undefined) return undefined
+	if (v === null) return 'null'
+
+	if (typeof v === 'object') {
+		const str = `${v}`
+		if (str !== '[object Object]') return str
+		return undefined
+	} else return `${v}`
+}