fix: lost errors in some publications

Author: Julusian

meteor/server/api/deviceTriggers/RundownsObserver.ts

@@ -5,6 +5,8 @@ import { literal } from '@sofie-automation/corelib/dist/lib'
 import { MongoFieldSpecifierOnesStrict } from '@sofie-automation/corelib/dist/mongo'
 import { DBRundown } from '@sofie-automation/corelib/dist/dataModel/Rundown'
 import { PromiseDebounce } from '../../publications/lib/PromiseDebounce'
+import { stringifyError } from '@sofie-automation/shared-lib/dist/lib/stringifyError'
+import { logger } from '../../logging'
 
 const REACTIVITY_DEBOUNCE = 20
 
@@ -24,15 +26,19 @@ export class RundownsObserver {
 	#disposed = false
 
 	readonly #triggerUpdateRundownContent = new PromiseDebounce(async () => {
-		if (this.#disposed) return
+		try {
+			if (this.#disposed) return
 
-		if (!this.#changed) return
-		this.#cleanup?.()
+			if (!this.#changed) return
+			this.#cleanup?.()
 
-		const changed = this.#changed
-		this.#cleanup = await changed(this.rundownIds)
+			const changed = this.#changed
+			this.#cleanup = await changed(this.rundownIds)
 
-		if (this.#disposed) this.#cleanup?.()
+			if (this.#disposed) this.#cleanup?.()
+		} catch (e) {
+			logger.error(`Error in RundownsObserver triggerUpdateRundownContent: ${stringifyError(e)}`)
+		}
 	}, REACTIVITY_DEBOUNCE)
 
 	private constructor(onChanged: ChangedHandler) {

meteor/server/publications/lib/PromiseDebounce.ts

@@ -38,6 +38,7 @@ export class PromiseDebounce<TResult = void, TArgs extends unknown[] = []> {
 
 	/**
 	 * Trigger an execution, but don't report the result.
+	 * Warning: If the function throws an error, that will not be logged or reported to the caller
 	 */
 	trigger = (...args: TArgs): void => {
 		// If an execution is 'imminent', don't do anything

meteor/server/publications/lib/rundownsObserver.ts

@@ -2,6 +2,8 @@ import { Meteor } from 'meteor/meteor'
 import { RundownId, RundownPlaylistId, StudioId } from '@sofie-automation/corelib/dist/dataModel/Ids'
 import { Rundowns } from '../../collections'
 import { PromiseDebounce } from './PromiseDebounce'
+import { logger } from '../../logging'
+import { stringifyError } from '@sofie-automation/shared-lib/dist/lib/stringifyError'
 
 const REACTIVITY_DEBOUNCE = 20
 
@@ -20,14 +22,22 @@ export class RundownsObserver implements Meteor.LiveQueryHandle {
 	#disposed = false
 
 	readonly #triggerUpdateRundownContent = new PromiseDebounce(async () => {
-		if (this.#disposed) return
-		if (!this.#changed) return
-		this.#cleanup?.()
-
-		const changed = this.#changed
-		this.#cleanup = await changed(this.rundownIds)
-
-		if (this.#disposed) this.#cleanup?.()
+		try {
+			if (this.#disposed) return
+			if (!this.#changed) return
+			this.#cleanup?.()
+			this.#cleanup = undefined
+
+			const changed = this.#changed
+			this.#cleanup = await changed(this.rundownIds)
+
+			if (this.#disposed) {
+				this.#cleanup?.()
+				this.#cleanup = undefined
+			}
+		} catch (e) {
+			logger.error(`Error in RundownsObserver triggerUpdateRundownContent: ${stringifyError(e)}`)
+		}
 	}, REACTIVITY_DEBOUNCE)
 
 	private constructor(onChanged: ChangedHandler) {