fix: Cannot replace infinite PieceInstance during normal operation SOFIE-3305

Julusian · Julusian · commit 13264bb5a480 · 2024-06-28T15:12:24.000+01:00
Pieces are deleted by setting them to `null`, so a `.has` check will match deleted pieces which is not desired
diff --git a/packages/job-worker/src/playout/model/implementation/PlayoutPartInstanceModelImpl.ts b/packages/job-worker/src/playout/model/implementation/PlayoutPartInstanceModelImpl.ts
@@ -384,7 +384,7 @@ export class PlayoutPartInstanceModelImpl implements PlayoutPartInstanceModel {
 		}
 
 		for (const pieceInstance of pieceInstances) {
-			if (this.pieceInstancesImpl.has(pieceInstance._id))
+			if (this.pieceInstancesImpl.get(pieceInstance._id))
 				throw new Error(
 					`Cannot replace infinite PieceInstance "${pieceInstance._id}" as it replaces a non-infinite`
 				)

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ export class PlayoutPartInstanceModelImpl implements PlayoutPartInstanceModel {`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`for (const pieceInstance of pieceInstances) {`
`387`		`- if (this.pieceInstancesImpl.has(pieceInstance._id))`
	`387`	`+ if (this.pieceInstancesImpl.get(pieceInstance._id))`
`388`	`388`	`throw new Error(`
`389`	`389`	`Cannot replace infinite PieceInstance "${pieceInstance._id}" as it replaces a non-infinite`
`390`	`390`	`)`