fix: go to renderDataMissing() is rundown is not found - and revert previous implentation

Author: olzzon

meteor/client/lib/ReactMeteorData/ReactMeteorData.tsx

@@ -402,6 +402,7 @@ export function useSubscription<K extends keyof AllPubSubTypes>(
 /**
  * A Meteor Subscription hook that allows using React Functional Components and the Hooks API with Meteor subscriptions.
  * Subscriptions will be torn down 1000ms after unmounting the component.
+ * If the subscription is not enabled, the subscription will not be created, and the ready state will always be true.
  *
  * @export
  * @param {PubSub} sub The subscription to be subscribed to
@@ -418,7 +419,6 @@ export function useSubscriptionIfEnabled<K extends keyof AllPubSubTypes>(
 
 	useEffect(() => {
 		if (!enable) {
-			setReady(false)
 			return
 		}
 
@@ -432,7 +432,7 @@ export function useSubscriptionIfEnabled<K extends keyof AllPubSubTypes>(
 		}
 	}, [sub, enable, stringifyObjects(args)])
 
-	return ready
+	return !enable || ready
 }
 
 /**

meteor/client/styles/rundownView.scss

@@ -3256,21 +3256,6 @@ svg.icon {
 		left: 50%;
 		transform: translate(-150%, -50%);
 	}
-
-	> .rundown-view__label {
-		position: absolute;
-		top: 60%;
-		left: 1%;
-		right: 0;
-		text-align: center;
-		font-size: 3em;
-		transform: translateY(-50%);
-
-		> p {
-			margin: 20px auto;
-			max-width: 1200px;
-		}
-	}
 }
 
 .rundown-view {

meteor/client/ui/RundownView.tsx

@@ -3257,27 +3257,9 @@ const RundownViewContent = translateWithTracker<IPropsWithReady, IState, ITracke
 		}
 
 		render(): JSX.Element {
-			const { t } = this.props
 			if (!this.props.subsReady) {
 				return (
 					<div className="rundown-view rundown-view--loading">
-						<div className="rundown-view__label">
-							<p>
-								<Route
-									render={({ history }) => (
-										<button
-											className="btn btn-primary"
-											onClick={() => {
-												history.push('/rundowns')
-											}}
-										>
-											{t('Return to list')}
-										</button>
-									)}
-								/>
-							</p>
-						</div>
-
 						<Spinner />
 					</div>
 				)