fix: don't expose viewPortScrollingState use getViewPortScrollingState() instead

Author: olzzon

packages/webui/src/client/lib/VirtualElement.tsx

@@ -1,6 +1,6 @@
 import React, { useCallback, useEffect, useLayoutEffect, useMemo, useState } from 'react'
 import { InView } from 'react-intersection-observer'
-import { viewPortScrollingState } from './viewPort'
+import { getViewPortScrollingState } from './viewPort'
 
 interface IElementMeasurements {
 	width: string | number
@@ -91,11 +91,11 @@ export function VirtualElement({
 
 	const isScrolling = (): boolean => {
 		// Don't do updates while scrolling:
-		if (viewPortScrollingState.isProgrammaticScrollInProgress) {
+		if (getViewPortScrollingState().isProgrammaticScrollInProgress) {
 			return true
 		}
 		// And wait if a programmatic scroll was done recently:
-		const timeSinceLastProgrammaticScroll = Date.now() - viewPortScrollingState.lastProgrammaticScrollTime
+		const timeSinceLastProgrammaticScroll = Date.now() - getViewPortScrollingState().lastProgrammaticScrollTime
 		if (timeSinceLastProgrammaticScroll < 100) {
 			return true
 		}

packages/webui/src/client/lib/viewPort.ts

@@ -16,6 +16,18 @@ const focusState = {
 	startTime: 0,
 }
 
+const viewPortScrollingState = {
+	isProgrammaticScrollInProgress: false,
+	lastProgrammaticScrollTime: 0,
+}
+
+export function getViewPortScrollingState(): {
+	isProgrammaticScrollInProgress: boolean
+	lastProgrammaticScrollTime: number
+} {
+	return viewPortScrollingState
+}
+
 export function maintainFocusOnPartInstance(
 	partInstanceId: PartInstanceId,
 	timeWindow: number,
@@ -275,11 +287,6 @@ function getRegionPosition(topElement: HTMLElement, bottomElement: HTMLElement):
 	return { top, bottom }
 }
 
-export const viewPortScrollingState = {
-	isProgrammaticScrollInProgress: false,
-	lastProgrammaticScrollTime: 0,
-}
-
 export async function scrollToPosition(scrollPosition: number, noAnimation?: boolean): Promise<void> {
 	// Calculate the exact position
 	const headerOffset = getHeaderHeight() + HEADER_MARGIN