Merge pull request Sofie-Automation#1208 from nrkno/fix/live-status-gateway-logging

Fix: live status gateway settings not used

Author: nytamin

packages/live-status-gateway/src/coreHandler.ts

@@ -15,11 +15,7 @@ import {
 	PeripheralDeviceType,
 } from '@sofie-automation/shared-lib/dist/peripheralDevice/peripheralDeviceAPI'
 import { protectString } from '@sofie-automation/shared-lib/dist/lib/protectedString'
-import {
-	PeripheralDeviceCommandId,
-	PeripheralDeviceId,
-	StudioId,
-} from '@sofie-automation/shared-lib/dist/core/model/Ids'
+import { PeripheralDeviceCommandId, StudioId } from '@sofie-automation/shared-lib/dist/core/model/Ids'
 import { StatusCode } from '@sofie-automation/shared-lib/dist/lib/status'
 import { PeripheralDeviceCommand } from '@sofie-automation/shared-lib/dist/core/model/PeripheralDeviceCommand'
 import { LiveStatusGatewayConfig } from './generated/options'
@@ -137,8 +133,9 @@ export class CoreHandler {
 		}
 		// setup observers
 		const observer = this.core.observe(PeripheralDevicePubSubCollectionsNames.peripheralDeviceForDevice)
-		observer.added = (id) => this.onDeviceChanged(id)
-		observer.changed = (id) => this.onDeviceChanged(id)
+		observer.added = () => this.onDeviceChanged()
+		observer.changed = () => this.onDeviceChanged()
+		this.onDeviceChanged() // set initial settings
 		this.setupObserverForPeripheralDeviceCommands(this)
 	}
 	async destroy(): Promise<void> {
@@ -178,15 +175,18 @@ export class CoreHandler {
 		this._onConnected = fcn
 	}
 
-	onDeviceChanged(id: PeripheralDeviceId): void {
-		if (id !== this.core.deviceId) return
+	onDeviceChanged(): void {
 		const col = this.core.getCollection<PeripheralDeviceForDevice>(
 			PeripheralDevicePubSubCollectionsNames.peripheralDeviceForDevice
 		)
 		if (!col) throw new Error('collection "peripheralDeviceForDevice" not found!')
-		const device = col.findOne(id)
 
-		this.deviceSettings = device?.deviceSettings || {}
+		const device = col.findOne(this.core.deviceId)
+		if (!device) {
+			throw new Error(`No "peripheralDeviceForDevice" with id "${this.core.deviceId}" found!`)
+		}
+
+		this.deviceSettings = device.deviceSettings || {}
 		const logLevel = this.deviceSettings['debugLogging'] ? 'debug' : 'info'
 		if (logLevel !== this.logger.level) {
 			this.logger.level = logLevel
@@ -198,7 +198,7 @@ export class CoreHandler {
 			this.logger.info('Loglevel: ' + this.logger.level)
 		}
 
-		const studioId = device?.studioId
+		const studioId = device.studioId
 		if (studioId === undefined) {
 			throw new Error(`Live status gateway must be attached to a studio`)
 		}