fix: abreviation should be used even if it's an empty string

olzzon · olzzon · commit 2e9ff13db3e5 · 2025-03-07T07:36:57.000+01:00
diff --git a/packages/webui/src/client/ui/PieceIcons/Renderers/CamInputIcon.tsx b/packages/webui/src/client/ui/PieceIcons/Renderers/CamInputIcon.tsx
@@ -32,7 +32,7 @@ export function CamInputIcon({
 					style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '75px', fontWeight: 100 }}
 					className="label"
 				>
-					{abbreviation ? abbreviation : 'C'}
+					{abbreviation !== undefined ? abbreviation : 'C'}
 					<tspan style={{ fontFamily: 'Roboto', fontWeight: 'normal' }}>
 						{inputIndex !== undefined ? inputIndex : ''}
 					</tspan>
diff --git a/packages/webui/src/client/ui/PieceIcons/Renderers/GraphicsInputIcon.tsx b/packages/webui/src/client/ui/PieceIcons/Renderers/GraphicsInputIcon.tsx
@@ -22,7 +22,7 @@ export function GraphicsInputIcon({ abbreviation }: { abbreviation?: string }):
 					style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '75px', fontWeight: 100 }}
 					className="label"
 				>
-					{abbreviation ? abbreviation : 'G'}
+					{abbreviation !== undefined ? abbreviation : 'G'}
 				</tspan>
 			</text>
 		</svg>
diff --git a/packages/webui/src/client/ui/PieceIcons/Renderers/LiveSpeakInputIcon.tsx b/packages/webui/src/client/ui/PieceIcons/Renderers/LiveSpeakInputIcon.tsx
@@ -27,7 +27,7 @@ export function LiveSpeakInputIcon({ abbreviation }: { abbreviation?: string }):
 					style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '62px', fontWeight: 100 }}
 					className="label"
 				>
-					{abbreviation ? abbreviation : 'LSK'}
+					{abbreviation !== undefined ? abbreviation : 'LSK'}
 				</tspan>
 			</text>
 		</svg>
diff --git a/packages/webui/src/client/ui/PieceIcons/Renderers/RemoteInputIcon.tsx b/packages/webui/src/client/ui/PieceIcons/Renderers/RemoteInputIcon.tsx
@@ -29,7 +29,7 @@ export function RemoteInputIcon({
 }): JSX.Element {
 	return (
 		<BaseRemoteInputIcon className="remote">
-			{abbreviation ? abbreviation : 'LIVE'}
+			{abbreviation !== undefined ? abbreviation : 'LIVE'}
 			<tspan style={{ fontFamily: 'Roboto', fontWeight: 'normal' }}>{inputIndex ?? ''}</tspan>
 		</BaseRemoteInputIcon>
 	)
diff --git a/packages/webui/src/client/ui/PieceIcons/Renderers/RemoteSpeakInputIcon.tsx b/packages/webui/src/client/ui/PieceIcons/Renderers/RemoteSpeakInputIcon.tsx
@@ -27,7 +27,7 @@ export function RemoteSpeakInputIcon({ abbreviation }: { abbreviation?: string }
 					style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '62px', fontWeight: 100 }}
 					className="label"
 				>
-					{abbreviation ? abbreviation : 'RSK'}
+					{abbreviation !== undefined ? abbreviation : 'RSK'}
 				</tspan>
 			</text>
 		</svg>
diff --git a/packages/webui/src/client/ui/PieceIcons/Renderers/VTInputIcon.tsx b/packages/webui/src/client/ui/PieceIcons/Renderers/VTInputIcon.tsx
@@ -22,7 +22,7 @@ export function VTInputIcon({ abbreviation }: { abbreviation?: string }): JSX.El
 					y="71.513954"
 					style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '75px', fontWeight: 100 }}
 				>
-					{abbreviation ? abbreviation : 'VT'}
+					{abbreviation !== undefined ? abbreviation : 'VT'}
 				</tspan>
 			</text>
 		</svg>

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export function CamInputIcon({`
`32`	`32`	`style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '75px', fontWeight: 100 }}`
`33`	`33`	`className="label"`
`34`	`34`	`>`
`35`		`- {abbreviation ? abbreviation : 'C'}`
	`35`	`+ {abbreviation !== undefined ? abbreviation : 'C'}`
`36`	`36`	`<tspan style={{ fontFamily: 'Roboto', fontWeight: 'normal' }}>`
`37`	`37`	`{inputIndex !== undefined ? inputIndex : ''}`
`38`	`38`	`</tspan>`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export function GraphicsInputIcon({ abbreviation }: { abbreviation?: string }):`
`22`	`22`	`style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '75px', fontWeight: 100 }}`
`23`	`23`	`className="label"`
`24`	`24`	`>`
`25`		`- {abbreviation ? abbreviation : 'G'}`
	`25`	`+ {abbreviation !== undefined ? abbreviation : 'G'}`
`26`	`26`	`</tspan>`
`27`	`27`	`</text>`
`28`	`28`	`</svg>`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export function LiveSpeakInputIcon({ abbreviation }: { abbreviation?: string }):`
`27`	`27`	`style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '62px', fontWeight: 100 }}`
`28`	`28`	`className="label"`
`29`	`29`	`>`
`30`		`- {abbreviation ? abbreviation : 'LSK'}`
	`30`	`+ {abbreviation !== undefined ? abbreviation : 'LSK'}`
`31`	`31`	`</tspan>`
`32`	`32`	`</text>`
`33`	`33`	`</svg>`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export function RemoteInputIcon({`
`29`	`29`	`}): JSX.Element {`
`30`	`30`	`return (`
`31`	`31`	`<BaseRemoteInputIcon className="remote">`
`32`		`- {abbreviation ? abbreviation : 'LIVE'}`
	`32`	`+ {abbreviation !== undefined ? abbreviation : 'LIVE'}`
`33`	`33`	`<tspan style={{ fontFamily: 'Roboto', fontWeight: 'normal' }}>{inputIndex ?? ''}</tspan>`
`34`	`34`	`</BaseRemoteInputIcon>`
`35`	`35`	`)`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export function RemoteSpeakInputIcon({ abbreviation }: { abbreviation?: string }`
`27`	`27`	`style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '62px', fontWeight: 100 }}`
`28`	`28`	`className="label"`
`29`	`29`	`>`
`30`		`- {abbreviation ? abbreviation : 'RSK'}`
	`30`	`+ {abbreviation !== undefined ? abbreviation : 'RSK'}`
`31`	`31`	`</tspan>`
`32`	`32`	`</text>`
`33`	`33`	`</svg>`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export function VTInputIcon({ abbreviation }: { abbreviation?: string }): JSX.El`
`22`	`22`	`y="71.513954"`
`23`	`23`	`style={{ fill: '#ffffff', fontFamily: 'Roboto', fontSize: '75px', fontWeight: 100 }}`
`24`	`24`	`>`
`25`		`- {abbreviation ? abbreviation : 'VT'}`
	`25`	`+ {abbreviation !== undefined ? abbreviation : 'VT'}`
`26`	`26`	`</tspan>`
`27`	`27`	`</text>`
`28`	`28`	`</svg>`