chore: review comments

Author: Julusian

packages/mos-gateway/src/CoreMosDeviceHandler.ts

@@ -62,6 +62,10 @@ interface IStoryItemChange {
 	itemDiff: PartialDeep<IMOSItem>
 }
 
+export interface CoreMosDeviceHandlerOptions {
+	openMediaHotStandby?: boolean
+}
+
 /**
  * Represents a connection between a mos-device and Core
  */
@@ -76,15 +80,20 @@ export class CoreMosDeviceHandler {
 	private _pendingStoryItemChanges: Array<IStoryItemChange> = []
 	private _pendingChangeTimeout: number = 60 * 1000
 	private mosTypes: MosTypes
-	private _openMediaHotStandby: boolean
+	private _options: CoreMosDeviceHandlerOptions
 
 	private _messageQueue: Queue
 
-	constructor(parent: CoreHandler, mosDevice: IMOSDevice, mosHandler: MosHandler, openMediaHotStandby: boolean) {
+	constructor(
+		parent: CoreHandler,
+		mosDevice: IMOSDevice,
+		mosHandler: MosHandler,
+		options: CoreMosDeviceHandlerOptions
+	) {
 		this._coreParentHandler = parent
 		this._mosDevice = mosDevice
 		this._mosHandler = mosHandler
-		this._openMediaHotStandby = openMediaHotStandby
+		this._options = options
 
 		this._messageQueue = new Queue()
 
@@ -141,7 +150,7 @@ export class CoreMosDeviceHandler {
 		let statusCode: StatusCode
 		const messages: Array<string> = []
 
-		if (this._openMediaHotStandby) {
+		if (this._options.openMediaHotStandby) {
 			// OpenMedia treats secondary server as hot-standby
 			// And thus is not considered as a warning if it's not connected
 			if (connectionStatus.PrimaryConnected) {

packages/mos-gateway/src/coreHandler.ts

@@ -18,7 +18,7 @@ import { MosHandler } from './mosHandler'
 import { DeviceConfig } from './connector'
 import { MOS_DEVICE_CONFIG_MANIFEST } from './configManifest'
 import { getVersions } from './versions'
-import { CoreMosDeviceHandler } from './CoreMosDeviceHandler'
+import { CoreMosDeviceHandler, CoreMosDeviceHandlerOptions } from './CoreMosDeviceHandler'
 import { PeripheralDeviceCommandId } from '@sofie-automation/shared-lib/dist/core/model/Ids'
 
 export interface CoreConfig {
@@ -145,10 +145,10 @@ export class CoreHandler {
 	async registerMosDevice(
 		mosDevice: IMOSDevice,
 		mosHandler: MosHandler,
-		openMediaHotStandby: boolean
+		deviceOptions: CoreMosDeviceHandlerOptions
 	): Promise<CoreMosDeviceHandler> {
 		this.logger.info('registerMosDevice -------------')
-		const coreMos = new CoreMosDeviceHandler(this, mosDevice, mosHandler, openMediaHotStandby)
+		const coreMos = new CoreMosDeviceHandler(this, mosDevice, mosHandler, deviceOptions)
 
 		this._coreMosHandlers.push(coreMos)
 		return coreMos.init().then(() => {

packages/mos-gateway/src/mosHandler.ts

@@ -243,11 +243,11 @@ export class MosHandler {
 
 				if (!this._coreHandler) throw Error('_coreHandler is undefined!')
 
-				const coreMosHandler = await this._coreHandler.registerMosDevice(
-					mosDevice,
-					this,
-					mosDevice.idSecondary ? this._openMediaHotStandby[mosDevice.idSecondary] : false
-				)
+				const coreMosHandler = await this._coreHandler.registerMosDevice(mosDevice, this, {
+					openMediaHotStandby: mosDevice.idSecondary
+						? this._openMediaHotStandby[mosDevice.idSecondary]
+						: false,
+				})
 				// this._logger.info('mosDevice registered -------------')
 				// Setup message flow between the devices: