Merge pull request Sofie-Automation#1257 from nrkno/fix/infinite-piece-display/sofie-3408

fix(LinePartTimeline): make rules for findMainPiece consistent (SOFIE-3408)

Author: jstarpl

meteor/client/ui/SegmentList/LinePartSecondaryPiece/LinePartSecondaryPiece.tsx

@@ -38,7 +38,7 @@ export const LinePartSecondaryPiece: React.FC<IProps> = React.memo(function Line
 	const typeClass = piece?.sourceLayer?.type ? RundownUtils.getSourceLayerClassName(piece?.sourceLayer?.type) : ''
 
 	const pieceStyle = useMemo<CSSProperties>(() => {
-		const width = timeInBase(piece.renderedDuration ?? partDuration, timelineBase, timelineBase)
+		const width = timeInBase(piece.renderedDuration ?? Math.max(timelineBase, partDuration), timelineBase, timelineBase)
 		const left = timeInBase(piece.renderedInPoint ?? 0, timelineBase, timelineBase)
 		const overflow = Math.max(0, left + width - 100)
 		return {

meteor/client/ui/SegmentList/LinePartTimeline.tsx

@@ -14,9 +14,12 @@ import { PieceUi } from '../SegmentContainer/withResolvedSegment'
 import StudioContext from '../RundownView/StudioContext'
 import { InvalidPartCover } from '../SegmentTimeline/Parts/InvalidPartCover'
 import { getPartInstanceTimingId } from '../../lib/rundownTiming'
+import { getShowHiddenSourceLayers } from '../../lib/localStorage'
 
 const TIMELINE_DEFAULT_BASE = 30 * 1000
 
+const showHiddenSourceLayers = getShowHiddenSourceLayers()
+
 interface IProps {
 	part: PartExtended
 	isLive: boolean
@@ -56,7 +59,7 @@ function findTimelineGraphics(pieces: PieceExtended[]) {
 		.filter((piece) => {
 			if (
 				piece.sourceLayer?.type === SourceLayerType.LOWER_THIRD &&
-				!piece.sourceLayer?.isHidden &&
+				(showHiddenSourceLayers || !piece.sourceLayer?.isHidden) &&
 				((piece.instance.piece.lifespan === PieceLifespan.WithinPart && piece.instance.piece.enable.duration) ||
 					!piece.sourceLayer?.onListViewColumn)
 			) {

meteor/client/ui/SegmentStoryboard/StoryboardPartThumbnail/StoryboardPartThumbnail.tsx

@@ -21,7 +21,7 @@ const supportedSourceLayerTypes = new Set(
 
 function findMainPiece(pieces: PieceExtended[]) {
 	return findPieceExtendedToShowFromOrderedResolvedInstances(
-		pieces.filter((piece) => piece.outputLayer?.isPGM),
+		pieces.filter((piece) => piece.outputLayer?.isPGM && piece.sourceLayer?.onPresenterScreen),
 		supportedSourceLayerTypes
 	)
 }