fix: nocommits

Author: Julusian

packages/job-worker/src/ingest/expectedPackages.ts

@@ -154,9 +154,8 @@ async function writeUpdatedExpectedPackages(
 						_id: doc._id,
 						ingestSources: {
 							// This is pretty messy, but we need to make sure that we don't add the same source twice
-							// nocommit - does this work?
 							$not: {
-								elemMatch: matchSource,
+								$elemMatch: matchSource,
 							},
 						},
 					},
@@ -208,7 +207,6 @@ export async function updateExpectedPackagesForBucketAdLibPiece(
 	await writeUpdatedExpectedPackages(context, adlib.bucketId, documentsToSave, {
 		fromPieceType: ExpectedPackageDBType.BUCKET_ADLIB,
 		pieceId: adlib._id,
-		// nocommit - does this work?
 	})
 }
 
@@ -221,7 +219,6 @@ export async function updateExpectedPackagesForBucketAdLibAction(
 	await writeUpdatedExpectedPackages(context, action.bucketId, documentsToSave, {
 		fromPieceType: ExpectedPackageDBType.BUCKET_ADLIB_ACTION,
 		pieceId: action._id,
-		// nocommit - does this work?
 	})
 }
 
@@ -236,14 +233,7 @@ export async function cleanUpExpectedPackagesForBucketAdLibs(
 			{
 				studioId: context.studioId,
 				bucketId: bucketId,
-				ingestSources: {
-					$elemMatch: {
-						fromPieceType: {
-							$in: [ExpectedPackageDBType.BUCKET_ADLIB, ExpectedPackageDBType.BUCKET_ADLIB_ACTION],
-						},
-						pieceId: { $in: adLibIds },
-					},
-				},
+				// Note: this could have the ingestSources match, but that feels excessive as the $pull performs the same check
 			},
 			{
 				$pull: {
@@ -252,7 +242,7 @@ export async function cleanUpExpectedPackagesForBucketAdLibs(
 							$in: [ExpectedPackageDBType.BUCKET_ADLIB, ExpectedPackageDBType.BUCKET_ADLIB_ACTION],
 						},
 						pieceId: { $in: adLibIds },
-					} as any, // nocommit - can we avoid this? Does this query even work?
+					} as any, // This cast isn't nice, but is needed for some reason
 				},
 			}
 		)

packages/job-worker/src/ingest/model/implementation/SaveIngestModel.ts

@@ -152,8 +152,8 @@ async function writeExpectedPackagesChangesForRundown(
 				},
 			})
 		} else {
-			// nocommit - perform some diffing?
 			// Document already exists, perform an update to preserve other fields
+			// Future: would it be beneficial to perform some diffing to only update the field if it has changed?
 			ops.push({
 				updateOne: {
 					filter: { _id: doc._id },

packages/job-worker/src/playout/snapshot.ts

@@ -410,7 +410,7 @@ export async function handleRestorePlaylistSnapshot(
 
 			// Generate a unique id for the package.
 			// This is done differently to ensure we don't have id collisions that the documents arent expecting
-			// nocommit - maybe this should do the work to generate in the new deduplicated form?
+			// Note: maybe this should do the work to generate in the new deduplicated form, but that likely has no benefit
 			let packageOwnerId: string
 			const ownerPieceType = source.fromPieceType
 			switch (source.fromPieceType) {