chore: fix server-core-integration linter errors

Author: Julusian

packages/server-core-integration/examples/client.ts

@@ -4,7 +4,7 @@ import {
 	PeripheralDeviceCategory,
 	PeripheralDeviceType,
 } from '@sofie-automation/shared-lib/dist/peripheralDevice/peripheralDeviceAPI'
-import { CoreConnection, PeripheralDevicePubSub, PeripheralDevicePubSubCollectionsNames } from '../src/index'
+import { CoreConnection, PeripheralDevicePubSub, PeripheralDevicePubSubCollectionsNames } from '../src/index.js'
 
 const core = new CoreConnection({
 	deviceId: protectString('ExampleDevice'),

packages/server-core-integration/src/__tests__/index.spec.ts

@@ -368,7 +368,7 @@ describe('coreConnection', () => {
 
 		// temporary scramble the ddp host:
 		options.host = '127.0.0.9'
-		core.ddp.ddpClient && core.ddp.ddpClient.resetOptions(options)
+		core.ddp.ddpClient?.resetOptions(options)
 		// Force-close the socket:
 		core.ddp.ddpClient?.socket?.close()
 
@@ -379,7 +379,7 @@ describe('coreConnection', () => {
 
 		// restore ddp host:
 		options.host = '127.0.0.1'
-		core.ddp.ddpClient && core.ddp.ddpClient.resetOptions(options)
+		core.ddp.ddpClient?.resetOptions(options)
 		await wait(1000)
 		// should have reconnected by now
 

packages/server-core-integration/src/lib/CoreConnectionChild.ts

@@ -147,7 +147,7 @@ export class CoreConnectionChild<
 	 */
 	async callMethodRaw(methodName: string, attrs: Array<any>): Promise<any> {
 		if (this._destroyed) {
-			throw 'callMethod: CoreConnection has been destroyed'
+			throw new Error('callMethod: CoreConnection has been destroyed')
 		}
 
 		return this._methodQueue.callMethodRaw(methodName, attrs)

packages/server-core-integration/src/lib/__tests__/watchDog.spec.ts

@@ -19,7 +19,7 @@ describe('watchDog', () => {
 
 		return new Promise<void>((resolver, reject) => {
 			if (coreIsHappy) resolver()
-			else if (coreReplies) reject()
+			else if (coreReplies) reject(new Error('Core is not happy'))
 		})
 	})
 	const exitFcn = jest.fn(() => {

packages/server-core-integration/src/lib/coreConnection.ts

@@ -27,7 +27,6 @@ import {
 	PeripheralDevicePubSubTypes,
 } from '@sofie-automation/shared-lib/dist/pubsub/peripheralDevice'
 
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const PkgInfo = require('../../package.json')
 
 export interface CoreCredentials {
@@ -272,7 +271,7 @@ export class CoreConnection<
 	 */
 	async callMethodRaw(methodName: string, attrs: Array<any>): Promise<any> {
 		if (this._destroyed) {
-			throw 'callMethod: CoreConnection has been destroyed'
+			throw new Error('callMethod: CoreConnection has been destroyed')
 		}
 
 		if (!this._methodQueue) throw new Error('Connection is not ready to call methods')
@@ -444,7 +443,7 @@ export class CoreConnection<
 				} else {
 					i++
 					if (i > 50) {
-						reject()
+						reject(new Error('Watchdog ping timeout'))
 					} else {
 						setTimeout(checkPingReply, 300)
 					}

packages/server-core-integration/src/lib/ddpClient.ts

@@ -405,7 +405,7 @@ export class DDPClient extends EventEmitter<DDPClientEvents> {
 	constructor(opts?: DDPConnectorOptions) {
 		super()
 
-		opts || (opts = { host: '127.0.0.1', port: 3000, tlsOpts: {} })
+		opts = opts || { host: '127.0.0.1', port: 3000, tlsOpts: {} }
 
 		this.resetOptions(opts)
 		this.ddpVersionInt = opts.ddpVersion || '1'
@@ -810,7 +810,7 @@ export class DDPClient extends EventEmitter<DDPClientEvents> {
 
 	close(): void {
 		this.isClosing = true
-		this.socket && this.socket.close() // with mockJS connection, might not get created
+		this.socket?.close() // with mockJS connection, might not get created
 		this.removeAllListeners('connected')
 		this.removeAllListeners('failed')
 	}

packages/server-core-integration/src/lib/methods.ts

@@ -76,23 +76,25 @@ export class ConnectionMethodsQueue {
 	async callMethodRaw(methodName: string, attrs: Array<any>): Promise<any> {
 		return new Promise((resolve, reject) => {
 			if (!methodName) {
-				reject('callMethod: argument missing: methodName')
+				reject(new Error('callMethod: argument missing: methodName'))
 				return
 			}
 
 			const fullAttrs = [this._credentials.deviceId, this._credentials.deviceToken].concat(attrs || [])
 
 			this._timeLastMethodCall = Date.now()
 			if (!this._ddp.ddpClient) {
-				reject('callMehod: DDP client has not been initialized')
+				reject(new Error('callMehod: DDP client has not been initialized'))
 				return
 			}
 			const timeout = setTimeout(() => {
 				// Timeout
 				console.error(`Timeout "${methodName}"`)
 				console.error(JSON.stringify(fullAttrs))
 				reject(
-					`Timeout when calling method "${methodName}", arguments: ${JSON.stringify(fullAttrs).slice(0, 200)}`
+					new Error(
+						`Timeout when calling method "${methodName}", arguments: ${JSON.stringify(fullAttrs).slice(0, 200)}`
+					)
 				)
 			}, 10 * 1000) // 10 seconds
 			this._ddp.ddpClient.call(methodName, fullAttrs, (err: DDPError | undefined, result: any) => {
@@ -109,6 +111,7 @@ export class ConnectionMethodsQueue {
 							}
 						}
 					}
+
 					reject(err)
 				} else {
 					resolve(result)

packages/server-core-integration/src/lib/subscriptions.ts

@@ -44,7 +44,7 @@ export class SubscriptionsHelper<PubSubTypes> {
 		const orgError = new Error()
 		return new Promise((resolve, reject) => {
 			if (!this.#ddp.ddpClient) {
-				reject('subscribe: DDP client is not initialized')
+				reject(new Error('subscribe: DDP client is not initialized'))
 				return
 			}
 			try {
@@ -67,7 +67,7 @@ export class SubscriptionsHelper<PubSubTypes> {
 					unprotectString(existingSubscriptionId)
 				)
 			} catch (e) {
-				reject(e)
+				reject(e instanceof Error ? e : new Error('subscribe failed: ' + e))
 			}
 		})
 	}

packages/server-core-integration/src/lib/watchDog.ts

@@ -85,7 +85,7 @@ export class WatchDog extends EventEmitter<WatchDogEvents> {
 				if (this.listenerCount('exit') > 0) {
 					this.emit('exit')
 				} else {
-					// eslint-disable-next-line no-process-exit
+					// eslint-disable-next-line n/no-process-exit
 					process.exit(42)
 				}
 			}, 5000)