Change the setting name from 'allowInfiniteAdlibsToPersist' to 'allowTestingAdlibsToPersist'

Author: Simon Rogers

meteor/server/api/rest/v1/typeConversion.ts

@@ -384,7 +384,7 @@ export function studioSettingsFrom(apiStudioSettings: APIStudioSettings): Comple
 		multiGatewayNowSafeLatency: apiStudioSettings.multiGatewayNowSafeLatency,
 		allowRundownResetOnAir: apiStudioSettings.allowRundownResetOnAir,
 		preserveOrphanedSegmentPositionInRundown: apiStudioSettings.preserveOrphanedSegmentPositionInRundown,
-		allowInfiniteAdlibToPersist: apiStudioSettings.allowInfiniteAdlibToPersist,
+		allowTestingAdlibsToPersist: apiStudioSettings.allowTestingAdlibsToPersist,
 		minimumTakeSpan: apiStudioSettings.minimumTakeSpan ?? DEFAULT_MINIMUM_TAKE_SPAN,
 		enableQuickLoop: apiStudioSettings.enableQuickLoop,
 		forceQuickLoopAutoNext: forceQuickLoopAutoNextFrom(apiStudioSettings.forceQuickLoopAutoNext),
@@ -417,7 +417,7 @@ export function APIStudioSettingsFrom(settings: IStudioSettings): Complete<APISt
 		fallbackPartDuration: settings.fallbackPartDuration,
 		enableUserEdits: settings.enableUserEdits,
 		allowAdlibTestingSegment: settings.allowAdlibTestingSegment,
-		allowInfiniteAdlibToPersist: settings.allowInfiniteAdlibToPersist,
+		allowTestingAdlibsToPersist: settings.allowTestingAdlibsToPersist,
 		allowHold: settings.allowHold,
 		allowPieceDirectPlay: settings.allowPieceDirectPlay,
 		enableBuckets: settings.enableBuckets,

meteor/server/lib/rest/v1/studios.ts

@@ -218,7 +218,7 @@ export interface APIStudioSettings {
 	fallbackPartDuration?: number
 	enableUserEdits?: boolean
 	allowAdlibTestingSegment?: boolean
-	allowInfiniteAdlibToPersist?: boolean
+	allowTestingAdlibsToPersist?: boolean
 	allowHold?: boolean
 	allowPieceDirectPlay?: boolean
 	enableBuckets?: boolean

packages/corelib/src/playout/infinites.ts

@@ -104,10 +104,10 @@ export function getPlayheadTrackingInfinitesForPart(
 	newInstanceId: PartInstanceId,
 	nextPartIsAfterCurrentPart: boolean,
 	isTemporary: boolean,
-	allowInfiniteAdlibToPersist: boolean
+	allowTestingAdlibsToPersist: boolean
 ): PieceInstance[] {
 	if (
-		!allowInfiniteAdlibToPersist &&
+		!allowTestingAdlibsToPersist &&
 		intoSegment._id !== playingSegment._id &&
 		(intoSegment.orphaned === SegmentOrphanedReason.ADLIB_TESTING ||
 			playingSegment.orphaned === SegmentOrphanedReason.ADLIB_TESTING)
@@ -214,7 +214,7 @@ export function getPlayheadTrackingInfinitesForPart(
 								(segmentsToReceiveOnRundownEndFromSet.has(currentPartInstance.segmentId) ||
 									currentPartInstance.segmentId === intoPart.segmentId ||
 									// If infinites are allowed to persist, then the infinite is allowed to continue
-									(allowInfiniteAdlibToPersist &&
+									(allowTestingAdlibsToPersist &&
 										intoSegment.orphaned === SegmentOrphanedReason.ADLIB_TESTING))
 							break
 						case PieceLifespan.OutOnShowStyleEnd:
@@ -386,7 +386,7 @@ export function getPieceInstancesForPart(
 	newInstanceId: PartInstanceId,
 	nextPartIsAfterCurrentPart: boolean,
 	isTemporary: boolean,
-	allowInfiniteAdlibToPersist: boolean
+	allowTestingAdlibsToPersist: boolean
 ): PieceInstance[] {
 	const doesPieceAStartBeforePieceB = (
 		pieceA: ReadonlyDeep<PieceInstancePiece>,
@@ -465,7 +465,7 @@ export function getPieceInstancesForPart(
 					newInstanceId,
 					nextPartIsAfterCurrentPart,
 					isTemporary,
-					allowInfiniteAdlibToPersist
+					allowTestingAdlibsToPersist
 				)
 			: []
 

packages/job-worker/src/playout/infinites.ts

@@ -279,7 +279,7 @@ export async function syncPlayheadInfinitesForNextPartInstance(
 			toPartInstance.partInstance._id,
 			nextPartIsAfterCurrentPart,
 			false,
-			context.studio.settings.allowInfiniteAdlibToPersist ?? false
+			context.studio.settings.allowTestingAdlibsToPersist ?? false
 		)
 
 		toPartInstance.replaceInfinitesFromPreviousPlayhead(infinites)
@@ -380,7 +380,7 @@ export function getPieceInstancesForPart(
 		newInstanceId,
 		nextPartIsAfterCurrentPart,
 		false,
-		context.studio.settings.allowInfiniteAdlibToPersist ?? false
+		context.studio.settings.allowTestingAdlibsToPersist ?? false
 	)
 	if (span) span.end()
 	return res

packages/openapi/api/definitions/studios.yaml

@@ -552,7 +552,7 @@ components:
         allowAdlibTestingSegment:
           type: boolean
           description: Whether to allow adlib testing mode, before a Part is playing in a Playlist
-        allowInfiniteAdlibToPersist:
+        allowTestingAdlibsToPersist:
           type: boolean
           description: Whether to allow infinite adlib from adlib testing mode to persist in the rundown
         allowHold:

packages/shared-lib/src/core/model/StudioSettings.ts

@@ -44,7 +44,7 @@ export interface IStudioSettings {
 	preserveOrphanedSegmentPositionInRundown?: boolean
 
 	/** Allow inifite adlibs from adlib testing mode to persist in the rundown */
-	allowInfiniteAdlibToPersist?: boolean
+	allowTestingAdlibsToPersist?: boolean
 
 	/**
 	 * The minimum amount of time, in milliseconds, that must pass after a take before another take may be performed.

packages/webui/src/client/lib/RundownResolver.ts

@@ -108,7 +108,7 @@ const SIMULATION_INVALIDATION = 3000
  * @param {boolean} nextPartIsAfterCurrentPart
  * @param {(PartInstance | undefined)} currentPartInstance
  * @param {(PieceInstance[] | undefined)} currentPartInstancePieceInstances
- * @param {boolean} allowInfiniteAdlibToPersist Studio config parameter to allow infinite adlibs from adlib testing to persist in the rundown
+ * @param {boolean} allowTestingAdlibsToPersist Studio config parameter to allow infinite adlibs from adlib testing to persist in the rundown
  * @param {FindOptions<PieceInstance>} [options]
  * @param {boolean} [pieceInstanceSimulation] If there are no PieceInstances in the PartInstance, create temporary
  * 		PieceInstances based on the Pieces collection and register a reactive dependancy to recalculate the current
@@ -129,7 +129,7 @@ export function getPieceInstancesForPartInstance(
 	currentPartInstance: PartInstance | undefined,
 	currentSegment: Pick<DBSegment, '_id' | 'orphaned'> | undefined,
 	currentPartInstancePieceInstances: PieceInstance[] | undefined,
-	allowInfiniteAdlibToPersist: boolean,
+	allowTestingAdlibsToPersist: boolean,
 	/** Map of Pieces on Parts, passed through for performance */
 	allPiecesCache?: Map<PartId, Piece[]>,
 	options?: FindOptions<PieceInstance>,
@@ -165,7 +165,7 @@ export function getPieceInstancesForPartInstance(
 			partInstance._id,
 			nextPartIsAfterCurrentPart,
 			partInstance.isTemporary,
-			allowInfiniteAdlibToPersist
+			allowTestingAdlibsToPersist
 		)
 	} else {
 		const results =
@@ -213,7 +213,7 @@ export function getPieceInstancesForPartInstance(
 				partInstance._id,
 				nextPartIsAfterCurrentPart,
 				true,
-				allowInfiniteAdlibToPersist
+				allowTestingAdlibsToPersist
 			)
 		} else {
 			// otherwise, return results as they are

packages/webui/src/client/lib/rundown.ts

@@ -497,7 +497,7 @@ export namespace RundownUtils {
 								pieceInstanceFieldOptions
 							).fetch()
 						: undefined,
-					studio?.settings.allowInfiniteAdlibToPersist ?? false,
+					studio?.settings.allowTestingAdlibsToPersist ?? false,
 					undefined,
 					pieceInstanceFieldOptions,
 					pieceInstanceSimulation

packages/webui/src/client/ui/Prompter/PrompterView.tsx

@@ -547,7 +547,7 @@ export class PrompterViewContent extends React.Component<Translated<IProps & ITr
 							<Prompter
 								rundownPlaylistId={this.props.rundownPlaylist._id}
 								config={this.configOptions}
-								allowInfiniteAdlibToPersist={this.props.studio?.settings.allowInfiniteAdlibToPersist ?? false}
+								allowTestingAdlibsToPersist={this.props.studio?.settings.allowTestingAdlibsToPersist ?? false}
 							>
 								{this.configOptions.showOverUnder && (
 									<OverUnderTimer rundownPlaylist={this.props.rundownPlaylist} style={overUnderStyle} />
@@ -637,7 +637,7 @@ export function PrompterView(props: Readonly<IProps>): JSX.Element {
 interface IPrompterProps {
 	rundownPlaylistId: RundownPlaylistId
 	config: PrompterConfig
-	allowInfiniteAdlibToPersist: boolean
+	allowTestingAdlibsToPersist: boolean
 }
 interface IPrompterTrackedProps {
 	prompterData: PrompterData | null
@@ -690,7 +690,7 @@ function Prompter(props: Readonly<PropsWithChildren<IPrompterProps>>): JSX.Eleme
 	)
 
 	const nextTrackedProps = useTracker(
-		() => PrompterAPI.getPrompterData(props.rundownPlaylistId, props.allowInfiniteAdlibToPersist),
+		() => PrompterAPI.getPrompterData(props.rundownPlaylistId, props.allowTestingAdlibsToPersist),
 		[props.rundownPlaylistId],
 		null
 	)

packages/webui/src/client/ui/Prompter/prompter.ts

@@ -63,7 +63,7 @@ export namespace PrompterAPI {
 	// TODO: discuss: move this implementation to server-side?
 	export function getPrompterData(
 		playlistId: RundownPlaylistId,
-		allowInfiniteAdlibToPersist: boolean
+		allowTestingAdlibsToPersist: boolean
 	): PrompterData | null {
 		if (typeof playlistId !== 'string') throw new Error('Expected `playlistId` to be a string')
 
@@ -235,7 +235,7 @@ export namespace PrompterAPI {
 					currentPartInstance,
 					currentSegment,
 					currentPartInstancePieceInstances,
-					allowInfiniteAdlibToPersist,
+					allowTestingAdlibsToPersist,
 					allPiecesCache,
 					pieceInstanceFieldOptions,
 					true