fix: sync at startup being lost

Author: Julusian

packages/mos-gateway/src/mosHandler.ts

@@ -309,24 +309,25 @@ export class MosHandler {
 
 			deviceEntry.coreMosHandler = coreMosHandler
 
-			if (deviceEntry.deviceOptions.statuses?.enabled) {
-				if (deviceEntry.statusHandler) {
-					deviceEntry.statusHandler.dispose()
-				}
-				deviceEntry.statusHandler = new MosStatusHandler(
-					this._logger,
-					mosDevice,
-					coreMosHandler,
-					deviceEntry.deviceOptions.statuses,
-					this.strict
-				)
-			}
-
 			// Initial Status check:
 			// Profile 0: -------------------------------------------------
 			mosDevice.onConnectionChange((newStatus: IMOSConnectionStatus) => {
 				//  MOSDevice >>>> Core
 				coreMosHandler.onMosConnectionChanged(newStatus)
+
+				// Setup the status handler upon first connection to the NRCS
+				const isConnected = newStatus.PrimaryConnected || newStatus.SecondaryConnected
+				if (deviceEntry.deviceOptions.statuses?.enabled && !deviceEntry.statusHandler && isConnected) {
+					// Creating the handler at this point avoids sending status messages before the connection is established,
+					// allowing for a sync at startup without needing manual queueing
+					deviceEntry.statusHandler = new MosStatusHandler(
+						this._logger,
+						mosDevice,
+						coreMosHandler,
+						deviceEntry.deviceOptions.statuses,
+						this.strict
+					)
+				}
 			})
 			coreMosHandler.onMosConnectionChanged(mosDevice.getConnectionStatus())
 			mosDevice.onRequestMachineInfo(async () => {

packages/mos-gateway/src/mosStatusHandler.ts

@@ -110,9 +110,11 @@ export class MosStatusHandler {
 					if (this.#isDeviceConnected()) {
 						// Send status
 						await this.#mosDevice.sendStoryStatus(newStatus)
+					} else if (this.#config.onlySendPlay) {
+						// No need to do anything.
+						this.#logger.info(`Not connected, skipping play status: ${JSON.stringify(newStatus)}`)
 					} else {
-						// nocommit
-						this.#logger.info(`Not connected`)
+						this.#logger.info(`Not connected, discarding status: ${JSON.stringify(newStatus)}`)
 					}
 				})
 				.catch((e) => {