wip: cleanup

Author: Julusian

meteor/.eslintrc.js

@@ -20,7 +20,7 @@ const tmpRules = {
 }
 
 const tsBase = {
-	extends: [...tsExtends, 'plugin:custom-rules/all'],
+	extends: [...tsExtends],
 	plugins: tsPlugins,
 	...tsParser,
 	settings: {

meteor/server/api/rest/koa.ts

@@ -62,14 +62,12 @@ Meteor.startup(() => {
 					route = route.slice(0, -1)
 				}
 
-				if (route && transaction) {
+				if (route) {
 					transaction.name = `${req.method}:${route}`
 					transaction.setLabel('route', `${route}`)
 				}
 
-				if (transaction) {
-					transaction.end()
-				}
+				transaction.end()
 			})
 		}
 

packages/blueprints-integration/src/migrations.ts

@@ -24,7 +24,10 @@ export interface MigrationStepInputFilteredResult {
 }
 
 export type ValidateFunctionCore = (afterMigration: boolean) => Promise<boolean | string>
-export type ValidateFunctionSystem = (context: MigrationContextSystem, afterMigration: boolean) => Promise<boolean | string>
+export type ValidateFunctionSystem = (
+	context: MigrationContextSystem,
+	afterMigration: boolean
+) => Promise<boolean | string>
 export type ValidateFunctionStudio = (context: MigrationContextStudio, afterMigration: boolean) => boolean | string
 export type ValidateFunctionShowStyle = (
 	context: MigrationContextShowStyle,
@@ -37,7 +40,10 @@ export type ValidateFunction =
 	| ValidateFunctionCore
 
 export type MigrateFunctionCore = (input: MigrationStepInputFilteredResult) => Promise<void>
-export type MigrateFunctionSystem = (context: MigrationContextSystem, input: MigrationStepInputFilteredResult) => Promise<void>
+export type MigrateFunctionSystem = (
+	context: MigrationContextSystem,
+	input: MigrationStepInputFilteredResult
+) => Promise<void>
 export type MigrateFunctionStudio = (context: MigrationContextStudio, input: MigrationStepInputFilteredResult) => void
 export type MigrateFunctionShowStyle = (
 	context: MigrationContextShowStyle,

packages/webui/src/client/lib/data/mos/__tests__/plugin-support.test.ts

@@ -42,13 +42,15 @@ describe('createMosAppInfoXmlString', () => {
 				let ncsAppInfo: any
 				beforeAll(async () => {
 					ncsAppInfo = mos.ncsAppInfo
+					// eslint-disable-next-line jest/no-standalone-expect
 					expect(ncsAppInfo).toHaveLength(1)
 					ncsAppInfo = ncsAppInfo[0]
 				})
 				describe('node ncsInformation', () => {
 					let ncsInformation: any
 					beforeAll(async () => {
 						ncsInformation = ncsAppInfo.ncsInformation
+						// eslint-disable-next-line jest/no-standalone-expect
 						expect(ncsInformation).toHaveLength(1)
 						ncsInformation = ncsInformation[0]
 					})