chore: fix lint / typings

Author: Mint de Wit

packages/corelib/src/lib.ts

@@ -8,6 +8,7 @@ import { iterateDeeply, iterateDeeplyEnum, Time } from '@sofie-automation/bluepr
 import { IStudioSettings } from './dataModel/Studio'
 import { customAlphabet as createNanoid } from 'nanoid'
 import type { ITranslatableMessage } from './TranslatableMessage'
+import { ReadonlyObjectDeep } from 'type-fest/source/readonly-deep'
 
 /**
  * Limited character set to use for id generation
@@ -63,6 +64,10 @@ export function clone<T>(o: ReadonlyDeep<T> | Readonly<T> | T): T {
 	// Use this instead of fast-clone directly, as this retains the type
 	return fastClone(o as any)
 }
+export function cloneObject<T extends object>(o: ReadonlyObjectDeep<T> | Readonly<T> | T): T {
+	// Use this instead of fast-clone directly, as this retains the type
+	return fastClone(o as any)
+}
 
 /**
  * Deeply freeze an object

packages/job-worker/src/blueprints/context/lib.ts

@@ -15,7 +15,7 @@ import {
 	CoreUserEditingDefinitionForm,
 } from '@sofie-automation/corelib/dist/dataModel/UserEditingDefinitions'
 import { DBSegment } from '@sofie-automation/corelib/dist/dataModel/Segment'
-import { assertNever, clone, Complete, literal, omit } from '@sofie-automation/corelib/dist/lib'
+import { assertNever, clone, cloneObject, Complete, literal, omit } from '@sofie-automation/corelib/dist/lib'
 import { unprotectString, unprotectStringArray } from '@sofie-automation/corelib/dist/protectedString'
 import { ReadonlyDeep } from 'type-fest'
 import {
@@ -215,7 +215,7 @@ function convertPieceGenericToBlueprintsInner(piece: ReadonlyDeep<PieceGeneric>)
 		expectedPackages: clone<ExpectedPackage.Any[] | undefined>(piece.expectedPackages),
 		hasSideEffects: piece.hasSideEffects,
 		content: {
-			...clone(piece.content),
+			...cloneObject(piece.content),
 			timelineObjects: deserializePieceTimelineObjectsBlob(piece.timelineObjectsString),
 		},
 		abSessions: clone<PieceAbSessionInfo[] | undefined>(piece.abSessions),

packages/job-worker/src/ingest/expectedMediaItems.ts

@@ -44,7 +44,7 @@ function generateExpectedMediaItems<T extends ExpectedMediaItemBase>(
 	commonProps: Subtract<T, ExpectedMediaItemBase>,
 	studioId: StudioId,
 	label: string,
-	content: Partial<SomeContent> | undefined,
+	content: Partial<SomeContent | ReadonlyDeep<SomeContent>> | undefined,
 	pieceType: string
 ): T[] {
 	const result: T[] = []

packages/webui/src/client/lib/ui/splitPreview.ts

@@ -4,6 +4,7 @@ import {
 	SplitsContentBoxProperties,
 } from '@sofie-automation/blueprints-integration'
 import { literal } from '../tempLib'
+import { ReadonlyDeep } from 'type-fest'
 
 const DEFAULT_POSITIONS = [
 	{
@@ -33,7 +34,9 @@ export interface SplitSubItem {
 }
 
 export function getSplitPreview(
-	boxSourceConfiguration: (SplitsContentBoxContent & SplitsContentBoxProperties)[]
+	boxSourceConfiguration:
+		| (SplitsContentBoxContent & SplitsContentBoxProperties)[]
+		| ReadonlyDeep<(SplitsContentBoxContent & SplitsContentBoxProperties)[]>
 ): ReadonlyArray<Readonly<SplitSubItem>> {
 	return boxSourceConfiguration.map((item, index) => {
 		return literal<Readonly<SplitSubItem>>({

packages/webui/src/client/ui/PreviewPopUp/PreviewPopUp.tsx

@@ -80,7 +80,7 @@ export const PreviewPopUp = React.forwardRef<
 					x,
 					anchor?.getBoundingClientRect().y ?? 0
 				)
-				if (update) update()
+				if (update) update().catch((e) => console.log(e))
 			}
 			document.addEventListener('mousemove', listener)
 

packages/webui/src/client/ui/PreviewPopUp/PreviewPopUpContent.tsx

@@ -48,8 +48,8 @@ export function PreviewPopUpContent({ content, time }: PreviewPopUpContentProps)
 				<div className="preview-popUp__table">
 					<table>
 						<tbody>
-							{content.content.map(({ key, value }) => (
-								<tr>
+							{content.content.map(({ key, value }, i) => (
+								<tr key={key + i}>
 									<td className="preview-popup__label">{key}</td>
 									<td className="preview-popup__value">{value}</td>
 								</tr>
@@ -92,7 +92,7 @@ export function PreviewPopUpContent({ content, time }: PreviewPopUpContentProps)
 function getDurationText(
 	t: TFunction,
 	lifespan: PieceLifespan,
-	timeAsRendered?: { in?: number; dur?: number },
+	timeAsRendered?: { in?: number | null; dur?: number | null },
 	enable?: ReadonlyObjectDeep<PieceInstancePiece>['enable']
 ): string {
 	if (!timeAsRendered?.dur && !enable?.duration) {

packages/webui/src/client/ui/PreviewPopUp/PreviewPopUpContext.tsx

@@ -151,7 +151,7 @@ export function convertSourceLayerItemToPreview(
 		]) as PreviewContent[]
 	} else if (sourceLayerType === SourceLayerType.GRAPHICS && 'previewPayload' in item.content) {
 		const payload = JSONBlobParse<NoraPayload>(item.content.previewPayload)
-		const tableProps = Object.entries(payload.content)
+		const tableProps = Object.entries<unknown>(payload.content)
 			.filter(([key, value]) => !(key.startsWith('_') || key.startsWith('@') || value === ''))
 			.map(([key, value]) => ({ key, value }))
 
@@ -412,7 +412,8 @@ export function PreviewPopUpContextProvider({ children }: React.PropsWithChildre
 					startCoordinate={previewSession.startCoordinate}
 					trackMouse={previewSession.trackMouse}
 				>
-					{previewContent && previewContent.map((content) => <PreviewPopUpContent time={t} content={content} />)}
+					{previewContent &&
+						previewContent.map((content, i) => <PreviewPopUpContent key={i} time={t} content={content} />)}
 				</PreviewPopUp>
 			)}
 		</PreviewPopUpContext.Provider>

packages/webui/src/client/ui/PreviewPopUp/Previews/BoxLayoutPreview.tsx

@@ -3,11 +3,12 @@ import classNames from 'classnames'
 import { useMemo } from 'react'
 import { RundownUtils } from '../../../lib/rundown'
 import { getSplitPreview, SplitRole } from '../../../lib/ui/splitPreview'
+import { ReadonlyDeep } from 'type-fest'
 
 interface BoxLayoutPreviewProps {
 	content: {
 		type: 'boxLayout'
-		boxSourceConfiguration: (SplitsContentBoxContent & SplitsContentBoxProperties)[]
+		boxSourceConfiguration: ReadonlyDeep<(SplitsContentBoxContent & SplitsContentBoxProperties)[]>
 		showLabels?: boolean
 		backgroundArt?: string
 	}