Skip to content

Commit a668b44

Browse files
committed
chore: replace meteor yarn with meteor npm run to fix issue with incompatibility of yarn and old meteor node.js version
Issue: [METEOR-TSC] C:\Users\user\AppData\Roaming\nvm\v18.20.4\node_modules\corepack\dist\yarn.js:2 [METEOR-TSC] process.env.COREPACK_ENABLE_DOWNLOAD_PROMPT??='1' [METEOR-TSC] ^^^ [METEOR-TSC] [METEOR-TSC] SyntaxError: Unexpected token '??='
1 parent 7a5dc15 commit a668b44

File tree

5 files changed

+17
-18
lines changed

5 files changed

+17
-18
lines changed

.github/workflows/audit.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
run: |
3030
yarn
3131
cd meteor
32-
meteor yarn validate:prod-dependencies
32+
meteor npm run validate:prod-dependencies
3333
env:
3434
CI: true
3535

@@ -57,7 +57,7 @@ jobs:
5757
run: |
5858
yarn
5959
cd meteor
60-
meteor yarn run validate:all-dependencies
60+
meteor npm run validate:all-dependencies
6161
env:
6262
CI: true
6363

.github/workflows/node.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
# setup zodern:types. No linters are setup, so this simply installs the packages
4747
meteor lint
4848
49-
meteor yarn ci:lint
49+
meteor npm run ci:lint
5050
env:
5151
CI: true
5252

@@ -85,7 +85,7 @@ jobs:
8585
# setup zodern:types. No linters are setup, so this simply installs the packages
8686
meteor lint
8787
88-
NODE_OPTIONS="--max-old-space-size=6144" meteor yarn unitci --force-exit
88+
NODE_OPTIONS="--max-old-space-size=6144" meteor npm run unitci --force-exit
8989
env:
9090
CI: true
9191
- name: Send coverage

meteor/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@
1010
"debug": "meteor run",
1111
"libs:syncVersions": "node scripts/libs-sync-version.js",
1212
"libs:syncVersionsAndChangelogs": "node scripts/libs-sync-version-and-changelog.js",
13-
"postinstall": "meteor yarn run prepareForTest",
13+
"postinstall": "meteor npm run prepareForTest",
1414
"prepareForTest": "node ../scripts/fixTestFibers.js",
1515
"inject-git-hash": "node ./scripts/generate-version-file.js",
1616
"unit": "jest",
1717
"unitci": "jest --maxWorkers 2 --coverage",
1818
"unitcov": "jest --coverage",
19-
"test": "meteor yarn check-types && meteor yarn unit",
19+
"test": "meteor npm run check-types && meteor npm run unit",
2020
"watch": "jest --watch",
2121
"update-snapshots": "jest --updateSnapshot",
22-
"ci:lint": "meteor yarn check-types && meteor yarn lint",
22+
"ci:lint": "meteor npm run check-types && meteor npm run lint",
2323
"cov-open": "open-cli coverage/lcov-report/index.html",
24-
"cov": "meteor yarn unitcov && meteor yarn cov-open",
24+
"cov": "meteor npm run unitcov && meteor npm run cov-open",
2525
"license-validate": "node ../scripts/checkLicenses.js --allowed=\"MIT,BSD,ISC,Apache,Unlicense,CC0,LGPL,CC BY 3.0,CC BY 4.0,MPL 2.0,Python 2.0\" --excludePackages=timecode,rxjs/ajax,rxjs/fetch,rxjs/internal-compatibility,nw-pre-gyp-module-test,rxjs/operators,rxjs/testing,rxjs/webSocket,undefined,i18next-conv,@fortawesome/fontawesome-common-types,argv,indexof,custom-license,private,public-domain-module,@sofie-automation/corelib,@sofie-automation/shared-lib,@sofie-automation/job-worker",
2626
"lint": "run lint:raw .",
2727
"lint:raw": "eslint --ext .ts --ext .js --ext .tsx --ext .jsx",

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
"unit:packages": "cd packages && run unit",
2121
"check-types:meteor": "cd meteor && run check-types",
2222
"test:meteor": "cd meteor && run test",
23-
"lint:meteor": "cd meteor && meteor yarn lint",
24-
"unit:meteor": "cd meteor && meteor yarn unit",
25-
"meteor:run": "cd meteor && meteor yarn start",
23+
"lint:meteor": "cd meteor && meteor npm run lint",
24+
"unit:meteor": "cd meteor && meteor npm run unit",
25+
"meteor:run": "cd meteor && meteor npm run start",
2626
"lint": "run lint:meteor && run lint:packages",
2727
"unit": "run unit:meteor && run unit:packages",
2828
"validate:release": "yarn install && run install-and-build && run validate:release:packages && run validate:release:meteor",
29-
"validate:release:meteor": "cd meteor && meteor yarn validate:prod-dependencies && meteor yarn license-validate && meteor yarn lint && meteor yarn test",
29+
"validate:release:meteor": "cd meteor && meteor npm run validate:prod-dependencies && meteor npm run license-validate && meteor npm run lint && meteor npm run test",
3030
"validate:release:packages": "cd packages && run validate:dependencies && run test",
3131
"meteor": "cd meteor && meteor",
3232
"docs:serve": "cd packages && run docs:serve",

scripts/run.mjs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ function watchPackages() {
77
{
88
command: config.uiOnly
99
? `yarn watch ${EXTRA_PACKAGES.map((pkg) => `--ignore ${pkg}`).join(
10-
" "
11-
)}`
10+
" "
11+
)}`
1212
: "yarn watch",
1313
cwd: "packages",
1414
name: "PACKAGES-TSC",
@@ -31,15 +31,14 @@ function watchWorker() {
3131
function watchMeteor() {
3232
return [
3333
{
34-
command: "meteor yarn watch-types --preserveWatchOutput",
34+
command: "meteor npm run watch-types --preserveWatchOutput",
3535
cwd: "meteor",
3636
name: "METEOR-TSC",
3737
prefixColor: "blue",
3838
},
3939
{
40-
command: `meteor yarn debug${config.inspectMeteor ? " --inspect" : ""}${
41-
config.verbose ? " --verbose" : ""
42-
}`,
40+
command: `meteor npm run debug${config.inspectMeteor ? " --inspect" : ""}${config.verbose ? " --verbose" : ""
41+
}`,
4342
cwd: "meteor",
4443
name: "METEOR",
4544
prefixColor: "cyan",

0 commit comments

Comments
 (0)