Skip to content

Commit a6a431c

Browse files
committed
feat: segment selection
1 parent 2169357 commit a6a431c

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

packages/webui/src/client/ui/SegmentTimeline/SegmentTimeline.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ interface IProps {
9292
onShowEntireSegment?: (event: React.MouseEvent | undefined) => void
9393
onContextMenu?: (contextMenuContext: IContextMenuContext) => void
9494
onItemClick?: (piece: PieceUi, e: React.MouseEvent<HTMLDivElement>) => void
95-
onItemDoubleClick?: (item: PieceUi, e: React.MouseEvent<HTMLDivElement>) => void
95+
onPieceDoubleClick?: (item: PieceUi, e: React.MouseEvent<HTMLDivElement>) => void
9696
onHeaderNoteClick?: (segmentId: SegmentId, level: NoteSeverity) => void
9797
onSwitchViewMode?: (newViewMode: SegmentViewMode) => void
9898
segmentRef?: (el: SegmentTimelineClass, segmentId: SegmentId) => void
@@ -790,7 +790,7 @@ export class SegmentTimelineClass extends React.Component<Translated<WithTiming<
790790
onFollowLiveLine={this.props.onFollowLiveLine}
791791
onContextMenu={this.props.onContextMenu}
792792
onPieceClick={this.props.onItemClick}
793-
onPieceDoubleClick={this.props.onItemDoubleClick}
793+
onPieceDoubleClick={this.props.onPieceDoubleClick}
794794
onPartTooSmallChanged={this.onPartTooSmallChanged}
795795
scrollWidth={this.state.timelineWidth / this.props.timeScale}
796796
firstPartInSegment={firstPartInSegment}
@@ -867,7 +867,7 @@ export class SegmentTimelineClass extends React.Component<Translated<WithTiming<
867867
onFollowLiveLine={this.props.onFollowLiveLine}
868868
onContextMenu={this.props.onContextMenu}
869869
onPieceClick={this.props.onItemClick}
870-
onPieceDoubleClick={this.props.onItemDoubleClick}
870+
onPieceDoubleClick={this.props.onPieceDoubleClick}
871871
scrollWidth={this.state.timelineWidth / this.props.timeScale}
872872
firstPartInSegment={firstPartInSegment}
873873
lastPartInSegment={this.props.parts[this.props.parts.length - 1]}
@@ -1068,12 +1068,9 @@ export class SegmentTimelineClass extends React.Component<Translated<WithTiming<
10681068
(this.state.isSelected ? ' selected' : '')
10691069
}
10701070
data-identifier={this.props.segment.identifier}
1071-
onClick={(e: React.MouseEvent) => {
1072-
// If Alt/Option key is pressed
1073-
if (e.altKey) {
1074-
if (this.props.onSegmentSelect) {
1075-
this.props.onSegmentSelect(this.props.segment._id)
1076-
}
1071+
onDoubleClick={() => {
1072+
if (this.props.studio.settings.enableUserEdits && this.props.onSegmentSelect) {
1073+
this.props.onSegmentSelect(this.props.segment._id)
10771074
}
10781075
}}
10791076
>

packages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,7 @@ const SegmentTimelineContainerContent = withResolvedSegment(
702702
onRecalculateMaxTimeScale={this.updateMaxTimeScale}
703703
showingAllSegment={this.state.showingAllSegment}
704704
onItemClick={this.props.onPieceClick}
705-
onItemDoubleClick={this.props.onPieceDoubleClick}
705+
onPieceDoubleClick={this.props.onPieceDoubleClick}
706706
onCollapseOutputToggle={this.onCollapseOutputToggle}
707707
collapsedOutputs={this.state.collapsedOutputs}
708708
scrollLeft={this.state.scrollLeft}

packages/webui/src/client/ui/SegmentTimeline/SourceLayerItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ const SourceLayerItemWithSelection = withTranslation()(
729729
}
730730
)
731731

732-
export const SourceLayerItem = (props: ISourceLayerItemProps & WithTranslation): React.ReactElement => {
732+
export const SourceLayerItem = (props: ISourceLayerItemProps): React.ReactElement => {
733733
const { isSelected, clearAndSetSelection } = useSelection()
734734

735735
const isPieceSelected = isSelected(props.piece.instance._id)

0 commit comments

Comments
 (0)