feat: option to disable HOLD

Author: Julusian

packages/corelib/src/dataModel/Studio.ts

@@ -88,6 +88,13 @@ export interface IStudioSettings {
 	 * Default: 3000
 	 */
 	fallbackPartDuration?: number
+
+	/**
+	 * Whether to allow hold operations for Rundowns in this Studio
+	 * When disabled, any action-triggers that would normally trigger a hold operation will be silently ignored
+	 * This should only block entering hold, to ensure Sofie doesn't get stuck if it somehow gets into hold
+	 */
+	allowHold?: boolean
 }
 
 export type StudioLight = Omit<DBStudio, 'mappingsWithOverrides' | 'blueprintConfigWithOverrides'>

packages/job-worker/src/playout/holdJobs.ts

@@ -5,11 +5,18 @@ import { ActivateHoldProps, DeactivateHoldProps } from '@sofie-automation/coreli
 import { JobContext } from '../jobs'
 import { runJobWithPlayoutModel } from './lock'
 import { updateTimeline } from './timeline/generate'
+import { logger } from '../logging'
 
 /**
  * Activate Hold
  */
 export async function handleActivateHold(context: JobContext, data: ActivateHoldProps): Promise<void> {
+	if (!context.studio.settings.allowHold) {
+		// Hold isn't allowed, making this a noop
+		logger.debug(`Hold isn't allowed, skipping`)
+		return
+	}
+
 	return runJobWithPlayoutModel(
 		context,
 		data,
@@ -59,6 +66,8 @@ export async function handleActivateHold(context: JobContext, data: ActivateHold
  * Deactivate Hold
  */
 export async function handleDeactivateHold(context: JobContext, data: DeactivateHoldProps): Promise<void> {
+	// This should be possible even when hold is not allowed, as it is a way to get out of a stuck state
+
 	return runJobWithPlayoutModel(
 		context,
 		data,

packages/webui/src/client/ui/RundownView.tsx

@@ -1050,7 +1050,7 @@ const RundownHeader = withTranslation()(
 									{this.props.playlist.activationId ? (
 										<MenuItem onClick={(e) => this.take(e)}>{t('Take')}</MenuItem>
 									) : null}
-									{this.props.playlist.activationId ? (
+									{this.props.studio.settings.allowHold && this.props.playlist.activationId ? (
 										<MenuItem onClick={(e) => this.hold(e)}>{t('Hold')}</MenuItem>
 									) : null}
 									{this.props.playlist.activationId && canClearQuickLoop ? (

packages/webui/src/client/ui/Settings/Studio/Generic.tsx

@@ -296,6 +296,20 @@ export const StudioGenericProperties = withTranslation()(
 						</div>
 					</label>
 
+					<label className="field">
+						<LabelActual label={t('Allow HOLD mode')} />
+						<EditAttribute
+							modifiedClassName="bghl"
+							attribute="settings.allowHold"
+							obj={this.props.studio}
+							type="checkbox"
+							collection={Studios}
+						/>
+						<span className="text-s dimmed field-hint">
+							{t('When disabled, any HOLD operations will be silently ignored')}
+						</span>
+					</label>
+
 					<StudioBaselineStatus studioId={this.props.studio._id} />
 				</div>
 			)