Skip to content

Commit ba03df0

Browse files
committed
feat: move Properties panel out of notification center logic
1 parent 07bd3ec commit ba03df0

File tree

6 files changed

+240
-185
lines changed

6 files changed

+240
-185
lines changed

packages/webui/src/client/lib/notifications/NotificationCenterPanel.tsx

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import update from 'immutability-helper'
1212
import { i18nTranslator } from '../../ui/i18n'
1313
import { RundownId, SegmentId } from '@sofie-automation/corelib/dist/dataModel/Ids'
1414
import { useTranslation } from 'react-i18next'
15-
import { PropertiesPanel } from '../../ui/UserEditOperations/PropertiesPanel'
16-
import { UserEditsIcon } from '../ui/icons/useredits'
1715

1816
interface IPopUpProps {
1917
id?: string
@@ -392,12 +390,7 @@ export const NotificationCenterPopUps = translateWithTracker<IProps, IState, ITr
392390
}
393391

394392
render(): JSX.Element | null {
395-
const { t, highlightedSource, highlightedLevel, filter } = this.props
396-
397-
// For PropertiesPanel ignore the filter:
398-
if (Number(filter) >= NoticeLevel.PROPERTIES_PANEL) {
399-
return <PropertiesPanel />
400-
}
393+
const { t, highlightedSource, highlightedLevel } = this.props
401394

402395
const notifications = this.getNotificationsToDisplay()
403396

@@ -547,8 +540,6 @@ export function NotificationCenterPanelToggle({
547540
<WarningIcon />
548541
) : ((filter || 0) & (NoticeLevel.NOTIFICATION | NoticeLevel.TIP)) !== 0 ? (
549542
<InformationIcon />
550-
) : ((filter || 0) & NoticeLevel.PROPERTIES_PANEL) !== 0 ? (
551-
<UserEditsIcon />
552543
) : (
553544
<WarningIcon />
554545
)}

packages/webui/src/client/lib/notifications/notifications.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ export enum NoticeLevel {
4747
NOTIFICATION = 0b0100, // 4
4848
/** Tips to the user */
4949
TIP = 0b1000, // 8
50-
/** User editing */
51-
PROPERTIES_PANEL = 0b100000000, // 256
5250
}
5351

5452
/**

0 commit comments

Comments
 (0)