Skip to content

Commit bdce747

Browse files
committed
chore: review comments
1 parent 60a73ac commit bdce747

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

packages/blueprints-integration/src/api/system.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,13 @@ export interface SystemBlueprintManifest extends BlueprintManifestBase {
88
blueprintType: BlueprintManifestType.SYSTEM
99

1010
/** A list of Migration steps related to the Core system
11-
* @deprecated This has been replaced with `validateConfig` and `applyConfig`
11+
* @deprecated This has been replaced with `applyConfig`
1212
*/
1313
coreMigrations: MigrationStepSystem[]
1414

1515
/** Translations connected to the studio (as stringified JSON) */
1616
translations?: string
1717

18-
// /**
19-
// * Apply automatic upgrades to the structure of user specified config overrides
20-
// * This lets you apply various changes to the user's values in an abstract way
21-
// */
22-
// fixUpConfig?: (context: IFixUpConfigContext<TRawConfig>) => void
23-
24-
// /**
25-
// * Validate the config passed to this blueprint
26-
// * In this you should do various sanity checks of the config and return a list of messages to display to the user.
27-
// * These messages do not stop `applyConfig` from being called.
28-
// */
29-
// validateConfig?: (context: ICommonContext, config: TRawConfig) => Array<IConfigMessage>
30-
3118
/**
3219
* Apply the config by generating the data to be saved into the db.
3320
* This should be written to give a predictable and stable result, it can be called with the same config multiple times

packages/webui/src/client/ui/Settings/Studio/Generic.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ function StudioSettings({ studio }: { studio: DBStudio }): JSX.Element {
150150

151151
const saveOverrides = React.useCallback(
152152
(newOps: SomeObjectOverrideOp[]) => {
153-
console.log('save', newOps)
154153
Studios.update(studio._id, {
155154
$set: {
156155
'settingsWithOverrides.overrides': newOps.map((op) => ({

packages/webui/src/client/ui/Settings/SystemManagement.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,6 @@ function SystemManagementHeapSnapshot() {
597597
function useCoreSystemSettingsWithOverrides(coreSystem: ICoreSystem) {
598598
const saveOverrides = useCallback(
599599
(newOps: SomeObjectOverrideOp[]) => {
600-
console.log('save', newOps)
601600
CoreSystem.update(coreSystem._id, {
602601
$set: {
603602
'settingsWithOverrides.overrides': newOps.map((op) => ({

0 commit comments

Comments
 (0)