chore: refactor out util

Author: Julusian

packages/webui/src/client/ui/SegmentTimeline/SegmentContextMenu.tsx

@@ -17,6 +17,7 @@ import { CoreUserEditingDefinition } from '@sofie-automation/corelib/dist/dataMo
 import * as RundownResolver from '../../lib/RundownResolver.js'
 import { SelectedElement } from '../RundownView/SelectedElementsContext.js'
 import { DBPartInstance } from '@sofie-automation/corelib/dist/dataModel/PartInstance.js'
+import { hasUserEditableContent } from '../UserEditOperations/PropertiesPanel.js'
 
 interface IProps {
 	onSetNext: (partInstance: DBPartInstance | DBPart | undefined, e: any, offset?: number, take?: boolean) => void
@@ -120,24 +121,9 @@ export function SegmentContextMenu({
 		part?.instance._id !== playlist.nextPartInfo?.partInstanceId &&
 		part?.instance._id !== playlist.previousPartInfo?.partInstanceId
 
-	const segmentHasEditableContent = !!(
-		segment?.userEditOperations?.length ||
-		segment?.userEditProperties?.pieceTypeProperties ||
-		segment?.userEditProperties?.globalProperties ||
-		segment?.userEditProperties?.operations?.length
-	)
-	const partHasEditableContent = !!(
-		part?.instance.part.userEditOperations?.length ||
-		part?.instance.part.userEditProperties?.pieceTypeProperties ||
-		part?.instance.part.userEditProperties?.globalProperties ||
-		part?.instance.part.userEditProperties?.operations?.length
-	)
-	const pieceHasEditableContent = !!(
-		piece?.instance.piece.userEditOperations?.length ||
-		piece?.instance.piece.userEditProperties?.pieceTypeProperties ||
-		piece?.instance.piece.userEditProperties?.globalProperties ||
-		piece?.instance.piece.userEditProperties?.operations?.length
-	)
+	const segmentHasEditableContent = hasUserEditableContent(segment)
+	const partHasEditableContent = hasUserEditableContent(part?.instance.part)
+	const pieceHasEditableContent = hasUserEditableContent(piece?.instance.piece)
 
 	const isPartOrphaned: boolean | undefined = part ? part.instance.orphaned !== undefined : undefined
 
@@ -318,7 +304,7 @@ export function SegmentContextMenu({
 											<span>{t('Edit Part Properties')}</span>
 										</MenuItem>
 									)}
-									{pieceHasEditableContent && (
+									{pieceHasEditableContent && piece && (
 										<MenuItem onClick={() => onEditProps({ type: 'piece', elementId: piece.instance.piece._id })}>
 											<span>{t('Edit Piece Properties')}</span>
 										</MenuItem>

packages/webui/src/client/ui/SegmentTimeline/SegmentTimeline.tsx

@@ -58,6 +58,7 @@ import * as RundownResolver from '../../lib/RundownResolver.js'
 import { DBSegment } from '@sofie-automation/corelib/dist/dataModel/Segment'
 import { SelectedElementsContext } from '../RundownView/SelectedElementsContext.js'
 import { BlueprintAssetIcon } from '../../lib/Components/BlueprintAssetIcon.js'
+import { hasUserEditableContent } from '../UserEditOperations/PropertiesPanel.js'
 
 interface IProps {
 	id: string
@@ -1017,12 +1018,7 @@ export class SegmentTimelineClass extends React.Component<Translated<WithTiming<
 									if (this.props.studio.settings.enableUserEdits) {
 										const segment = this.props.segment
 
-										const hasEditableContent = !!(
-											segment.userEditOperations?.length ||
-											segment.userEditProperties?.pieceTypeProperties ||
-											segment.userEditProperties?.globalProperties ||
-											segment.userEditProperties?.operations?.length
-										)
+										const hasEditableContent = hasUserEditableContent(segment)
 										if (!hasEditableContent) return
 
 										if (!selectElementContext.isSelected(segment._id)) {

packages/webui/src/client/ui/SegmentTimeline/SourceLayerItem.tsx

@@ -36,6 +36,7 @@ import {
 	PreviewPopUpContext,
 } from '../PreviewPopUp/PreviewPopUpContext.js'
 import { useRundownViewEventBusListener } from '../../lib/lib.js'
+import { hasUserEditableContent } from '../UserEditOperations/PropertiesPanel.js'
 const LEFT_RIGHT_ANCHOR_SPACER = 15
 const MARGINAL_ANCHORED_WIDTH = 5
 
@@ -185,12 +186,7 @@ export const SourceLayerItem = (props: Readonly<ISourceLayerItemProps>): JSX.Ele
 			if (studio?.settings.enableUserEdits && !studio?.settings.allowPieceDirectPlay) {
 				const innerPiece = piece.instance.piece
 
-				const hasEditableContent = !!(
-					innerPiece.userEditOperations?.length ||
-					innerPiece.userEditProperties?.pieceTypeProperties ||
-					innerPiece.userEditProperties?.globalProperties ||
-					innerPiece.userEditProperties?.operations?.length
-				)
+				const hasEditableContent = hasUserEditableContent(innerPiece)
 				if (!hasEditableContent) return
 
 				const pieceId = innerPiece._id

packages/webui/src/client/ui/UserEditOperations/PropertiesPanel.tsx

@@ -22,6 +22,11 @@ import { useCallback, useEffect, useMemo, useState } from 'react'
 import { SchemaFormWithState } from '../../lib/forms/SchemaFormWithState.js'
 import { translateMessage } from '@sofie-automation/corelib/dist/TranslatableMessage'
 import { BlueprintAssetIcon } from '../../lib/Components/BlueprintAssetIcon.js'
+import { ReadonlyDeep } from 'type-fest'
+import {
+	CoreUserEditingDefinition,
+	CoreUserEditingProperties,
+} from '@sofie-automation/corelib/src/dataModel/UserEditingDefinitions.js'
 
 type PendingChange = DefaultUserOperationEditProperties['payload']
 
@@ -385,3 +390,19 @@ function ActionList({
 		</div>
 	)
 }
+
+export function hasUserEditableContent(
+	obj:
+		| ReadonlyDeep<{
+				userEditOperations?: CoreUserEditingDefinition[]
+				userEditProperties?: CoreUserEditingProperties
+		  }>
+		| undefined
+): boolean {
+	return !!(
+		obj?.userEditOperations?.length ||
+		obj?.userEditProperties?.pieceTypeProperties ||
+		obj?.userEditProperties?.globalProperties ||
+		obj?.userEditProperties?.operations?.length
+	)
+}