wip: unhandled promises

Author: Julusian

meteor/server/api/ExternalMessageQueue.ts

@@ -1,7 +1,7 @@
 import { Meteor } from 'meteor/meteor'
 import { check } from '../lib/check'
 import { StatusCode } from '@sofie-automation/blueprints-integration'
-import { deferAsync, getCurrentTime } from '../lib/lib'
+import { deferAsync, getCurrentTime, MeteorStartupAsync } from '../lib/lib'
 import { registerClassToMeteorMethods } from '../methods'
 import {
 	NewExternalMessageQueueAPI,
@@ -50,18 +50,19 @@ function updateExternalMessageQueueStatus(): void {
 	}
 }
 
-ExternalMessageQueue.observeChanges(
-	{
-		sent: { $not: { $gt: 0 } },
-		tryCount: { $gt: 3 },
-	},
-	{
-		added: updateExternalMessageQueueStatus,
-		changed: updateExternalMessageQueueStatus,
-		removed: updateExternalMessageQueueStatus,
-	}
-)
-Meteor.startup(() => {
+MeteorStartupAsync(async () => {
+	await ExternalMessageQueue.observeChanges(
+		{
+			sent: { $not: { $gt: 0 } },
+			tryCount: { $gt: 3 },
+		},
+		{
+			added: updateExternalMessageQueueStatus,
+			changed: updateExternalMessageQueueStatus,
+			removed: updateExternalMessageQueueStatus,
+		}
+	)
+
 	updateExternalMessageQueueStatus()
 	// triggerdoMessageQueue(5000)
 })

meteor/server/api/deviceTriggers/observer.ts

@@ -18,14 +18,14 @@ import { StudioObserver } from './StudioObserver'
 import { Studios } from '../../collections'
 import { ReactiveCacheCollection } from '../../publications/lib/ReactiveCacheCollection'
 import { stringifyError } from '@sofie-automation/shared-lib/dist/lib/stringifyError'
+import { MeteorStartupAsync } from '../../lib/lib'
 
 type ObserverAndManager = {
 	observer: StudioObserver
 	manager: StudioDeviceTriggerManager
 }
 
-Meteor.startup(() => {
-	if (!Meteor.isServer) return
+MeteorStartupAsync(async () => {
 	const studioObserversAndManagers = new Map<StudioId, ObserverAndManager>()
 	const jobQueue = new JobQueueWithClasses({
 		autoStart: true,
@@ -69,7 +69,7 @@ Meteor.startup(() => {
 		}
 	}
 
-	Studios.observeChanges(
+	await Studios.observeChanges(
 		{},
 		{
 			added: (studioId) => {

meteor/server/api/ingest/rundownInput.ts

@@ -3,7 +3,7 @@ import { check } from '../../lib/check'
 import { PeripheralDevice } from '@sofie-automation/corelib/dist/dataModel/PeripheralDevice'
 import { NrcsIngestDataCache, MediaObjects, Parts, Rundowns, Segments } from '../../collections'
 import { literal } from '../../lib/tempLib'
-import { lazyIgnore } from '../../lib/lib'
+import { lazyIgnore, MeteorStartupAsync } from '../../lib/lib'
 import { IngestRundown, IngestSegment, IngestPart, IngestPlaylist } from '@sofie-automation/blueprints-integration'
 import { logger } from '../../logging'
 import { RundownIngestDataCache } from './ingestCache'
@@ -363,17 +363,15 @@ async function listIngestRundowns(peripheralDevice: PeripheralDevice): Promise<s
 }
 
 // hackGetMediaObjectDuration stuff
-Meteor.startup(() => {
-	if (Meteor.isServer) {
-		MediaObjects.observe(
-			{},
-			{
-				added: onMediaObjectChanged,
-				changed: onMediaObjectChanged,
-			},
-			{ fields: { _id: 1, mediaId: 1, mediainfo: 1, studioId: 1 } }
-		)
-	}
+MeteorStartupAsync(async () => {
+	await MediaObjects.observe(
+		{},
+		{
+			added: onMediaObjectChanged,
+			changed: onMediaObjectChanged,
+		},
+		{ fields: { _id: 1, mediaId: 1, mediainfo: 1, studioId: 1 } }
+	)
 })
 
 interface MediaObjectUpdatedIds {

meteor/server/api/studio/api.ts

@@ -4,7 +4,7 @@ import { registerClassToMeteorMethods } from '../../methods'
 import { NewStudiosAPI, StudiosAPIMethods } from '@sofie-automation/meteor-lib/dist/api/studios'
 import { DBStudio } from '@sofie-automation/corelib/dist/dataModel/Studio'
 import { literal, getRandomId } from '../../lib/tempLib'
-import { lazyIgnore } from '../../lib/lib'
+import { lazyIgnore, MeteorStartupAsync } from '../../lib/lib'
 import { stringifyError } from '@sofie-automation/shared-lib/dist/lib/stringifyError'
 import {
 	ExpectedPackages,
@@ -133,17 +133,20 @@ function triggerUpdateStudioMappingsHash(studioId: StudioId) {
 		10
 	)
 }
-Studios.observeChanges(
-	{},
-	{
-		added: triggerUpdateStudioMappingsHash,
-		changed: triggerUpdateStudioMappingsHash,
-		removed: triggerUpdateStudioMappingsHash,
-	},
-	{
-		fields: {
-			mappingsWithOverrides: 1,
-			routeSetsWithOverrides: 1,
+
+MeteorStartupAsync(async () => {
+	await Studios.observeChanges(
+		{},
+		{
+			added: triggerUpdateStudioMappingsHash,
+			changed: triggerUpdateStudioMappingsHash,
+			removed: triggerUpdateStudioMappingsHash,
 		},
-	}
-)
+		{
+			fields: {
+				mappingsWithOverrides: 1,
+				routeSetsWithOverrides: 1,
+			},
+		}
+	)
+})

meteor/server/collections/lib.ts

@@ -60,7 +60,7 @@ export async function ObserveChangesHelper<DBInterface extends { _id: ProtectedS
 		projection[field] = 1
 	}
 
-	collection.observeChanges(
+	await collection.observeChanges(
 		{},
 		{
 			changed: (id: DBInterface['_id'], changedFields) => {

meteor/server/coreSystem/index.ts

@@ -78,7 +78,7 @@ async function initializeCoreSystem() {
 	}
 
 	// Monitor database changes:
-	CoreSystem.observeChanges(SYSTEM_ID, {
+	await CoreSystem.observeChanges(SYSTEM_ID, {
 		added: onCoreSystemChanged,
 		changed: onCoreSystemChanged,
 		removed: onCoreSystemChanged,
@@ -88,7 +88,7 @@ async function initializeCoreSystem() {
 		checkDatabaseVersions()
 	}
 
-	Blueprints.observeChanges(
+	await Blueprints.observeChanges(
 		{},
 		{
 			added: observeBlueprintChanges,