fix: removing parts/segments with quickloop markers

Author: Mint de Wit

packages/job-worker/src/ingest/commit.ts

@@ -221,6 +221,9 @@ export async function CommitIngestOperation(
 				// sync changes to the 'selected' partInstances
 				await syncChangesToPartInstances(context, playoutModel, ingestModel)
 
+				// update the quickloop in case we did any changes to things involving marker
+				playoutModel.updateQuickLoopState()
+
 				playoutModel.deferAfterSave(() => {
 					// Run in the background, we don't want to hold onto the lock to do this
 					context

packages/job-worker/src/playout/model/services/QuickLoopService.ts

@@ -65,6 +65,10 @@ export class QuickLoopService {
 
 		this.resetDynamicallyInsertedPartOverrideIfNoLongerNeeded(quickLoopProps)
 
+		// remove the marker if it no longer exists inside the rundown
+		if (quickLoopProps.start && !this.doesMarkerExist(quickLoopProps.start)) delete quickLoopProps.start
+		if (quickLoopProps.end && !this.doesMarkerExist(quickLoopProps.end)) delete quickLoopProps.end
+
 		if (quickLoopProps.start == null || quickLoopProps.end == null) {
 			quickLoopProps.running = false
 		} else {
@@ -177,6 +181,27 @@ export class QuickLoopService {
 		}
 	}
 
+	/**
+	 * Check whether the thing a marker references still exists within the playlist
+	 * @param marker Marker to find
+	 */
+	private doesMarkerExist(marker: QuickLoopMarker) {
+		let found = false
+
+		if (marker.type === QuickLoopMarkerType.PART) {
+			found = !!this.playoutModel.findPart(marker.id)
+		} else if (marker.type === QuickLoopMarkerType.SEGMENT) {
+			found = !!this.playoutModel.findSegment(marker.id)
+		} else if (marker.type === QuickLoopMarkerType.RUNDOWN) {
+			found = !!this.playoutModel.getRundown(marker.id)
+		} else {
+			// we can't lose the playlist so that marker is always valid
+			found = true
+		}
+
+		return found
+	}
+
 	private findPartPosition(
 		partInstance: PlayoutPartInstanceModel | null,
 		rundownIds: RundownId[]