Skip to content

Commit fb14b37

Browse files
committed
wip
1 parent d1564f0 commit fb14b37

File tree

4 files changed

+18
-11
lines changed

4 files changed

+18
-11
lines changed

meteor/server/publications/pieceContentStatusUI/checkPieceContentStatus.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -341,13 +341,15 @@ async function checkPieceContentMediaObjectStatus(
341341
sourceLayer: sourceLayer.name,
342342
pieceName: piece.name,
343343
fileName: '',
344+
containerLabel: '',
344345
}),
345346
})
346347
} else {
347348
const messageRequiredArgs: PieceContentStatusMessageRequiredArgs = {
348349
sourceLayer: sourceLayer.name,
349350
pieceName: piece.name,
350351
fileName: fileName,
352+
containerLabel: '',
351353
}
352354
const mediaObject = await getMediaObject(fileName)
353355
// If media object not found, then...
@@ -464,6 +466,7 @@ async function checkPieceContentMediaObjectStatus(
464466
sourceLayer: sourceLayer.name,
465467
pieceName: piece.name,
466468
fileName: fileName,
469+
containerLabel: '',
467470
}),
468471
})
469472
} else {
@@ -574,27 +577,27 @@ async function checkPieceContentExpectedPackageStatus(
574577
const checkedPackageContainers = new Set<string>()
575578

576579
for (const routedDeviceId of routedDeviceIds) {
577-
let packageContainerId: string | undefined
578-
for (const [containerId, packageContainer] of Object.entries<ReadonlyDeep<StudioPackageContainer>>(
580+
let matchedPackageContainer: [string, ReadonlyDeep<StudioPackageContainer>] | undefined
581+
for (const packageContainer of Object.entries<ReadonlyDeep<StudioPackageContainer>>(
579582
studio.packageContainers
580583
)) {
581-
if (packageContainer.deviceIds.includes(unprotectString(routedDeviceId))) {
584+
if (packageContainer[1].deviceIds.includes(unprotectString(routedDeviceId))) {
582585
// TODO: how to handle if a device has multiple containers?
583-
packageContainerId = containerId
586+
matchedPackageContainer = packageContainer
584587
break // just picking the first one found, for now
585588
}
586589
}
587590

588-
if (!packageContainerId) {
591+
if (!matchedPackageContainer) {
589592
continue
590593
}
591594

592-
if (checkedPackageContainers.has(packageContainerId)) {
595+
if (checkedPackageContainers.has(matchedPackageContainer[0])) {
593596
// we have already checked this package container for this expected package
594597
continue
595598
}
596599

597-
checkedPackageContainers.add(packageContainerId)
600+
checkedPackageContainers.add(matchedPackageContainer[0])
598601

599602
const expectedPackageIds = [getExpectedPackageId(piece._id, expectedPackage._id)]
600603
if (piece.pieceInstanceId) {
@@ -606,13 +609,14 @@ async function checkPieceContentExpectedPackageStatus(
606609
sourceLayer: sourceLayer.name,
607610
pieceName: piece.name,
608611
fileName: getExpectedPackageFileName(expectedPackage) ?? '',
612+
containerLabel: matchedPackageContainer[1].container.label,
609613
}
610614

611615
let warningMessage: ContentMessage | null = null
612616
let matchedExpectedPackageId: ExpectedPackageId | null = null
613617
for (const expectedPackageId of expectedPackageIds) {
614618
const packageOnPackageContainer = await getPackageContainerPackageStatus(
615-
packageContainerId,
619+
matchedPackageContainer[0],
616620
expectedPackageId
617621
)
618622
if (!packageOnPackageContainer) continue

meteor/server/publications/pieceContentStatusUI/messageFactory.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export interface PieceContentStatusMessageRequiredArgs {
7777
sourceLayer: string
7878
pieceName: string
7979
fileName: string
80+
containerLabel: string
8081
}
8182

8283
export type BlueprintForStatusMessage = Pick<Blueprint, '_id' | 'packageStatusMessages'>

packages/blueprints-integration/src/api/showStyle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export interface ShowStyleBlueprintManifest<TRawConfig = IBlueprintConfig, TProc
6464
configPresets: Record<string, IShowStyleConfigPreset<TRawConfig>>
6565

6666
/** Alternate package status messages, to override the builtin ones produced by Sofie */
67-
packageStatusMessages?: Record<PackageStatusMessage, string | undefined>
67+
packageStatusMessages?: Partial<Record<PackageStatusMessage, string>>
6868

6969
/** Translations connected to the studio (as stringified JSON) */
7070
translations?: string

packages/webui/src/client/lib/dev.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@ import { logger } from './logging'
1111
const windowAny: any = window
1212

1313
Meteor.startup(() => {
14-
windowAny['Collections'] = Object.fromEntries(ClientCollections.entries())
15-
windowAny['PublicationCollections'] = Object.fromEntries(PublicationCollections.entries())
14+
setTimeout(() => {
15+
windowAny['Collections'] = Object.fromEntries(ClientCollections.entries())
16+
windowAny['PublicationCollections'] = Object.fromEntries(PublicationCollections.entries())
17+
}, 1000)
1618
})
1719

1820
windowAny['getCurrentTime'] = getCurrentTime

0 commit comments

Comments
 (0)