Merge pull request Sofie-Automation#1486 from bbc/upstream/fix/findMarkerPosition-always-needs-all-parts-available

Author: jstarpl

meteor/server/publications/lib/quickLoop.ts

@@ -124,16 +124,15 @@ export function findMarkerPosition(
 	marker: QuickLoopMarker,
 	fallback: number,
 	segmentCache: ReadonlyObjectDeep<ReactiveCacheCollection<Pick<DBSegment, '_id' | '_rank' | 'rundownId'>>>,
-	partCache:
-		| { parts: ReadonlyObjectDeep<ReactiveCacheCollection<Pick<DBPart, '_id' | '_rank' | 'segmentId'>>> }
-		| { partInstances: ReadonlyObjectDeep<ReactiveCacheCollection<DBPartInstance>> },
+	partCache: {
+		parts?: ReadonlyObjectDeep<ReactiveCacheCollection<Pick<DBPart, '_id' | '_rank' | 'segmentId'>>>
+		partInstances?: ReadonlyObjectDeep<ReactiveCacheCollection<DBPartInstance>>
+	},
 	rundownRanks: Record<string, number>
 ): MarkerPosition {
 	const part =
 		marker.type === QuickLoopMarkerType.PART
-			? 'parts' in partCache
-				? partCache.parts.findOne(marker.id)
-				: partCache.partInstances.findOne({ 'part._id': marker.id })?.part
+			? partCache.partInstances?.findOne({ 'part._id': marker.id })?.part ?? partCache.parts?.findOne(marker.id)
 			: undefined
 	const partRank = part?._rank ?? fallback
 

meteor/server/publications/partInstancesUI/publication.ts

@@ -159,7 +159,7 @@ export async function manipulateUIPartInstancesPublicationData(
 			playlist.quickLoop.start,
 			-Infinity,
 			state.contentCache.Segments,
-			{ partInstances: state.contentCache.PartInstances },
+			{ partInstances: state.contentCache.PartInstances, parts: state.contentCache.Parts },
 			rundownRanks
 		)
 	const quickLoopEndPosition =
@@ -168,7 +168,7 @@ export async function manipulateUIPartInstancesPublicationData(
 			playlist.quickLoop.end,
 			Infinity,
 			state.contentCache.Segments,
-			{ partInstances: state.contentCache.PartInstances },
+			{ partInstances: state.contentCache.PartInstances, parts: state.contentCache.Parts },
 			rundownRanks
 		)
 

meteor/server/publications/partInstancesUI/reactiveContentCache.ts

@@ -6,6 +6,7 @@ import { DBRundownPlaylist } from '@sofie-automation/corelib/dist/dataModel/Rund
 import { DBStudio, IStudioSettings } from '@sofie-automation/corelib/dist/dataModel/Studio'
 import { DBPartInstance } from '@sofie-automation/corelib/dist/dataModel/PartInstance'
 import { StudioId } from '@sofie-automation/corelib/dist/dataModel/Ids'
+import { DBPart } from '@sofie-automation/corelib/dist/dataModel/Part'
 
 export type RundownPlaylistCompact = Pick<DBRundownPlaylist, '_id' | 'activationId' | 'quickLoop' | 'rundownIdsInOrder'>
 export const rundownPlaylistFieldSpecifier = literal<MongoFieldSpecifierOnesStrict<RundownPlaylistCompact>>({
@@ -22,6 +23,14 @@ export const segmentFieldSpecifier = literal<MongoFieldSpecifierOnesStrict<Pick<
 	rundownId: 1,
 })
 
+export type PartFields = '_id' | '_rank' | 'rundownId' | 'segmentId'
+export const partFieldSpecifier = literal<MongoFieldSpecifierOnesStrict<Pick<DBPart, PartFields>>>({
+	_id: 1,
+	_rank: 1,
+	segmentId: 1,
+	rundownId: 1,
+})
+
 export type PartInstanceOmitedFields = 'part.privateData'
 export const partInstanceFieldSpecifier = literal<MongoFieldSpecifierZeroes<DBPartInstance>>({
 	// @ts-expect-error Mongo typings aren't clever enough yet
@@ -42,6 +51,7 @@ export interface StudioSettingsDoc {
 export interface ContentCache {
 	StudioSettings: ReactiveCacheCollection<StudioSettingsDoc>
 	Segments: ReactiveCacheCollection<Pick<DBSegment, SegmentFields>>
+	Parts: ReactiveCacheCollection<Pick<DBPart, PartFields>>
 	PartInstances: ReactiveCacheCollection<Omit<DBPartInstance, PartInstanceOmitedFields>>
 	RundownPlaylists: ReactiveCacheCollection<RundownPlaylistCompact>
 }
@@ -50,6 +60,7 @@ export function createReactiveContentCache(): ContentCache {
 	const cache: ContentCache = {
 		StudioSettings: new ReactiveCacheCollection<StudioSettingsDoc>('studioSettings'),
 		Segments: new ReactiveCacheCollection<Pick<DBSegment, SegmentFields>>('segments'),
+		Parts: new ReactiveCacheCollection<Pick<DBPart, PartFields>>('parts'),
 		PartInstances: new ReactiveCacheCollection<Omit<DBPartInstance, PartInstanceOmitedFields>>('partInstances'),
 		RundownPlaylists: new ReactiveCacheCollection<RundownPlaylistCompact>('rundownPlaylists'),
 	}

meteor/server/publications/partInstancesUI/rundownContentObserver.ts

@@ -3,14 +3,15 @@ import { RundownId, RundownPlaylistActivationId, StudioId } from '@sofie-automat
 import { logger } from '../../logging'
 import {
 	ContentCache,
+	partFieldSpecifier,
 	partInstanceFieldSpecifier,
 	rundownPlaylistFieldSpecifier,
 	segmentFieldSpecifier,
 	StudioFields,
 	studioFieldSpecifier,
 	StudioSettingsDoc,
 } from './reactiveContentCache'
-import { PartInstances, RundownPlaylists, Segments, Studios } from '../../collections'
+import { PartInstances, Parts, RundownPlaylists, Segments, Studios } from '../../collections'
 import { waitForAllObserversReady } from '../lib/lib'
 import { DBStudio } from '@sofie-automation/corelib/dist/dataModel/Studio'
 import { applyAndValidateOverrides } from '@sofie-automation/corelib/dist/settings/objectWithOverrides'
@@ -82,6 +83,17 @@ export class RundownContentObserver {
 					projection: segmentFieldSpecifier,
 				}
 			),
+			Parts.observeChanges(
+				{
+					rundownId: {
+						$in: rundownIds,
+					},
+				},
+				cache.Parts.link(),
+				{
+					projection: partFieldSpecifier,
+				}
+			),
 			PartInstances.observeChanges(
 				{
 					rundownId: {