feat: replace origo with react-bootstrap #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 'from scratch' rebuild of the css/styling using react-bootstrap instead of origo.
Not aiming for pixel perfect in most pages/areas, I am embracing that bootstrap wants to use slightly different numbers for its margins, and has slightly different style rules (rounded corners etc). The aim is for it to feel like the same software, even if things have shifted slightly.
The exception being pages like the rundownView, where the bulk of it should be a pixel perfect match.
Some bits where it doesnt look like bootstrap has a suitable equivalent has been copied into our code.
For testing this, clone and run as usual. I recommend also running just the webui from the base branch in parallel. Doing a
yarn devin the webui package will result in vite picking the next available port (3006), and will proxy connections to the same meteor backend. This allows for easy side by side comparisons of the exact same state.Skipped pages:
A few before and after screenshots:
