Tests: don't link FailingBuilds with catch

bblanchon · bblanchon · commit 20219d74f0bb · 2024-10-23T15:04:52.000+02:00
diff --git a/extras/tests/CMakeLists.txt b/extras/tests/CMakeLists.txt
@@ -5,15 +5,18 @@
 set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
-add_subdirectory(catch)
+link_libraries(ArduinoJson)
 
-link_libraries(ArduinoJson catch)
+# Failing builds should only link with ArduinoJson, not catch
+add_subdirectory(FailingBuilds)
+
+add_subdirectory(catch)
+link_libraries(catch)
 
 include_directories(Helpers)
 add_subdirectory(Cpp17)
 add_subdirectory(Cpp20)
 add_subdirectory(Deprecated)
-add_subdirectory(FailingBuilds)
 add_subdirectory(IntegrationTests)
 add_subdirectory(JsonArray)
 add_subdirectory(JsonArrayConst)
diff --git a/extras/tests/FailingBuilds/CMakeLists.txt b/extras/tests/FailingBuilds/CMakeLists.txt
@@ -16,7 +16,7 @@ macro(build_should_fail target)
 	set_tests_properties(${target}
 		PROPERTIES
 			WILL_FAIL TRUE
-			LABELS "WillFail;Catch"
+			LABELS "WillFail"
 	)
 endmacro()
 

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ macro(build_should_fail target)`
`16`	`16`	`set_tests_properties(${target}`
`17`	`17`	`PROPERTIES`
`18`	`18`	`WILL_FAIL TRUE`
`19`		`- LABELS "WillFail;Catch"`
	`19`	`+ LABELS "WillFail"`
`20`	`20`	`)`
`21`	`21`	`endmacro()`
`22`	`22`