Fixed the reverse opJoinNamesArray transofrmation

Signed-off-by: Juanjo Alvarez <[email protected]>

Author: Juanjo Alvarez

driver/normalizer/normalizer.go

@@ -78,7 +78,7 @@ func (op opJoinNamesArray) Check(st *State, n nodes.Node) (bool, error) {
 		qual.Names = append(qual.Names, id)
 	}
 
-	n, err := uast.ToNode(qual)
+	n, err := uast.ToNode(qual.Names)
 	if err != nil {
 		return false, err
 	}

driver/normalizer/normalizer_test.go

@@ -1,7 +1,6 @@
 package normalizer
 
 import (
-	"fmt"
 	"github.com/stretchr/testify/require"
 	"gopkg.in/bblfsh/sdk.v2/uast/nodes"
 	"testing"
@@ -13,7 +12,6 @@ func TestOpJoinNamesArray(t *testing.T) {
 	op := opJoinNamesArray{Var("x")}
 	st := NewState()
 	n1 := nodes.String("a::b::c")
-	fmt.Println(string(n1) == "a::b::c") // true
 
 	res, err := op.Check(st, n1)
 	require.NoError(t, err)
@@ -22,17 +20,29 @@ func TestOpJoinNamesArray(t *testing.T) {
 	n2, ok := st.GetVar("x")
 	require.True(t, ok)
 	require.NotNil(t, n2)
-	//fmt.Println(n2) // prints the QualifiedIdentifier correctly
+	require.Equal(t, nodes.Array{
+		nodes.Object{
+			"@type": nodes.String("uast:Identifier"),
+			"@pos":nodes.Object{"@type":nodes.String("uast:Positions")},
+			"Name": nodes.String("a"),
+		},
+		nodes.Object{
+			"@type": nodes.String("uast:Identifier"),
+			"@pos":nodes.Object{"@type":nodes.String("uast:Positions")},
+			"Name": nodes.String("b"),
+		},
+		nodes.Object{
+			"@type": nodes.String("uast:Identifier"),
+			"@pos":nodes.Object{"@type":nodes.String("uast:Positions")},
+			"Name": nodes.String("c"),
+		},
+	}, n2)
 
 	n3, err := op.Construct(st, nil)
 	require.NotNil(t, n3)
 	require.NoError(t, err)
-	fmt.Println("XXX n3")
-	fmt.Println(n3)
-	x, ok := n3.(nodes.String)
+	n4, ok := n3.(nodes.String)
 	require.True(t, ok)
-	fmt.Println("XXX should be String")
-	fmt.Println(x) // empty
-	fmt.Println(string(x))
-	fmt.Println(string(x) == "a::b::c") // false
+	require.Equal(t, n1, n4)
+	require.Equal(t, string(n4), "a::b::c")
 }