Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Commit f6d9cfb

Browse files
author
Juanjo Alvarez
committed
Feedback from review
Signed-off-by: Juanjo Alvarez <[email protected]>
1 parent b9b7a4f commit f6d9cfb

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

driver/normalizer/normalizer.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,14 +134,14 @@ var Normalizers = []Mapping{
134134
"IsSystem": Bool(true),
135135
// Always empty on current tests, this should detect other cases
136136
"Path": String(""),
137-
// TODO(juanjux): save this once we've a way
137+
// FIXME(juanjux): save this once we've a way
138138
"Resolved": Any(),
139139
},
140140
{
141141
"Name": StringConv(Var("path"), prependDotSlash, removeDotSlash),
142142
"IsSystem": Bool(false),
143143
"Path": String(""),
144-
// TODO(juanjux): save this once we've a way
144+
// FIXME(juanjux): save this once we've a way
145145
"Resolved": Any(),
146146
},
147147
}),
@@ -158,9 +158,8 @@ var Normalizers = []Mapping{
158158
MapSemantic("CPPASTCompoundStatement", uast.Block{}, MapObj(
159159
Fields{
160160
{Name: "Prop_Statements", Op: Var("statements")},
161-
// TODO(juanjyux): save this once we have a way.
161+
// FIXME(juanjux): save all these once we have a way.
162162
{Name: "ExpandedFromMacro", Optional: "optMacro", Op: Any()},
163-
// TODO(juanjux): do something to don't lose these
164163
{Name: "LeadingComments", Optional: "optLeadingComments", Op: Any()},
165164
{Name: "FreestadingComments", Optional: "optFSComments", Op: Any()},
166165
{Name: "TrailingComments", Optional: "optTlComments", Op: Any()},
@@ -173,7 +172,7 @@ var Normalizers = []Mapping{
173172
// Empty {}
174173
MapSemantic("CPPASTCompoundStatement", uast.Block{}, MapObj(
175174
Fields{
176-
// TODO(juanjux): do something to don't lose these
175+
// FIXME(juanjux): save all these once we have a way
177176
{Name: "LeadingComments", Optional: "optLeadingComments", Op: Any()},
178177
{Name: "FreestadingComments", Optional: "optFSComments", Op: Any()},
179178
{Name: "TrailingComments", Optional: "optTlComments", Op: Any()},
@@ -217,7 +216,7 @@ var Normalizers = []Mapping{
217216
Fields{
218217
{Name: "IASTClass", Op: String("CPPASTName")},
219218
{Name: "Name", Op: String("")},
220-
// TODO(juanjyux): save this once we have a way.
219+
// FIXME(juanjux): save this once we have a way.
221220
{Name: "ExpandedFromMacro", Optional: "optMacro", Op: Any()},
222221
},
223222
Is(nil),
@@ -277,7 +276,7 @@ var Normalizers = []Mapping{
277276
{Name: "IsConversionOperator", Op: Bool(false)},
278277
// Ignored: already on AllSegments
279278
{Name: "Prop_Qualifier", Optional: "optPropQual", Op: Any()},
280-
// TODO(juanjux): save these two once we've a way
279+
// FIXME(juanjux): save these two once we've a way
281280
{Name: "ExpandedFromMacro", Optional: "optMacro1", Op: Any()},
282281
{Name: "IsFullyQualified", Op: Any()},
283282
// Same as Prop_AllSegments but in a single string ("foo::bar::baz") instead of a list
@@ -303,7 +302,7 @@ var Normalizers = []Mapping{
303302
Fields{
304303
{Name: "IsDefaulted", Op: Any()},
305304
{Name: "IsDeleted", Op: Any()},
306-
// TODO(juanjux): save this once we've a way
305+
// FIXME(juanjux): save this once we've a way
307306
{Name: "ExpandedFromMacro", Optional: "optMacro1", Op: Any()},
308307
{Name: "Prop_Body", Optional: "optBody", Op: Var("body")},
309308
{Name: "LeadingComments", Optional: "optLeadingComments", Op: Var("leadingComments")},

0 commit comments

Comments
 (0)