Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Commit a836d36

Browse files
committed
sem: add comments to clarify mapping skip cases
Signed-off-by: Alexander Bezzubov <[email protected]>
1 parent 175bec4 commit a836d36

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

driver/normalizer/normalizer.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ var Preprocessors = []Mapping{
4040
"extra": Fields{
4141
{Name: "raw", Op: Var("raw")},
4242
{Name: "rawValue", Op: Any()},
43-
//FIXME(bzz): map parenthesis
43+
//TODO(bzz): make sure parenthesis mapping is consistent \w other drivers
4444
{Name: "parenthesized", Drop: true, Op: Any()},
4545
{Name: "parenStart", Drop: true, Op: Any()},
4646
},
@@ -55,7 +55,7 @@ var Preprocessors = []Mapping{
5555
uast.KeyType: String("RegExpLiteral"),
5656
"extra": Fields{
5757
{Name: "raw", Op: Var("raw")},
58-
//FIXME(bzz): map parenthesis
58+
//TODO(bzz): make sure parenthesis mapping is consistent \w other drivers
5959
{Name: "parenthesized", Drop: true, Op: Any()},
6060
{Name: "parenStart", Drop: true, Op: Any()},
6161
},
@@ -265,11 +265,15 @@ var Normalizers = []Mapping{
265265
{Name: "generator", Op: Var("gen")}, // FIXME: define channels in SDK? or return a function?
266266
{Name: "async", Op: Var("async")}, // TODO: async
267267
{Name: "body", Op: Var("body")},
268-
//FIXME(bzz): map predicate properly
268+
//FIXME(bzz): map Flow predicate properly
269+
// https://flow.org/en/docs/types/functions/#toc-predicate-functions
269270
{Name: "predicate", Drop: true, Op: Any()},
270271
//FIXME(bzz): map Flow return type annotations
272+
// https://flow.org/en/docs/types/functions/#toc-function-returns
271273
{Name: "returnType", Drop: true, Op: Any()},
272-
//FIXME(bzz): map Flow argument type annotations
274+
//FIXME(bzz): map Flow generic types annotations
275+
// https://flow.org/en/docs/types/generics/
276+
// see fixtures/ext_typedecl.js#34 func makeWeakCache
273277
{Name: "typeParameters", Drop: true, Op: Any()},
274278
// FIXME(bzz): make sure such comments are linked properly
275279
{Name: "leadingComments", Drop: true, Op: Any()},

0 commit comments

Comments
 (0)