Limit table buffer to avoid memory allocation issue for large buffers

bbogush · bbogush · commit 6c8b3304a8de · 2022-07-10T17:23:17.000+03:00
diff --git a/qt/buffer_table_model.cpp b/qt/buffer_table_model.cpp
@@ -5,6 +5,8 @@
 
 #include "buffer_table_model.h"
 
+#define TABLE_BUFFER_LIMIT (1024*1024*1024)
+
 BufferTableModel::BufferTableModel(QObject *parent):
     QAbstractTableModel(parent)
 {
@@ -14,7 +16,13 @@ BufferTableModel::BufferTableModel(QObject *parent):
 
 int BufferTableModel::rowCount(const QModelIndex & /*parent*/) const
 {
-    return (state.fileSize + ROW_DATA_SIZE - 1) / ROW_DATA_SIZE;
+    qint64 tableBufferSize = state.fileSize;
+
+    // Limit buffer size to avoid memory overlows for large buffers
+    if (tableBufferSize > TABLE_BUFFER_LIMIT)
+        tableBufferSize = TABLE_BUFFER_LIMIT;
+
+    return (tableBufferSize + ROW_DATA_SIZE - 1) / ROW_DATA_SIZE;
 }
 
 int BufferTableModel::columnCount(const QModelIndex & /*parent*/) const

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,8 @@`
`5`	`5`
`6`	`6`	`#include "buffer_table_model.h"`
`7`	`7`
	`8`	`+#define TABLE_BUFFER_LIMIT (102410241024)`
	`9`	`+`
`8`	`10`	`BufferTableModel::BufferTableModel(QObject *parent):`
`9`	`11`	`QAbstractTableModel(parent)`
`10`	`12`	`{`
`@@ -14,7 +16,13 @@ BufferTableModel::BufferTableModel(QObject *parent):`
`14`	`16`
`15`	`17`	`int BufferTableModel::rowCount(const QModelIndex & /parent/) const`
`16`	`18`	`{`
`17`		`- return (state.fileSize + ROW_DATA_SIZE - 1) / ROW_DATA_SIZE;`
	`19`	`+ qint64 tableBufferSize = state.fileSize;`
	`20`	`+`
	`21`	`+ // Limit buffer size to avoid memory overlows for large buffers`
	`22`	`+ if (tableBufferSize > TABLE_BUFFER_LIMIT)`
	`23`	`+ tableBufferSize = TABLE_BUFFER_LIMIT;`
	`24`	`+`
	`25`	`+ return (tableBufferSize + ROW_DATA_SIZE - 1) / ROW_DATA_SIZE;`
`18`	`26`	`}`
`19`	`27`
`20`	`28`	`int BufferTableModel::columnCount(const QModelIndex & /parent/) const`