Added 0 length verification for read and write command handlers

bbogush · bbogush · commit b097d682b453 · 2018-12-30T20:48:23.000+02:00
diff --git a/firmware/nand_programmer.c b/firmware/nand_programmer.c
@@ -385,6 +385,12 @@ static int np_cmd_nand_write_start(np_prog_t *prog)
         return NP_ERR_ADDR_NOT_ALIGN;
     }
 
+    if (!len)
+    {
+        ERROR_PRINT("Length is 0\r\n");
+        return NP_ERR_LEN_INVALID;
+    }
+
     if (len & (prog->chip_info->page_size - 1))
     {
         ERROR_PRINT("Length 0x%lx is not aligned to page size 0x%lx\r\n",
@@ -621,6 +627,12 @@ static int _np_cmd_nand_read(np_prog_t *prog)
         return NP_ERR_ADDR_NOT_ALIGN;
     }
 
+    if (!len)
+    {
+        ERROR_PRINT("Length is 0\r\n");
+        return NP_ERR_LEN_INVALID;
+    }
+
     if (len & (prog->chip_info->page_size - 1))
     {
         ERROR_PRINT("Read length 0x%lx is not aligned to page size 0x%lx\r\n",

Original file line number	Diff line number	Diff line change
`@@ -385,6 +385,12 @@ static int np_cmd_nand_write_start(np_prog_t *prog)`
`385`	`385`	`return NP_ERR_ADDR_NOT_ALIGN;`
`386`	`386`	`}`
`387`	`387`
	`388`	`+ if (!len)`
	`389`	`+ {`
	`390`	`+ ERROR_PRINT("Length is 0\r\n");`
	`391`	`+ return NP_ERR_LEN_INVALID;`
	`392`	`+ }`
	`393`	`+`
`388`	`394`	`if (len & (prog->chip_info->page_size - 1))`
`389`	`395`	`{`
`390`	`396`	`ERROR_PRINT("Length 0x%lx is not aligned to page size 0x%lx\r\n",`
`@@ -621,6 +627,12 @@ static int _np_cmd_nand_read(np_prog_t *prog)`
`621`	`627`	`return NP_ERR_ADDR_NOT_ALIGN;`
`622`	`628`	`}`
`623`	`629`
	`630`	`+ if (!len)`
	`631`	`+ {`
	`632`	`+ ERROR_PRINT("Length is 0\r\n");`
	`633`	`+ return NP_ERR_LEN_INVALID;`
	`634`	`+ }`
	`635`	`+`
`624`	`636`	`if (len & (prog->chip_info->page_size - 1))`
`625`	`637`	`{`
`626`	`638`	`ERROR_PRINT("Read length 0x%lx is not aligned to page size 0x%lx\r\n",`