Skip to content

Commit 80e933a

Browse files
committed
Other small CLI javadoc/logging improvements
1 parent fd93dea commit 80e933a

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

modules/cli-module/src/test/java/org/simplejavamail/internal/clisupport/GenerateCliHelpTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ public class GenerateCliHelpTest {
1414

1515
@Before
1616
public void setUpStreams() {
17+
System.out.println("GenerateCliHelpTest.setUpStreams(): DISABLING System.out during CLI debug logging");
1718
sysOut = System.out;
1819
System.setOut(new PrintStream(outContent));
1920
}

modules/core-module/src/main/java/org/simplejavamail/api/email/EmailPopulatingBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ public interface EmailPopulatingBuilder {
10801080
* @param description An optional description that will find its way in the MimeMEssage with the Content-Description header. This is rarely needed.
10811081
* @param contentTransferEncoding An optional encoder option to force the data encoding while in MimeMessage/EML format.
10821082
*
1083-
* @see #withAttachment(String, DataSource)
1083+
* @see #withAttachment(String, DataSource, String, ContentTransferEncoding)
10841084
* @see #withAttachments(List)
10851085
*/
10861086
EmailPopulatingBuilder withAttachment(@Nullable String name, @NotNull byte[] data, @NotNull String mimetype, @Nullable String description, @Nullable ContentTransferEncoding contentTransferEncoding);
@@ -1116,7 +1116,7 @@ public interface EmailPopulatingBuilder {
11161116
* @param description An optional description that will find its way in the MimeMEssage with the Content-Description header. This is rarely needed.
11171117
* @param contentTransferEncoding An optional encoder option to force the data encoding while in MimeMessage/EML format.
11181118
*
1119-
* @see #withAttachment(String, byte[], String)
1119+
* @see #withAttachment(String, DataSource, String, ContentTransferEncoding)
11201120
* @see #withAttachments(List)
11211121
*/
11221122
EmailPopulatingBuilder withAttachment(@Nullable String name, @NotNull DataSource filedata, @Nullable final String description, @Nullable final ContentTransferEncoding contentTransferEncoding);

modules/simple-java-mail/src/main/java/org/simplejavamail/email/internal/EmailPopulatingBuilderImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1773,7 +1773,7 @@ public InternalEmailPopulatingBuilder withDecryptedAttachments(@NotNull final Li
17731773
}
17741774

17751775
/**
1776-
* Delegates to {@link EmailPopulatingBuilder#signWithDomainKey(byte[], String, String)}.
1776+
* @see EmailPopulatingBuilder#signWithDomainKey(String, String, String)
17771777
*/
17781778
@Override
17791779
@Cli.ExcludeApi(reason = "delegated method is an identical api from CLI point of view")
@@ -1783,7 +1783,7 @@ public EmailPopulatingBuilder signWithDomainKey(@NotNull final String dkimPrivat
17831783
}
17841784

17851785
/**
1786-
* Delegates to {@link EmailPopulatingBuilder#signWithDomainKey(InputStream, String, String)}.
1786+
* @see EmailPopulatingBuilder#signWithDomainKey(File, String, String)
17871787
*/
17881788
@Override
17891789
@Cli.ExcludeApi(reason = "delegated method is an identical api from CLI point of view")
@@ -1797,7 +1797,7 @@ public EmailPopulatingBuilder signWithDomainKey(@NotNull final File dkimPrivateK
17971797
}
17981798

17991799
/**
1800-
* Delegates to {@link EmailPopulatingBuilder#signWithDomainKey(byte[], String, String)}.
1800+
* @see EmailPopulatingBuilder#signWithDomainKey(InputStream, String, String)
18011801
*/
18021802
@Override
18031803
public EmailPopulatingBuilder signWithDomainKey(@NotNull final InputStream dkimPrivateKeyInputStream, @NotNull final String signingDomain,

0 commit comments

Comments
 (0)