Skip to content

Commit a7723cd

Browse files
committed
Use standard JDK regex library instead of named-regexp library since Java 8+ is required and natively supports named capture groups.
1 parent 9b38b7b commit a7723cd

File tree

9 files changed

+22
-33
lines changed

9 files changed

+22
-33
lines changed

modules/cli-module/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,6 @@
101101
<scope>compile</scope>
102102
</dependency>
103103

104-
<dependency><!-- support for named regex groups in Android -->
105-
<groupId>com.github.tony19</groupId>
106-
<artifactId>named-regexp</artifactId>
107-
<version>0.2.6</version>
108-
</dependency>
109-
110104
<!-- Logging -->
111105
<dependency>
112106
<groupId>org.apache.logging.log4j</groupId>

modules/cli-module/src/main/java/org/simplejavamail/internal/clisupport/BuilderApiToPicocliCommandsMapper.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.simplejavamail.internal.clisupport;
22

3-
import com.google.code.regexp.Matcher;
4-
import com.google.code.regexp.Pattern;
53
import jakarta.activation.DataSource;
64
import jakarta.mail.internet.MimeMessage;
75
import org.bbottema.javareflection.BeanUtils;
@@ -47,12 +45,14 @@
4745
import java.util.Set;
4846
import java.util.TreeSet;
4947
import java.util.UUID;
48+
import java.util.regex.Matcher;
49+
import java.util.regex.Pattern;
5050

51-
import static com.google.code.regexp.Pattern.compile;
5251
import static java.lang.String.format;
5352
import static java.util.Arrays.asList;
5453
import static java.util.EnumSet.allOf;
5554
import static java.util.EnumSet.of;
55+
import static java.util.regex.Pattern.compile;
5656
import static org.bbottema.javareflection.TypeUtils.containsAnnotation;
5757
import static org.simplejavamail.internal.util.Preconditions.assumeTrue;
5858
import static org.simplejavamail.internal.util.Preconditions.checkNonEmptyArgument;

modules/cli-module/src/main/java/org/simplejavamail/internal/clisupport/therapijavadoc/TherapiJavadocHelper.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import com.github.therapi.runtimejavadoc.RuntimeJavadoc;
88
import com.github.therapi.runtimejavadoc.SeeAlsoJavadoc;
99
import com.github.therapi.runtimejavadoc.Value;
10-
import com.google.code.regexp.Matcher;
1110
import org.bbottema.javareflection.ClassUtils;
1211
import org.bbottema.javareflection.MethodUtils;
1312
import org.jetbrains.annotations.NotNull;
@@ -24,11 +23,12 @@
2423
import java.util.List;
2524
import java.util.Map;
2625
import java.util.Set;
26+
import java.util.regex.Matcher;
2727

28-
import static com.google.code.regexp.Pattern.compile;
2928
import static java.lang.String.format;
3029
import static java.util.Arrays.asList;
3130
import static java.util.Optional.ofNullable;
31+
import static java.util.regex.Pattern.compile;
3232
import static org.simplejavamail.internal.clisupport.BuilderApiToPicocliCommandsMapper.colorizeDescriptions;
3333
import static org.simplejavamail.internal.util.ListUtil.getFirst;
3434
import static org.simplejavamail.internal.util.StringUtil.padRight;
@@ -185,4 +185,4 @@ public static class DocumentedMethodParam {
185185
@NotNull public String getName() { return name; }
186186
@NotNull public String getJavadoc() { return javadoc; }
187187
}
188-
}
188+
}

modules/core-module/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,5 @@
4747
<version>0.13.0</version>
4848
<scope>provided</scope><!-- makes library mandatory if we should support CLI (even optionally) -->
4949
</dependency>
50-
51-
<dependency><!-- support for named regex groups in Android -->
52-
<groupId>com.github.tony19</groupId>
53-
<artifactId>named-regexp</artifactId>
54-
<version>0.2.6</version>
55-
</dependency>
5650
</dependencies>
5751
</project>

modules/core-module/src/main/java/org/simplejavamail/api/email/EmailPopulatingBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.simplejavamail.api.email;
22

3-
import com.google.code.regexp.Pattern;
43
import jakarta.activation.DataSource;
54
import jakarta.mail.Message;
65
import jakarta.mail.internet.InternetAddress;
@@ -21,8 +20,9 @@
2120
import java.util.Date;
2221
import java.util.List;
2322
import java.util.Map;
23+
import java.util.regex.Pattern;
2424

25-
import static com.google.code.regexp.Pattern.compile;
25+
import static java.util.regex.Pattern.compile;
2626

2727

2828
/**
@@ -1658,4 +1658,4 @@ public interface EmailPopulatingBuilder {
16581658
*/
16591659
@Nullable
16601660
Date getSentDate();
1661-
}
1661+
}

modules/core-module/src/main/java/org/simplejavamail/config/ConfigLoader.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.simplejavamail.config;
22

3-
import com.google.code.regexp.Matcher;
4-
import com.google.code.regexp.Pattern;
53
import org.jetbrains.annotations.NotNull;
64
import org.jetbrains.annotations.Nullable;
75
import org.simplejavamail.api.mailer.config.LoadBalancingStrategy;
@@ -19,9 +17,11 @@
1917
import java.util.Map;
2018
import java.util.Properties;
2119
import java.util.Set;
20+
import java.util.regex.Matcher;
21+
import java.util.regex.Pattern;
2222

23-
import static com.google.code.regexp.Pattern.compile;
2423
import static java.util.Collections.unmodifiableMap;
24+
import static java.util.regex.Pattern.compile;
2525
import static org.simplejavamail.internal.util.MiscUtil.checkArgumentNotEmpty;
2626
import static org.simplejavamail.internal.util.MiscUtil.valueNullOrEmpty;
2727
import static org.simplejavamail.internal.util.Preconditions.assumeTrue;
@@ -455,4 +455,4 @@ static Object parsePropertyValue(final @Nullable String propertyValue) {
455455
// return value as is (which should be string)
456456
return propertyValue;
457457
}
458-
}
458+
}

modules/core-module/src/main/java/org/simplejavamail/internal/util/StringUtil.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
package org.simplejavamail.internal.util;
22

3-
import com.google.code.regexp.Matcher;
4-
import com.google.code.regexp.Pattern;
53
import org.jetbrains.annotations.NotNull;
64

7-
import static com.google.code.regexp.Pattern.compile;
5+
import java.util.regex.Matcher;
6+
import java.util.regex.Pattern;
7+
88
import static java.lang.String.format;
9+
import static java.util.regex.Pattern.compile;
910
import static java.util.regex.Pattern.quote;
1011
import static org.simplejavamail.internal.util.Preconditions.assumeTrue;
1112

modules/simple-java-mail/src/main/java/org/simplejavamail/email/internal/EmailPopulatingBuilderImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.simplejavamail.email.internal;
22

3-
import com.google.code.regexp.Matcher;
43
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
54
import jakarta.activation.DataSource;
65
import jakarta.mail.Message.RecipientType;
@@ -41,6 +40,7 @@
4140
import java.util.HashMap;
4241
import java.util.List;
4342
import java.util.Map;
43+
import java.util.regex.Matcher;
4444

4545
import static jakarta.mail.Message.RecipientType.BCC;
4646
import static jakarta.mail.Message.RecipientType.CC;
@@ -2475,4 +2475,4 @@ public X509Certificate getX509CertificateForSmimeEncryption() {
24752475
public Date getSentDate() {
24762476
return sentDate != null ? new Date(sentDate.getTime()) : null;
24772477
}
2478-
}
2478+
}

modules/simple-java-mail/src/test/java/org/simplejavamail/email/internal/EmailPopulatingBuilderImpl1Test.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.simplejavamail.email.internal;
22

3-
import com.google.code.regexp.Matcher;
4-
import com.google.code.regexp.Pattern;
53
import jakarta.activation.DataSource;
64
import jakarta.mail.Message;
75
import jakarta.mail.internet.InternetAddress;
@@ -34,6 +32,8 @@
3432
import java.util.ArrayList;
3533
import java.util.Arrays;
3634
import java.util.List;
35+
import java.util.regex.Matcher;
36+
import java.util.regex.Pattern;
3737

3838
import static demo.ResourceFolderHelper.determineResourceFolder;
3939
import static jakarta.mail.Message.RecipientType.BCC;
@@ -1405,4 +1405,4 @@ public String getName() {
14051405
return "dummy";
14061406
}
14071407
}
1408-
}
1408+
}

0 commit comments

Comments
 (0)