Skip to content

Commit b83ef5b

Browse files
committed
Solved SpotBugs issue regarding byte array references. Let's clone all the things!
1 parent acbf262 commit b83ef5b

File tree

1 file changed

+9
-1
lines changed
  • modules/core-module/src/main/java/org/simplejavamail/api/email/config

1 file changed

+9
-1
lines changed

modules/core-module/src/main/java/org/simplejavamail/api/email/config/DkimConfig.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,20 @@ public class DkimConfig implements Serializable {
5454
@Nullable private final Set<String> excludedHeadersFromDkimDefaultSigningList;
5555

5656
DkimConfig(byte[] dkimPrivateKeyData, String dkimSigningDomain, String dkimSelector, @Nullable Set<String> excludedHeadersFromDkimDefaultSigningList) {
57-
this.dkimPrivateKeyData = dkimPrivateKeyData;
57+
this.dkimPrivateKeyData = dkimPrivateKeyData.clone();
5858
this.dkimSigningDomain = dkimSigningDomain;
5959
this.dkimSelector = dkimSelector;
6060
this.excludedHeadersFromDkimDefaultSigningList = excludedHeadersFromDkimDefaultSigningList;
6161
}
6262

63+
/**
64+
* @see EmailPopulatingBuilder#signWithDomainKey(DkimConfig)
65+
* @see EmailPopulatingBuilder#signWithDomainKey(byte[], String, String, Set)
66+
*/
67+
public byte[] getDkimPrivateKeyData() {
68+
return dkimPrivateKeyData.clone();
69+
}
70+
6371
public static DkimConfigBuilder builder() {
6472
return new DkimConfigBuilder();
6573
}

0 commit comments

Comments
 (0)