Skip to content

Commit f2f6798

Browse files
committed
Resolved a few FIXME's and fixed a comment typo
1 parent 349cd24 commit f2f6798

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

modules/simple-java-mail/src/main/java/org/simplejavamail/email/internal/EmailPopulatingBuilderImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2493,7 +2493,6 @@ public DkimConfig getDkimConfig() {
24932493
*/
24942494
@Override
24952495
@Nullable
2496-
// FIXME what's the point of these useXXX methods?
24972496
public Boolean getUseDispositionNotificationTo() {
24982497
return useDispositionNotificationTo;
24992498
}

modules/simple-java-mail/src/main/java/org/simplejavamail/mailer/internal/EmailGovernanceImpl.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,10 @@ public static EmailGovernance NO_GOVERNANCE() {
109109
*/
110110
@Nullable private final Integer maximumEmailSize;
111111

112-
// FIXME get rid of all the default properties in Email and move them to EmailDefaults
113112
public EmailGovernanceImpl(@Nullable EmailValidator emailValidator, @Nullable Email emailDefaults, @Nullable Email emailOverrides, @Nullable Integer maximumEmailSize) {
114113
this.emailValidator = emailValidator;
115114
this.emailDefaults = emailDefaults != null ? emailDefaults : newDefaultsEmailWithDefaultDefaults();
116-
// FIXME ignoringDefaults should go away as defaults are moved out of the Email constructor / edit: ignoringDefaults still has merit for the email builder
117-
this.emailOverrides = emailOverrides != null ? emailOverrides : EmailBuilder.ignoringDefaults().startingBlank().buildEmail();
115+
this.emailOverrides = emailOverrides != null ? emailOverrides : EmailBuilder.startingBlank().buildEmail();
118116
this.maximumEmailSize = maximumEmailSize;
119117
}
120118

@@ -243,19 +241,16 @@ public EmailWithDefaultsAndOverridesApplied produceEmailApplyingDefaultsAndOverr
243241
}
244242

245243
@Nullable
246-
// FIXME This shouldn't be called anymore, since an Email should just be completed by EmailGovernance and then _its_ already resolved properties should be used instead
247244
private <T> T resolveEmailProperty(@Nullable Email email, @NotNull EmailProperty emailProperty) {
248245
return overrideOrProvideOrDefaultProperty(email, emailDefaults, emailOverrides, emailProperty);
249246
}
250247

251248
@NotNull
252-
// FIXME same as above
253249
private <T> List<T> resolveEmailCollectionProperty(@Nullable Email email, @NotNull EmailProperty emailProperty) {
254250
return overrideAndOrProvideAndOrDefaultCollection(email, emailDefaults, emailOverrides, emailProperty);
255251
}
256252

257253
@NotNull
258-
// FIXME same as above
259254
private Map<String, Collection<String>> resolveEmailHeadersProperty(@Nullable Email email) {
260255
return overrideAndOrProvideAndOrDefaultHeaders(email, emailDefaults, emailOverrides);
261256
}

modules/simple-java-mail/src/test/java/org/simplejavamail/mailer/MailerLiveTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ private Email assertSendingEmail(final EmailPopulatingBuilder originalEmailPopul
389389
}
390390

391391
Email receivedEmail = mimeMessageToEmailBuilder(receivedMimeMessage.getMimeMessage(), loadPkcs12KeyStore())
392-
.ignoringDefaults(false) // FIXME perhpas we should make this default, when converting a MimeMessage to an Email?
392+
.ignoringDefaults(false) // FIXME perhaps we should make this default, when converting a MimeMessage to an Email?
393393
.buildEmail();
394394

395395
if (!sentDateWasFixed) {

0 commit comments

Comments
 (0)