refactor(core): use empty arr when updating all internals (#1476)

* refactor(core): use empty arr when updating all internals

* chore(changeset): add

Author: bcakmakoglu

.changeset/silver-plums-relate.md

@@ -0,0 +1,5 @@
+---
+"@vue-flow/core": minor
+---
+
+Use empty array when determing whether to update all node internals

packages/core/src/components/Nodes/NodeWrapper.ts

@@ -153,7 +153,8 @@ const NodeWrapper = defineComponent({
     const zIndex = toRef(() => Number(node.zIndex ?? getStyle.value.zIndex ?? 0))
 
     onUpdateNodeInternals((updateIds) => {
-      if (updateIds.includes(props.id)) {
+      // when no ids are passed, update all nodes
+      if (updateIds.includes(props.id) || !updateIds.length) {
         updateInternals()
       }
     })

packages/core/src/composables/useViewportHelper.ts

@@ -39,7 +39,6 @@ const initialViewportHelper: ViewportHelper = {
  *
  * @internal
  * @param state
- * @param getters
  */
 export function useViewportHelper(state: State) {
   function zoom(scale: number, duration?: number) {

packages/core/src/store/actions.ts

@@ -53,16 +53,11 @@ import {
 } from '../utils'
 import { storeOptionsToSkip, useState } from './state'
 
-export function useActions(
-  id: string,
-  state: State,
-  nodeLookup: ComputedRef<NodeLookup>,
-  edgeLookup: ComputedRef<EdgeLookup>,
-): Actions {
+export function useActions(state: State, nodeLookup: ComputedRef<NodeLookup>, edgeLookup: ComputedRef<EdgeLookup>): Actions {
   const viewportHelper = useViewportHelper(state)
 
   const updateNodeInternals: Actions['updateNodeInternals'] = (ids) => {
-    const updateIds = ids ?? state.nodes.map((n) => n.id) ?? []
+    const updateIds = ids ?? []
 
     state.hooks.updateNodeInternals.trigger(updateIds)
   }

packages/core/src/utils/storage.ts

@@ -78,7 +78,7 @@ export class Storage {
 
     const getters = useGetters(reactiveState, nodeLookup, edgeLookup)
 
-    const actions = useActions(id, reactiveState, nodeLookup, edgeLookup)
+    const actions = useActions(reactiveState, nodeLookup, edgeLookup)
 
     actions.setState({ ...reactiveState, ...preloadedState })