Skip to content

Commit 71f1bbc

Browse files
committed
fix revdep issues
1 parent 8f06260 commit 71f1bbc

File tree

4 files changed

+235
-202
lines changed

4 files changed

+235
-202
lines changed

.Rbuildignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ Icon?
1919
^CITATION\.cff$
2020
^R/honest_did$
2121
^CLAUDE\.md$
22-
^\.lintr$
22+
^\.lintr$
23+
^revdep_manual$

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,5 @@ desktop.ini
1414
did.Rproj
1515
..Rcheck/
1616
CLAUDE.md
17-
.vscode/
17+
.vscode/
18+
.revdep_manual/

R/att_gt.R

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,19 @@
6262
#' is NULL which is equivalent to `xformla=~1`. This is
6363
#' used to create a matrix of covariates which is then passed
6464
#' to the 2x2 DID estimator chosen in `est_method`.
65+
#'
66+
#' For time-varying covariates: (1) With balanced panel data,
67+
#' in each 2x2 comparison, the covariates
68+
#' are taken to be the value of the covariates in the earlier time
69+
#' period, and all of the underlying computation involve change in Y
70+
#' as a function of those values of covariates. (2) With repeated cross
71+
#' sections data and unbalanced panel data, the covariates are taken
72+
#' from each time period and computations involve Y_post conditional
73+
#' on X_post minus Y_pre conditional on X_pre. A byproduct of this
74+
#' is that, with balanced panel data and in the presence of
75+
#' time-varying covariates, it is possible to get different numerical
76+
#' results according to whether or not `allow_unbalanced_panel=TRUE` or
77+
#' `FALSE`.
6578
#' @param panel Whether or not the data is a panel dataset.
6679
#' The panel dataset should be provided in long format -- that
6780
#' is, where each row corresponds to a unit observed at a

0 commit comments

Comments
 (0)