Revert "[clang][CIR] Change buildX functions to emitX (llvm#115568)"

This reverts commit 1791b25.

Author: lanza

clang/lib/CIR/CodeGen/CIRGenModule.cpp

@@ -50,7 +50,7 @@ mlir::Location CIRGenModule::getLoc(SourceRange cRange) {
   return mlir::FusedLoc::get({begin, end}, metadata, builder.getContext());
 }
 
-void CIRGenModule::emitGlobal(clang::GlobalDecl gd) {
+void CIRGenModule::buildGlobal(clang::GlobalDecl gd) {
   const auto *global = cast<ValueDecl>(gd.getDecl());
 
   if (const auto *fd = dyn_cast<FunctionDecl>(global)) {
@@ -71,19 +71,19 @@ void CIRGenModule::emitGlobal(clang::GlobalDecl gd) {
   }
 
   // TODO(CIR): Defer emitting some global definitions until later
-  emitGlobalDefinition(gd);
+  buildGlobalDefinition(gd);
 }
 
-void CIRGenModule::emitGlobalFunctionDefinition(clang::GlobalDecl gd,
-                                                mlir::Operation *op) {
+void CIRGenModule::buildGlobalFunctionDefinition(clang::GlobalDecl gd,
+                                                 mlir::Operation *op) {
   auto const *funcDecl = cast<FunctionDecl>(gd.getDecl());
   auto funcOp = builder.create<cir::FuncOp>(
       getLoc(funcDecl->getSourceRange()), funcDecl->getIdentifier()->getName());
   theModule.push_back(funcOp);
 }
 
-void CIRGenModule::emitGlobalDefinition(clang::GlobalDecl gd,
-                                        mlir::Operation *op) {
+void CIRGenModule::buildGlobalDefinition(clang::GlobalDecl gd,
+                                         mlir::Operation *op) {
   const auto *decl = cast<ValueDecl>(gd.getDecl());
   if (const auto *fd = dyn_cast<FunctionDecl>(decl)) {
     // TODO(CIR): Skip generation of CIR for functions with available_externally
@@ -99,15 +99,15 @@ void CIRGenModule::emitGlobalDefinition(clang::GlobalDecl gd,
 
     if (fd->isMultiVersion())
       errorNYI(fd->getSourceRange(), "multiversion functions");
-    emitGlobalFunctionDefinition(gd, op);
+    buildGlobalFunctionDefinition(gd, op);
     return;
   }
 
-  llvm_unreachable("Invalid argument to CIRGenModule::emitGlobalDefinition");
+  llvm_unreachable("Invalid argument to CIRGenModule::buildGlobalDefinition");
 }
 
 // Emit code for a single top level declaration.
-void CIRGenModule::emitTopLevelDecl(Decl *decl) {
+void CIRGenModule::buildTopLevelDecl(Decl *decl) {
 
   // Ignore dependent declarations.
   if (decl->isTemplated())
@@ -123,7 +123,7 @@ void CIRGenModule::emitTopLevelDecl(Decl *decl) {
     auto *fd = cast<FunctionDecl>(decl);
     // Consteval functions shouldn't be emitted.
     if (!fd->isConsteval())
-      emitGlobal(fd);
+      buildGlobal(fd);
     break;
   }
   }

clang/lib/CIR/CodeGen/CIRGenModule.h

@@ -72,15 +72,15 @@ class CIRGenModule : public CIRGenTypeCache {
   mlir::Location getLoc(clang::SourceLocation cLoc);
   mlir::Location getLoc(clang::SourceRange cRange);
 
-  void emitTopLevelDecl(clang::Decl *decl);
+  void buildTopLevelDecl(clang::Decl *decl);
 
   /// Emit code for a single global function or variable declaration. Forward
   /// declarations are emitted lazily.
-  void emitGlobal(clang::GlobalDecl gd);
+  void buildGlobal(clang::GlobalDecl gd);
 
-  void emitGlobalDefinition(clang::GlobalDecl gd,
-                            mlir::Operation *op = nullptr);
-  void emitGlobalFunctionDefinition(clang::GlobalDecl gd, mlir::Operation *op);
+  void buildGlobalDefinition(clang::GlobalDecl gd,
+                             mlir::Operation *op = nullptr);
+  void buildGlobalFunctionDefinition(clang::GlobalDecl gd, mlir::Operation *op);
 
   /// Helpers to emit "not yet implemented" error diagnostics
   DiagnosticBuilder errorNYI(llvm::StringRef);

clang/lib/CIR/CodeGen/CIRGenerator.cpp

@@ -45,7 +45,7 @@ mlir::ModuleOp CIRGenerator::getModule() const { return cgm->getModule(); }
 bool CIRGenerator::HandleTopLevelDecl(DeclGroupRef group) {
 
   for (Decl *decl : group)
-    cgm->emitTopLevelDecl(decl);
+    cgm->buildTopLevelDecl(decl);
 
   return true;
 }