Update display name

Author: KillerX

backend/internal/database/migrations/00046_convert_display_name_to_regular_column.sql

@@ -0,0 +1,36 @@
+-- +goose Up
+-- Drop the index first
+DROP INDEX IF EXISTS idx_users_display_name;
+
+-- Temporarily store the computed values
+ALTER TABLE users ADD COLUMN display_name_temp VARCHAR(255);
+
+UPDATE users SET display_name_temp =
+    CASE
+        WHEN first_name IS NOT NULL AND first_name != ''
+             AND last_name IS NOT NULL AND last_name != ''
+        THEN first_name || ' ' || LEFT(last_name, 1) || '.'
+        ELSE name
+    END;
+
+-- Drop the generated column
+ALTER TABLE users DROP COLUMN display_name;
+
+-- Rename temp to display_name
+ALTER TABLE users RENAME COLUMN display_name_temp TO display_name;
+
+-- Recreate the index
+CREATE INDEX idx_users_display_name ON users(display_name);
+
+-- +goose Down
+DROP INDEX IF EXISTS idx_users_display_name;
+ALTER TABLE users DROP COLUMN display_name;
+ALTER TABLE users ADD COLUMN display_name VARCHAR(255) GENERATED ALWAYS AS (
+    CASE
+        WHEN first_name IS NOT NULL AND first_name != ''
+             AND last_name IS NOT NULL AND last_name != ''
+        THEN first_name || ' ' || LEFT(last_name, 1) || '.'
+        ELSE name
+    END
+) STORED;
+CREATE INDEX idx_users_display_name ON users(display_name);

backend/internal/handlers/auth.go

@@ -256,12 +256,17 @@ func (h *AuthHandler) findOrCreateUser(ctx context.Context, claims *BrunstadTVCl
 			displayName = member.DisplayName
 
 			// Compute name for backward compatibility
-			if displayName != "" {
-				computedName = displayName
-			} else if firstName != "" && lastName != "" {
+			if firstName != "" && lastName != "" {
 				computedName = firstName + " " + lastName
 			} else if firstName != "" {
 				computedName = firstName
+			} else if displayName != "" {
+				computedName = displayName
+			}
+
+			// Generate display name if API didn't provide one
+			if displayName == "" {
+				displayName = generateDisplayName(firstName, lastName, computedName)
 			}
 
 			// Parse birthdate if available
@@ -309,6 +314,11 @@ func (h *AuthHandler) findOrCreateUser(ctx context.Context, claims *BrunstadTVCl
 		firstName = claims.FirstName
 	}
 
+	// Ensure display name is set (fallback case when API wasn't available)
+	if displayName == "" {
+		displayName = generateDisplayName(firstName, lastName, computedName)
+	}
+
 	// Normalize gender to match database constraint (MALE, FEMALE)
 	gender := normalizeGender(claims.Gender)
 
@@ -408,3 +418,12 @@ func normalizeGender(gender string) string {
 	}
 	return "UNKNOWN"
 }
+
+// generateDisplayName creates a display name in the format "FirstName L." if both names are provided,
+// otherwise returns the fallback name
+func generateDisplayName(firstName, lastName, fallbackName string) string {
+	if firstName != "" && lastName != "" {
+		return firstName + " " + string([]rune(lastName)[0]) + "."
+	}
+	return fallbackName
+}