Skip to content

Commit eb5abe8

Browse files
KillerXKillerX
committed
Fix tests
1 parent ac9a785 commit eb5abe8

File tree

2 files changed

+34
-30
lines changed

2 files changed

+34
-30
lines changed

‎backend/internal/loaders/achievement_by_id_test.go‎

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ import (
1010
"github.com/stretchr/testify/require"
1111
)
1212

13+
func stringPtr(s string) *string {
14+
return &s
15+
}
16+
1317
func TestAchievementCacheKey(t *testing.T) {
1418
achievementID := "AC01K8XV6VK9ED2GBZSQ2VDTAT8T"
1519
cacheKey := cache.AchievementKey(achievementID)
@@ -28,7 +32,7 @@ func TestAchievementCacheBehavior(t *testing.T) {
2832
ID: achievementID,
2933
Name: "Test Achievement",
3034
Description: "Test description",
31-
Image: "https://example.com/image.png",
35+
Image: stringPtr("https://example.com/image.png"),
3236
Points: 100,
3337
Hidden: false,
3438
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -63,7 +67,7 @@ func TestAchievementCacheExpiry(t *testing.T) {
6367
ID: achievementID,
6468
Name: "Test Achievement",
6569
Description: "Test description",
66-
Image: "https://example.com/image.png",
70+
Image: stringPtr("https://example.com/image.png"),
6771
Points: 100,
6872
Hidden: false,
6973
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -88,7 +92,7 @@ func TestSimpleAchievementModel(t *testing.T) {
8892
ID: "AC01K8XV6VK9ED2GBZSQ2VDTAT8T",
8993
Name: "First Achievement",
9094
Description: "Complete your first challenge",
91-
Image: "https://example.com/achievement.png",
95+
Image: stringPtr("https://example.com/achievement.png"),
9296
Points: 50,
9397
Hidden: false,
9498
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -107,21 +111,21 @@ func TestReadingAchievementModel(t *testing.T) {
107111
ID: "RA01K8XV6VK9ED2GBZSQ2VDTAT8T",
108112
Title: "Article 1",
109113
Author: "John Doe",
110-
URL: "https://example.com/article1",
114+
URL: stringPtr("https://example.com/article1"),
111115
},
112116
{
113117
ID: "RA01K8XV6VK9ED2GBZSQ2VDTAT9T",
114118
Title: "Article 2",
115119
Author: "Jane Smith",
116-
URL: "https://example.com/article2",
120+
URL: stringPtr("https://example.com/article2"),
117121
},
118122
}
119123

120124
achievement := &model.ReadingAchievement{
121125
ID: "AC01K8XV6VK9ED2GBZSQ2VDTAT8T",
122126
Name: "Reading Achievement",
123127
Description: "Read all required articles",
124-
Image: "https://example.com/reading.png",
128+
Image: stringPtr("https://example.com/reading.png"),
125129
Points: 100,
126130
Hidden: false,
127131
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -142,21 +146,21 @@ func TestListeningAchievementModel(t *testing.T) {
142146
ID: "LT01K8XV6VK9ED2GBZSQ2VDTAT8T",
143147
Name: "Track 1",
144148
Description: "First track description",
145-
Image: "https://example.com/track1.jpg",
149+
Image: stringPtr("https://example.com/track1.jpg"),
146150
},
147151
{
148152
ID: "LT01K8XV6VK9ED2GBZSQ2VDTAT9T",
149153
Name: "Track 2",
150154
Description: "Second track description",
151-
Image: "https://example.com/track2.jpg",
155+
Image: stringPtr("https://example.com/track2.jpg"),
152156
},
153157
}
154158

155159
achievement := &model.ListeningAchievement{
156160
ID: "AC01K8XV6VK9ED2GBZSQ2VDTAT8T",
157161
Name: "Listening Achievement",
158162
Description: "Listen to all required tracks",
159-
Image: "https://example.com/listening.png",
163+
Image: stringPtr("https://example.com/listening.png"),
160164
Points: 150,
161165
Hidden: false,
162166
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -176,7 +180,7 @@ func TestStreakAchievementModel(t *testing.T) {
176180
ID: "AC01K8XV6VK9ED2GBZSQ2VDTAT8T",
177181
Name: "Streak Achievement",
178182
Description: "Maintain a 7-day streak",
179-
Image: "https://example.com/streak.png",
183+
Image: stringPtr("https://example.com/streak.png"),
180184
Points: 200,
181185
Hidden: false,
182186
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -200,7 +204,7 @@ func TestMultipleAchievementsInCache(t *testing.T) {
200204
ID: "AC01K8XV6VK9ED2GBZSQ2VDTAT8T",
201205
Name: "Simple Achievement",
202206
Description: "First achievement",
203-
Image: "https://example.com/1.png",
207+
Image: stringPtr("https://example.com/1.png"),
204208
Points: 50,
205209
Hidden: false,
206210
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -209,7 +213,7 @@ func TestMultipleAchievementsInCache(t *testing.T) {
209213
ID: "AC01K8XV6VK9ED2GBZSQ2VDTAT9T",
210214
Name: "Reading Achievement",
211215
Description: "Second achievement",
212-
Image: "https://example.com/2.png",
216+
Image: stringPtr("https://example.com/2.png"),
213217
Points: 100,
214218
Hidden: false,
215219
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -220,7 +224,7 @@ func TestMultipleAchievementsInCache(t *testing.T) {
220224
ID: "AC01K8XV6VK9ED2GBZSQ2VDTATZZ",
221225
Name: "Listening Achievement",
222226
Description: "Third achievement",
223-
Image: "https://example.com/3.png",
227+
Image: stringPtr("https://example.com/3.png"),
224228
Points: 150,
225229
Hidden: false,
226230
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
@@ -253,7 +257,7 @@ func TestHiddenAchievement(t *testing.T) {
253257
ID: "AC01K8XV6VK9ED2GBZSQ2VDTAT8T",
254258
Name: "Secret Achievement",
255259
Description: "Hidden achievement",
256-
Image: "https://example.com/secret.png",
260+
Image: stringPtr("https://example.com/secret.png"),
257261
Points: 500,
258262
Hidden: true,
259263
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",

‎backend/internal/loaders/challenge_by_id_test.go‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ func TestChallengeCacheBehavior(t *testing.T) {
3232
ID: challengeID,
3333
Name: "Test Challenge",
3434
Description: scalars.HTML("Test description"),
35-
Image: "https://example.com/image.png",
35+
Image: stringPtr("https://example.com/image.png"),
3636
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
3737
EventID: nil,
38-
URL: "https://example.com/challenge",
38+
URL: stringPtr("https://example.com/challenge"),
3939
ButtonText: "Start Challenge",
4040
PublishedAt: scalars.DateTime{Time: publishedAt},
4141
EndTime: &scalars.DateTime{Time: endTime},
@@ -57,7 +57,7 @@ func TestChallengeCacheBehavior(t *testing.T) {
5757
assert.Equal(t, challengeID, cachedChallenge.ID)
5858
assert.Equal(t, "Test Challenge", cachedChallenge.Name)
5959
assert.Equal(t, scalars.HTML("Test description"), cachedChallenge.Description)
60-
assert.Equal(t, "https://example.com/challenge", cachedChallenge.URL)
60+
assert.Equal(t, "https://example.com/challenge", *cachedChallenge.URL)
6161
assert.Equal(t, "Start Challenge", cachedChallenge.ButtonText)
6262
assert.NotNil(t, cachedChallenge.EndTime)
6363
}
@@ -74,9 +74,9 @@ func TestChallengeCacheExpiry(t *testing.T) {
7474
ID: challengeID,
7575
Name: "Test Challenge",
7676
Description: scalars.HTML("Test description"),
77-
Image: "https://example.com/image.png",
77+
Image: stringPtr("https://example.com/image.png"),
7878
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
79-
URL: "https://example.com/challenge",
79+
URL: stringPtr("https://example.com/challenge"),
8080
ButtonText: "Start Challenge",
8181
PublishedAt: scalars.DateTime{Time: publishedAt},
8282
}
@@ -104,10 +104,10 @@ func TestChallengeModel(t *testing.T) {
104104
ID: "CL01K8XV6VK9ED2GBZSQ2VDTAT8T",
105105
Name: "Daily Bible Reading",
106106
Description: scalars.HTML("<p>Read the daily passage</p>"),
107-
Image: "https://example.com/bible.png",
107+
Image: stringPtr("https://example.com/bible.png"),
108108
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
109109
EventID: &eventID,
110-
URL: "https://example.com/bible-reading",
110+
URL: stringPtr("https://example.com/bible-reading"),
111111
ButtonText: "Read Now",
112112
PublishedAt: scalars.DateTime{Time: publishedAt},
113113
EndTime: &scalars.DateTime{Time: endTime},
@@ -116,7 +116,7 @@ func TestChallengeModel(t *testing.T) {
116116
assert.Equal(t, "CL01K8XV6VK9ED2GBZSQ2VDTAT8T", challenge.ID)
117117
assert.Equal(t, "Daily Bible Reading", challenge.Name)
118118
assert.Equal(t, scalars.HTML("<p>Read the daily passage</p>"), challenge.Description)
119-
assert.Equal(t, "https://example.com/bible-reading", challenge.URL)
119+
assert.Equal(t, "https://example.com/bible-reading", *challenge.URL)
120120
assert.Equal(t, "Read Now", challenge.ButtonText)
121121
assert.NotNil(t, challenge.EventID)
122122
assert.Equal(t, "EV01K8XV6VK9ED2GBZSQ2VDTAT8T", *challenge.EventID)
@@ -130,10 +130,10 @@ func TestChallengeModelWithoutEndTime(t *testing.T) {
130130
ID: "CL01K8XV6VK9ED2GBZSQ2VDTAT8T",
131131
Name: "Ongoing Challenge",
132132
Description: scalars.HTML("Challenge with no end time"),
133-
Image: "https://example.com/ongoing.png",
133+
Image: stringPtr("https://example.com/ongoing.png"),
134134
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
135135
EventID: nil,
136-
URL: "https://example.com/ongoing",
136+
URL: stringPtr("https://example.com/ongoing"),
137137
ButtonText: "Participate",
138138
PublishedAt: scalars.DateTime{Time: publishedAt},
139139
EndTime: nil,
@@ -157,9 +157,9 @@ func TestMultipleChallengesInCache(t *testing.T) {
157157
ID: "CL01K8XV6VK9ED2GBZSQ2VDTAT8T",
158158
Name: "Challenge 1",
159159
Description: scalars.HTML("First challenge"),
160-
Image: "https://example.com/1.png",
160+
Image: stringPtr("https://example.com/1.png"),
161161
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
162-
URL: "https://example.com/challenge1",
162+
URL: stringPtr("https://example.com/challenge1"),
163163
ButtonText: "Start",
164164
PublishedAt: scalars.DateTime{Time: publishedAt},
165165
EndTime: &scalars.DateTime{Time: endTime},
@@ -168,9 +168,9 @@ func TestMultipleChallengesInCache(t *testing.T) {
168168
ID: "CL01K8XV6VK9ED2GBZSQ2VDTAT9T",
169169
Name: "Challenge 2",
170170
Description: scalars.HTML("Second challenge"),
171-
Image: "https://example.com/2.png",
171+
Image: stringPtr("https://example.com/2.png"),
172172
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
173-
URL: "https://example.com/challenge2",
173+
URL: stringPtr("https://example.com/challenge2"),
174174
ButtonText: "Begin",
175175
PublishedAt: scalars.DateTime{Time: publishedAt},
176176
EndTime: nil,
@@ -179,9 +179,9 @@ func TestMultipleChallengesInCache(t *testing.T) {
179179
ID: "CL01K8XV6VK9ED2GBZSQ2VDTATZZ",
180180
Name: "Challenge 3",
181181
Description: scalars.HTML("Third challenge"),
182-
Image: "https://example.com/3.png",
182+
Image: stringPtr("https://example.com/3.png"),
183183
ProjectID: "PR01K8XV6J9H7BAEV49ZFVYS8R1K",
184-
URL: "https://example.com/challenge3",
184+
URL: stringPtr("https://example.com/challenge3"),
185185
ButtonText: "Go",
186186
PublishedAt: scalars.DateTime{Time: publishedAt},
187187
EndTime: &scalars.DateTime{Time: endTime},

0 commit comments

Comments
 (0)