remove shell lint with shellcheck

Author: bcdady

bin/awscli.sh

@@ -4,9 +4,9 @@
 # https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-mac.html#cliv2-mac-install-cmd
 # see also https://formulae.brew.sh/formula/awscli#default
 
-curl "https://awscli.amazonaws.com/AWSCLIV2.pkg" -o "AWSCLIV2.pkg"
-sudo installer -pkg AWSCLIV2.pkg -target /
+curl "https://awscli.amazonaws.com/AWSCLIV2.pkg" -o "AWSCLIv2.pkg"
+sudo installer -pkg AWSCLIv2.pkg -target /
 
 # Verify the installation
-which aws
+command -v aws
 aws --version

bin/megalinter-local.sh

@@ -7,45 +7,45 @@ FLAVOR="terraform" # check that this matches the flavor specified in .gitlab-ci.
 
 # detect if node.js is installed
 NODE_VERSION=$(node --version)
-if [ "X$NODE_VERSION" = "X" ]; then
-    echo "ERROR: node.js is required, but was not found installed."
-    echo "       Consider installing via 'brew install node'."
-    exit 13
+if [[ "X${NODE_VERSION}" = "X" ]]; then
+  echo "ERROR: node.js is required, but was not found installed."
+  echo "       Consider installing via 'brew install node'."
+  exit 13
 else
-    echo "Confirmed node $NODE_VERSION is available."
+  echo "Confirmed node ${NODE_VERSION} is available."
 fi
 
 # detect if docker is installed and running
 DOCKER_VERSION=$(docker --version)
-if [ "X$DOCKER_VERSION" = "X" ]; then
-    echo "ERROR: Docker is required, but was not found installed."
-    echo "       Consider installing via 'brew install docker'."
-    exit 23
+if [[ "X${DOCKER_VERSION}" = "X" ]]; then
+  echo "ERROR: Docker is required, but was not found installed."
+  echo "       Consider installing via 'brew install docker'."
+  exit 23
 else
-    DOCKER_RUNNING=$(pgrep -f Docker.app)
-    if [ "X$DOCKER_RUNNING" = "X" ]; then
-        echo "WARNING: Docker is installed, but was not found running."
-        echo "         Starting Docker (open -a 'Docker Desktop')"
-        open -a 'Docker Desktop'
-        sleep 12
-        # exit 29
-    else
-        echo "Confirmed $DOCKER_VERSION is running."
-    fi
+  DOCKER_RUNNING=$(pgrep -f Docker.app)
+  if [[ "X${DOCKER_RUNNING}" = "X" ]]; then
+    echo "WARNING: Docker is installed, but was not found running."
+    echo "         Starting Docker (open -a 'Docker Desktop')"
+    open -a 'Docker Desktop'
+    sleep 12
+    # exit 29
+  else
+    echo "Confirmed ${DOCKER_VERSION} is running."
+  fi
 fi
 
 # Run mega-linter -- in config setup mode, if needed
-if [ -f ".mega-linter.yml" ]; then
-    echo "Loading config from .mega-linter.yml ..."
-    echo ""
-    npx mega-linter-runner --flavor $FLAVOR \
-        -e 'LOG_LEVEL=INFO'
+if [[ -f ".mega-linter.yml" ]]; then
+  echo "Loading config from .mega-linter.yml ..."
+  echo ""
+  npx mega-linter-runner --flavor "${FLAVOR}" \
+    -e 'LOG_LEVEL=INFO'
 else
-    echo ""
-    echo "Setting up .mega-linter.yml."
-    npx mega-linter-runner --install
-    echo ""
-    echo "Done."
-    echo "    Run this script again to invoke mega-linter with these new settings."
-    echo ""
+  echo ""
+  echo "Setting up .mega-linter.yml."
+  npx mega-linter-runner --install
+  echo ""
+  echo "Done."
+  echo "    Run this script again to invoke mega-linter with these new settings."
+  echo ""
 fi

bin/setup-megalinter.sh

@@ -13,7 +13,7 @@ UNAME="$(uname -s)"
 
 if ! [[ ${UNAME} =~ "Darwin" ]]; then
   # Confirm or install dependencies as necessary
-  echo "Error: This script is intended for MacOS, but was found to be running on $UNAME"
+  echo "Error: This script is intended for MacOS, but was found to be running on ${UNAME}"
   exit
 fi
 

gitlab/gitlab-bulk-import.sh

@@ -11,20 +11,27 @@
 API_URI='https://subsplash.io/api/v4'
 WEB_URI='https://subsplash.io'
 
+# Organization or Username for the source repository
+# Used in the SOURCE_URL and REF_URL
+SOURCE_ORG='snappages'
+
 # Check for a valid GitLab Personal Access Token to authenticate / authorize API calls
 if [[ -z ${GITLAB_TOKEN} ]]; then
+  # shellcheck disable=SC2016
   echo 'Error: No $GITLAB_TOKEN was found.'
   exit
 fi
 
 # Check for valid credentials to source system; these variables are used later
 if [[ -z ${GITHUB_USER} ]]; then
+  # shellcheck disable=SC2016
   echo 'Error: $GITHUB_USER was Not found.'
   echo "If authentication is not required for this source SCM, edit this script and try again."
   exit
 fi
 
 if [[ -z ${GITHUB_TOKEN} ]]; then
+  # shellcheck disable=SC2016
   echo 'Error: $GITHUB_TOKEN was Not found.'
   echo "If authentication is not required for this source SCM, edit this script and try again."
   exit
@@ -44,29 +51,29 @@ GROUP_ID=233
 # Source project URL
 # Note: include https auth in SOURCE_URL if necessary (otherwise, forego "<USERNAME>:<PASSWORD>@")
 # Example: https://<USERNAME>:<PASSWORD>@github.com/path/to/repo.git
-SOURCE_URL="https://${GITHUB_USER}:${GITHUB_TOKEN}@github.com/snappages/"
-# SOURCE_URL="https://github.com/snappages/"
+SOURCE_URL="https://${GITHUB_USER}:${GITHUB_TOKEN}@github.com/${SOURCE_ORG}/"
+# SOURCE_URL="https://github.com/${SOURCE_ORG}/"
 
 # Project Description
 # The REF_URL should match the SOURCE_URL, without any user or token, so it can be included in
 # the target project description. See `--form description="Cloned from ${REF_URL}${REPO}" \`
-REF_URL="https://github.com/snappages/"
+REF_URL="https://github.com/${SOURCE_ORG}/"
 
 # space-delimited list of repositories available from the SOURCE_URL
-REPOLIST="${@}"
+REPOLIST=( "${@}" )
 
-for REPO in ${REPOLIST}; do
+for REPO in "${REPOLIST[@]}"; do
 
   echo "Cloning git repository ${REPO} to ${WEB_URI}/projects/${REPO}/"
 
   IMPORT=$(curl --request POST \
-    --url $API_URI/projects \
+    --url "${API_URI}"/projects \
     --header 'Content-Type: multipart/form-data;' \
     --header "Authorization: Bearer ${GITLAB_TOKEN}" \
     --form description="Cloned from ${REF_URL}${REPO}" \
     --form import_url="${SOURCE_URL}${REPO}.git" \
-    --form mirror=${MIRROR} \
-    --form namespace_id=${GROUP_ID} \
+    --form mirror="${MIRROR}" \
+    --form namespace_id="${GROUP_ID}" \
     --form path="${REPO}" \
     --form allow_merge_on_skipped_pipeline=false \
     --form analytics_access_level=disabled \
@@ -97,7 +104,7 @@ for REPO in ${REPOLIST}; do
 
   # access properties in JSON structure of $IMPORT results
   echo ""
-  echo "Cloned project to $(echo ${IMPORT} | jq '.web_url')"
+  echo "Cloned project to $(echo "${IMPORT}" | jq '.web_url')"
   ID=$(echo "${IMPORT}" | jq '.id')
 
   # pause for a moment, before trying to archive the newly imported project
@@ -126,9 +133,9 @@ exit
 
 # GitHub API notes:
 # List repositories for an Org
-curl https://$GITHUB_USER:$GITHUB_TOKEN@api.github.com/orgs/snappages/repos | jq '.[].name'
+# curl https://"${GITHUB_USER}":"${GITHUB_TOKEN}"@api.github.com/orgs/${SOURCE_ORG}/repos | jq '.[].name'
 
-curl https://$GITHUB_USER:$GITHUB_TOKEN@api.github.com/snappages/
-curl -I https://api.github.com/users/octocat/orgs
+# curl https://"${GITHUB_USER}":"${GITHUB_TOKEN}"@api.github.com/${SOURCE_ORG}/
+# curl -I https://api.github.com/users/octocat/orgs
 
-curl -H "Authorization: token OAUTH-TOKEN" https://api.github.com
+# curl -H "Authorization: token OAUTH-TOKEN" https://api.github.com

gitlab/gitlab-proj-runner-settings.sh

@@ -19,7 +19,7 @@
 API_URI='https://subsplash.io/api/v4'
 WEB_URI='https://subsplash.io'
 
-if [[ -z $@ ]]; then
+if [[ -z "$@" ]]; then
   echo ''
   echo "Error: No Project was specified."
   echo ''
@@ -34,7 +34,8 @@ if [[ -z $@ ]]; then
 fi
 
 # Check for a valid GitLab Personal Access Token to authenticate / authorize API calls
-if [[ -z $GITLAB_TOKEN ]]; then
+if [[ -z ${GITLAB_TOKEN} ]]; then
+  # shellcheck disable=SC2016
   echo 'Error: No $GITLAB_TOKEN was found.'
   exit
 fi
@@ -48,16 +49,16 @@ fi
 # space-delimited list of projects to apply the settings to
 # Can be a numerical Project ID or a URL-encoded URI
 # https://docs.gitlab.com/ee/api/README.html#namespaced-path-encoding
-PROJLIST=$@
+PROJLIST=( "${@}" )
 
-for PROJ in $PROJLIST; do
+for PROJ in "${PROJLIST[@]}"; do
 
   echo ''
   echo "Updating CI Runner settings for ${WEB_URI}/projects/${PROJ}/"
   echo ''
 
   curl --silent --request GET \
-    --header "Authorization: Bearer $GITLAB_TOKEN" \
+    --header "Authorization: Bearer ${GITLAB_TOKEN}" \
     "${API_URI}/projects/${PROJ}/runners" #\
   # | jq '. | {id,name,description,web_url}'
 
@@ -95,6 +96,7 @@ for PROJ in $PROJLIST; do
   # | jq '. | {id,web_url}'
 
 done
+
 exit
 
 # Scratchpad area of other, related, possibly useful gitlab API samples

gitlab/gitlab-project-settings.sh

@@ -21,6 +21,7 @@ WEB_URI='https://subsplash.io'
 
 # Check for a valid GitLab Personal Access Token to authenticate / authorize API calls
 if [[ -z ${GITLAB_TOKEN} ]]; then
+  # shellcheck disable=SC2016
   echo 'Error: No $GITLAB_TOKEN was found.'
   exit
 fi
@@ -34,25 +35,25 @@ fi
 # space-delimited list of projects to apply the settings to
 # Can be a numerical Project ID or a URL-encoded URI
 # https://docs.gitlab.com/ee/api/README.html#namespaced-path-encoding
-PROJLIST=$@
+PROJLIST=( "${@}" )
 
-for PROJ in ${PROJLIST}; do
+for PROJ in "${PROJLIST[@]}"; do
 
   echo ''
   echo "Updating settings for ${WEB_URI}/projects/${PROJ}/"
   echo ''
 
   # RFE / TODO: get current Description. If blank, parse README for Description text
   curl --silent --request GET \
-    --header "Authorization: Bearer $GITLAB_TOKEN" \
+    --header "Authorization: Bearer ${GITLAB_TOKEN}" \
     "${API_URI}/projects/${PROJ}" |
     jq '. | {id,name,description,web_url}'
 
   # Project settings are specified in form entries on their own line
   # Sorted in alphabetical order
   curl --silent --request PUT "${API_URI}/projects/${PROJ}" \
     --header 'Content-Type: multipart/form-data;' \
-    --header "Authorization: Bearer $GITLAB_TOKEN" \
+    --header "Authorization: Bearer ${GITLAB_TOKEN}" \
     --form allow_merge_on_skipped_pipeline=false \
     --form analytics_access_level=disabled \
     --form approvals_before_merge=1 \
@@ -91,7 +92,7 @@ for PROJ in ${PROJLIST}; do
   # 40 => Maintainer access
   # 60 => Admin access
   curl --silent --request POST \
-    --header "Authorization: Bearer $GITLAB_TOKEN" \
+    --header "Authorization: Bearer ${GITLAB_TOKEN}" \
     "${API_URI}/projects/${PROJ}/protected_branches/?name=main&push_access_level=60&merge_access_level=30&unprotect_access_level=60&code_owner_approval_required=true" |
     jq '. | {message}'
 
@@ -101,7 +102,7 @@ for PROJ in ${PROJLIST}; do
   # https://docs.gitlab.com/ee/api/merge_request_approvals.html
   # approvals_before_merge is set above for the project
   curl --silent --request POST \
-    --header "Authorization: Bearer $GITLAB_TOKEN" \
+    --header "Authorization: Bearer ${GITLAB_TOKEN}" \
     "${API_URI}/projects/${PROJ}/approvals?merge_requests_author_approval=true&reset_approvals_on_push=true" |
     jq '. | {approvals_before_merge}'
 

gitlab/gitlab-stats-analyze.sh

@@ -1,19 +1,19 @@
 #!/usr/bin/env bash
 
-cd ~/repo/GitStats
+cd ~/repo/GitStats || exit
 
 #for file in $(find ./3p -name "*.csv"); do echo $file; done
 
 for DIR in $(ls -d *); do
-  printf "INFO: Working in $DIR ...\n"
+    printf "INFO: Working in %S ...\n" "${DIR}"
 
-  find $DIR -name "*.csv"
-  for file in $(find $DIR -name "*.csv"); do
-    echo "cat file: $file"
-    cat $file >>GitLab_stats.txt
-  done
-  # echo "break"
-  # break
+    find $DIR -mtime -7 -name '*.csv' -print0 | while IFS= read -r -d '' file
+    for file in $(find $DIR -name "*.csv"); do
+        echo "cat file: $file"
+        cat $file >> GitLab_stats.txt
+    done
+    # echo "break"
+    # break
 done
 
 exit 0