Skip to content

Commit 4b8c891

Browse files
committed
escaping names - again
1 parent 0a25b39 commit 4b8c891

File tree

11 files changed

+68
-154
lines changed

11 files changed

+68
-154
lines changed

core/src/test/java/com/bc/fiduceo/util/NetCDFUtilsTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,12 @@ public void testGetVariable_writer_variableNotPresent() {
424424
}
425425
}
426426

427+
@Test
428+
public void testEscapeVariableName() {
429+
assertEquals("hansematz", NetCDFUtils.escapeVariableName("hansematz"));
430+
assertEquals("hans\\.ematz", NetCDFUtils.escapeVariableName("hans.ematz"));
431+
}
432+
427433
@Test
428434
public void testGetAttributeInt_attributeValue() {
429435
final Attribute attribute = mock(Attribute.class);

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/MatchupFields.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ void compute(Configuration config, NetcdfFile reader, NetcdfFileWriter writer) t
141141
}
142142

143143
final TemplateVariable templateVariable = variables.get(variableKey);
144-
final Variable targetVariable = writer.findVariable(templateVariable.getName());
144+
final Variable targetVariable = writer.findVariable(NetCDFUtils.escapeVariableName(templateVariable.getName()));
145145
writer.write(targetVariable, targetArray);
146146
}
147147
} finally {
@@ -151,8 +151,8 @@ void compute(Configuration config, NetcdfFile reader, NetcdfFileWriter writer) t
151151

152152
private void addTimeVariable(MatchupFieldsConfiguration matchupFieldsConfig, List<Dimension> dimensions, NetcdfFileWriter writer) {
153153
final String timeVariableName = matchupFieldsConfig.get_nwp_time_variable_name();
154-
final String escapedName = NetCDFUtils.escapeVariableName(timeVariableName);
155-
final Variable variable = writer.addVariable(escapedName, DataType.INT, dimensions);
154+
// final String escapedName = NetCDFUtils.escapeVariableName(timeVariableName);
155+
final Variable variable = writer.addVariable(timeVariableName, DataType.INT, dimensions);
156156
variable.addAttribute(new Attribute("description", "Timestamp of ERA-5 data"));
157157
variable.addAttribute(new Attribute("units", "seconds since 1970-01-01"));
158158
variable.addAttribute(new Attribute("_FillValue", NetCDFUtils.getDefaultFillValue(DataType.INT, false)));

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/MatchupFieldsConfiguration.java

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.bc.fiduceo.post.plugin.era5;
22

3-
import com.bc.fiduceo.util.NetCDFUtils;
43
import org.esa.snap.core.util.StringUtils;
54

65
class MatchupFieldsConfiguration {
@@ -50,79 +49,79 @@ String get_an_u10_name() {
5049
}
5150

5251
void set_an_u10_name(String an_u10_name) {
53-
this.an_u10_name = NetCDFUtils.escapeVariableName(an_u10_name);
52+
this.an_u10_name = an_u10_name;
5453
}
5554

5655
String get_an_v10_name() {
5756
return an_v10_name;
5857
}
5958

6059
void set_an_v10_name(String an_v10_name) {
61-
this.an_v10_name = NetCDFUtils.escapeVariableName(an_v10_name);
60+
this.an_v10_name = an_v10_name;
6261
}
6362

6463
String get_an_siconc_name() {
6564
return an_siconc_name;
6665
}
6766

6867
void set_an_siconc_name(String an_siconc_name) {
69-
this.an_siconc_name = NetCDFUtils.escapeVariableName(an_siconc_name);
68+
this.an_siconc_name = an_siconc_name;
7069
}
7170

7271
String get_an_sst_name() {
7372
return an_sst_name;
7473
}
7574

7675
void set_an_sst_name(String an_sst_name) {
77-
this.an_sst_name = NetCDFUtils.escapeVariableName(an_sst_name);
76+
this.an_sst_name = an_sst_name;
7877
}
7978

8079
String get_fc_metss_name() {
8180
return fc_metss_name;
8281
}
8382

8483
void set_fc_metss_name(String fc_metss_name) {
85-
this.fc_metss_name = NetCDFUtils.escapeVariableName(fc_metss_name);
84+
this.fc_metss_name = fc_metss_name;
8685
}
8786

8887
String get_fc_mntss_name() {
8988
return fc_mntss_name;
9089
}
9190

9291
void set_fc_mntss_name(String fc_mntss_name) {
93-
this.fc_mntss_name = NetCDFUtils.escapeVariableName(fc_mntss_name);
92+
this.fc_mntss_name = fc_mntss_name;
9493
}
9594

9695
String get_fc_mslhf_name() {
9796
return fc_mslhf_name;
9897
}
9998

10099
void set_fc_mslhf_name(String fc_mslhf_name) {
101-
this.fc_mslhf_name = NetCDFUtils.escapeVariableName(fc_mslhf_name);
100+
this.fc_mslhf_name = fc_mslhf_name;
102101
}
103102

104103
String get_fc_msnlwrf_name() {
105104
return fc_msnlwrf_name;
106105
}
107106

108107
void set_fc_msnlwrf_name(String fc_msnlwrf_name) {
109-
this.fc_msnlwrf_name = NetCDFUtils.escapeVariableName(fc_msnlwrf_name);
108+
this.fc_msnlwrf_name = fc_msnlwrf_name;
110109
}
111110

112111
String get_fc_msnswrf_name() {
113112
return fc_msnswrf_name;
114113
}
115114

116115
void set_fc_msnswrf_name(String fc_msnswrf_name) {
117-
this.fc_msnswrf_name = NetCDFUtils.escapeVariableName(fc_msnswrf_name);
116+
this.fc_msnswrf_name = fc_msnswrf_name;
118117
}
119118

120119
String get_fc_msshf_name() {
121120
return fc_msshf_name;
122121
}
123122

124123
void set_fc_msshf_name(String fc_msshf_name) {
125-
this.fc_msshf_name = NetCDFUtils.escapeVariableName(fc_msshf_name);
124+
this.fc_msshf_name = fc_msshf_name;
126125
}
127126

128127
int get_time_steps_past() {
@@ -146,39 +145,39 @@ String get_time_dim_name() {
146145
}
147146

148147
void set_time_dim_name(String time_dim_name) {
149-
this.time_dim_name = NetCDFUtils.escapeVariableName(time_dim_name);
148+
this.time_dim_name = time_dim_name;
150149
}
151150

152151
String get_time_variable_name() {
153152
return time_variable_name;
154153
}
155154

156155
void set_time_variable_name(String time_variable_name) {
157-
this.time_variable_name = NetCDFUtils.escapeVariableName(time_variable_name);
156+
this.time_variable_name = time_variable_name;
158157
}
159158

160159
String get_longitude_variable_name() {
161160
return longitude_variable_name;
162161
}
163162

164163
void set_longitude_variable_name(String longitude_variable_name) {
165-
this.longitude_variable_name = NetCDFUtils.escapeVariableName(longitude_variable_name);
164+
this.longitude_variable_name = longitude_variable_name;
166165
}
167166

168167
String get_latitude_variable_name() {
169168
return latitude_variable_name;
170169
}
171170

172171
void set_latitude_variable_name(String latitude_variable_name) {
173-
this.latitude_variable_name = NetCDFUtils.escapeVariableName(latitude_variable_name);
172+
this.latitude_variable_name = latitude_variable_name;
174173
}
175174

176175
String get_nwp_time_variable_name() {
177176
return nwp_time_variable_name;
178177
}
179178

180179
void set_nwp_time_variable_name(String nwp_time_variable_name) {
181-
this.nwp_time_variable_name = NetCDFUtils.escapeVariableName(nwp_time_variable_name);
180+
this.nwp_time_variable_name = nwp_time_variable_name;
182181
}
183182

184183
boolean verify() {

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/SatelliteFields.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ void compute(Configuration config, NetcdfFile reader, NetcdfFileWriter writer) t
191191
// + write to MMD
192192
final Array timeArray = VariableUtils.readTimeArray(satFieldsConfig.get_time_variable_name(), reader);
193193
final Array era5TimeArray = convertToEra5TimeStamp(timeArray);
194-
writer.write(satFieldsConfig.get_nwp_time_variable_name(), era5TimeArray);
194+
final Variable targetTimeVariable = NetCDFUtils.getVariable(writer, satFieldsConfig.get_nwp_time_variable_name());
195+
writer.write(targetTimeVariable, era5TimeArray);
195196

196197
// open longitude and latitude input variables
197198
// + read completely or specified x/y subset
@@ -302,7 +303,7 @@ void compute(Configuration config, NetcdfFile reader, NetcdfFileWriter writer) t
302303
}
303304

304305
final TemplateVariable templateVariable = variables.get(variableKey);
305-
final Variable targetVariable = writer.findVariable(templateVariable.getName());
306+
final Variable targetVariable = writer.findVariable(NetCDFUtils.escapeVariableName(templateVariable.getName()));
306307
writer.write(targetVariable, targetArray);
307308
}
308309
}
@@ -313,8 +314,7 @@ void compute(Configuration config, NetcdfFile reader, NetcdfFileWriter writer) t
313314

314315
private void addTimeVariable(SatelliteFieldsConfiguration satFieldsConfig, NetcdfFileWriter writer) {
315316
final String nwp_time_variable_name = satFieldsConfig.get_nwp_time_variable_name();
316-
final String escapedName = NetCDFUtils.escapeVariableName(nwp_time_variable_name);
317-
final Variable variable = writer.addVariable(escapedName, DataType.INT, FiduceoConstants.MATCHUP_COUNT);
317+
final Variable variable = writer.addVariable(nwp_time_variable_name, DataType.INT, FiduceoConstants.MATCHUP_COUNT);
318318
variable.addAttribute(new Attribute("description", "Timestamp of ERA-5 data"));
319319
variable.addAttribute(new Attribute("units", "seconds since 1970-01-01"));
320320
variable.addAttribute(new Attribute("_FillValue", NetCDFUtils.getDefaultFillValue(DataType.INT, false)));

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/SatelliteFieldsConfiguration.java

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -56,103 +56,103 @@ String get_an_q_name() {
5656
}
5757

5858
void set_an_q_name(String an_q_name) {
59-
this.an_q_name = NetCDFUtils.escapeVariableName(an_q_name);
59+
this.an_q_name = an_q_name;
6060
}
6161

6262
String get_an_t_name() {
6363
return an_t_name;
6464
}
6565

6666
void set_an_t_name(String an_t_name) {
67-
this.an_t_name = NetCDFUtils.escapeVariableName(an_t_name);
67+
this.an_t_name = an_t_name;
6868
}
6969

7070
String get_an_o3_name() {
7171
return an_o3_name;
7272
}
7373

7474
void set_an_o3_name(String an_o3_name) {
75-
this.an_o3_name = NetCDFUtils.escapeVariableName(an_o3_name);
75+
this.an_o3_name = an_o3_name;
7676
}
7777

7878
String get_an_lnsp_name() {
7979
return an_lnsp_name;
8080
}
8181

8282
void set_an_lnsp_name(String an_lnsp_name) {
83-
this.an_lnsp_name = NetCDFUtils.escapeVariableName(an_lnsp_name);
83+
this.an_lnsp_name = an_lnsp_name;
8484
}
8585

8686
String get_an_t2m_name() {
8787
return an_t2m_name;
8888
}
8989

9090
void set_an_t2m_name(String an_t2m_name) {
91-
this.an_t2m_name = NetCDFUtils.escapeVariableName(an_t2m_name);
91+
this.an_t2m_name = an_t2m_name;
9292
}
9393

9494
String get_an_siconc_name() {
9595
return an_siconc_name;
9696
}
9797

9898
void set_an_siconc_name(String an_siconc_name) {
99-
this.an_siconc_name = NetCDFUtils.escapeVariableName(an_siconc_name);
99+
this.an_siconc_name = an_siconc_name;
100100
}
101101

102102
String get_an_u10_name() {
103103
return an_u10_name;
104104
}
105105

106106
void set_an_u10_name(String an_u10_name) {
107-
this.an_u10_name = NetCDFUtils.escapeVariableName(an_u10_name);
107+
this.an_u10_name = an_u10_name;
108108
}
109109

110110
String get_an_v10_name() {
111111
return an_v10_name;
112112
}
113113

114114
void set_an_v10_name(String an_v10_name) {
115-
this.an_v10_name = NetCDFUtils.escapeVariableName(an_v10_name);
115+
this.an_v10_name = an_v10_name;
116116
}
117117

118118
String get_an_msl_name() {
119119
return an_msl_name;
120120
}
121121

122122
void set_an_msl_name(String an_msl_name) {
123-
this.an_msl_name = NetCDFUtils.escapeVariableName(an_msl_name);
123+
this.an_msl_name = an_msl_name;
124124
}
125125

126126
String get_an_skt_name() {
127127
return an_skt_name;
128128
}
129129

130130
void set_an_skt_name(String an_skt_name) {
131-
this.an_skt_name = NetCDFUtils.escapeVariableName(an_skt_name);
131+
this.an_skt_name = an_skt_name;
132132
}
133133

134134
String get_an_sst_name() {
135135
return an_sst_name;
136136
}
137137

138138
void set_an_sst_name(String an_sst_name) {
139-
this.an_sst_name = NetCDFUtils.escapeVariableName(an_sst_name);
139+
this.an_sst_name = an_sst_name;
140140
}
141141

142142
String get_an_tcc_name() {
143143
return an_tcc_name;
144144
}
145145

146146
void set_an_tcc_name(String an_tcc_name) {
147-
this.an_tcc_name = NetCDFUtils.escapeVariableName(an_tcc_name);
147+
this.an_tcc_name = an_tcc_name;
148148
}
149149

150150
String get_an_tcwv_name() {
151151
return an_tcwv_name;
152152
}
153153

154154
void set_an_tcwv_name(String an_tcwv_name) {
155-
this.an_tcwv_name = NetCDFUtils.escapeVariableName(an_tcwv_name);
155+
this.an_tcwv_name = an_tcwv_name;
156156
}
157157

158158
int get_x_dim() {
@@ -184,55 +184,55 @@ String get_x_dim_name() {
184184
}
185185

186186
void set_x_dim_name(String x_dim_name) {
187-
this.x_dim_name = NetCDFUtils.escapeVariableName(x_dim_name);
187+
this.x_dim_name = x_dim_name;
188188
}
189189

190190
String get_y_dim_name() {
191191
return y_dim_name;
192192
}
193193

194194
void set_y_dim_name(String y_dim_name) {
195-
this.y_dim_name = NetCDFUtils.escapeVariableName(y_dim_name);
195+
this.y_dim_name = y_dim_name;
196196
}
197197

198198
String get_z_dim_name() {
199199
return z_dim_name;
200200
}
201201

202202
void set_z_dim_name(String z_dim_name) {
203-
this.z_dim_name = NetCDFUtils.escapeVariableName(z_dim_name);
203+
this.z_dim_name = z_dim_name;
204204
}
205205

206206
String get_nwp_time_variable_name() {
207207
return nwp_time_variable_name;
208208
}
209209

210210
void set_nwp_time_variable_name(String nwp_time_variable_name) {
211-
this.nwp_time_variable_name = NetCDFUtils.escapeVariableName(nwp_time_variable_name);
211+
this.nwp_time_variable_name =nwp_time_variable_name;
212212
}
213213

214214
String get_time_variable_name() {
215215
return time_variable_name;
216216
}
217217

218218
void set_time_variable_name(String time_variable_name) {
219-
this.time_variable_name = NetCDFUtils.escapeVariableName(time_variable_name);
219+
this.time_variable_name = time_variable_name;
220220
}
221221

222222
String get_longitude_variable_name() {
223223
return longitude_variable_name;
224224
}
225225

226226
void set_longitude_variable_name(String longitude_variable_name) {
227-
this.longitude_variable_name = NetCDFUtils.escapeVariableName(longitude_variable_name);
227+
this.longitude_variable_name = longitude_variable_name;
228228
}
229229

230230
String get_latitude_variable_name() {
231231
return latitude_variable_name;
232232
}
233233

234234
void set_latitude_variable_name(String latitude_variable_name) {
235-
this.latitude_variable_name = NetCDFUtils.escapeVariableName(latitude_variable_name);
235+
this.latitude_variable_name = latitude_variable_name;
236236
}
237237

238238

0 commit comments

Comments
 (0)