added support for emtpy values. added tests

Author: TomBlock

CHANGES.md

@@ -1,5 +1,7 @@
 ### Updates from version 1.5.7 to 1.5.8
 * added support for Windsat Coriolis data
+* added conda environment
+* extended workflow to run without scheduler on plain console
 
 ### Updates from version 1.5.6 to 1.5.7
 * added support for SMOS L1C daily aggregated products

core/src/main/java/com/bc/fiduceo/reader/insitu/sic_cci/AbstractSectionParser.java

@@ -56,7 +56,7 @@ static void createCommonVariables(List<Variable> variables, String prefix) {
 
     static Array parseFloat(String token) {
         final float floatVal;
-        if (token.equals("noval")) {
+        if (token.isEmpty() || token.equals("noval")) {
             floatVal = NetCDFUtils.getDefaultFillValue(float.class).floatValue();
         } else {
             floatVal = Float.parseFloat(token);
@@ -68,7 +68,7 @@ static Array parseFloat(String token) {
     static Array parseShort(String token) {
         final short shortVal;
 
-        if (token.equals("noval")) {
+        if (token.isEmpty() || token.equals("noval")) {
             shortVal = NetCDFUtils.getDefaultFillValue(short.class).shortValue();
         } else {
             shortVal = Short.parseShort(token);
@@ -77,8 +77,14 @@ static Array parseShort(String token) {
     }
 
     static Array parseByte(String token) {
-        final byte sic_total = Byte.parseByte(token);
-        return Array.factory(DataType.BYTE, SCALAR, new byte[]{sic_total});
+        final byte byteVal;
+        if (token.isEmpty() || token.equals("noval")) {
+            byteVal = NetCDFUtils.getDefaultFillValue(byte.class).byteValue();
+        } else {
+            byteVal = Byte.parseByte(token);
+        }
+
+        return Array.factory(DataType.BYTE, SCALAR, new byte[]{byteVal});
     }
 
     static Array parseUtcTime(String token) throws ParseException {

core/src/test/java/com/bc/fiduceo/reader/insitu/sic_cci/AbstractSectionParserTest.java

@@ -0,0 +1,32 @@
+package com.bc.fiduceo.reader.insitu.sic_cci;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class AbstractSectionParserTest {
+
+    @Test
+    public void testParseByte()  {
+        assertEquals(15, AbstractSectionParser.parseByte("15").getByte(0));
+
+        assertEquals(-127, AbstractSectionParser.parseByte("noval").getByte(0));
+        assertEquals(-127, AbstractSectionParser.parseByte("").getByte(0));
+    }
+
+    @Test
+    public void testParseShort()  {
+        assertEquals(-8713, AbstractSectionParser.parseShort("-8713").getShort(0));
+
+        assertEquals(-32767, AbstractSectionParser.parseShort("noval").getShort(0));
+        assertEquals(-32767, AbstractSectionParser.parseShort("").getShort(0));
+    }
+
+    @Test
+    public void testParseFloat()  {
+        assertEquals(66.903, AbstractSectionParser.parseFloat("66.903").getFloat(0), 1e-6);
+
+        assertEquals(9.969209968386869E36, AbstractSectionParser.parseFloat("noval").getFloat(0), 1e-8);
+        assertEquals(9.969209968386869E36, AbstractSectionParser.parseFloat("").getFloat(0), 1e-8);
+    }
+}