added tests

Author: TomBlock

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/Era5PostProcessing.java

@@ -1,7 +1,6 @@
 package com.bc.fiduceo.post.plugin.era5;
 
 import com.bc.fiduceo.FiduceoConstants;
-import com.bc.fiduceo.core.GeoRect;
 import com.bc.fiduceo.post.PostProcessing;
 import ucar.ma2.Array;
 import ucar.ma2.Index;
@@ -36,19 +35,6 @@ private static int getEra5LatMin(float latMax) {
         return (int) ((90.0 - scaledLatMax) * 4.0);
     }
 
-    private static int getEra5LatMax(float latMin) {
-        final double shiftedLat = latMin - EPS;
-        final double scaledLatMin = Math.floor(shiftedLat * 4) / 4;
-        return (int) ((90.0 - scaledLatMin) * 4.0);
-    }
-
-    private static int getEra5LonMax(float lonMax) {
-        final double shiftedLon = lonMax + EPS;
-        final double normLonMax = shiftedLon + 180.0;
-        final double scaledLonMax = Math.ceil(normLonMax * 4) / 4;
-        return (int) (scaledLonMax * 4);
-    }
-
     private static int getEra5LonMin(float lonMin) {
         final double shiftedLon = lonMin - EPS;
         final double normLonMin = shiftedLon + 180.0;
@@ -114,27 +100,6 @@ static InterpolationContext getInterpolationContext(Array lonArray, Array latArr
         return context;
     }
 
-    private static float[] getMinMax(Array floatArray) {
-        float min = Float.MAX_VALUE;
-        float max = -Float.MAX_VALUE;
-        final Index index = floatArray.getIndex();
-        final int[] shape = floatArray.getShape();
-        for (int y = 0; y < shape[0]; y++) {
-            for (int x = 0; x < shape[1]; x++) {
-                index.set(y, x);
-                final float value = floatArray.getFloat(index);
-                if (value < min) {
-                    min = value;
-                }
-                if (value > max) {
-                    max = value;
-                }
-            }
-        }
-        return new float[]{min, max};
-    }
-
-
     @Override
     protected void prepare(NetcdfFile reader, NetcdfFileWriter writer) {
         final Dimension matchupCountDimension = reader.findDimension(FiduceoConstants.MATCHUP_COUNT);

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/SatelliteFields.java

@@ -297,7 +297,8 @@ private void addTimeVariable(SatelliteFieldsConfiguration satFieldsConfig, Netcd
         variable.addAttribute(new Attribute("_FillValue", NetCDFUtils.getDefaultFillValue(DataType.INT, false)));
     }
 
-    private void addAttributes(TemplateVariable template, Variable variable) {
+    // package access for testing purpose only tb 2020-12-02
+    static void addAttributes(TemplateVariable template, Variable variable) {
         variable.addAttribute(new Attribute("units", template.getUnits()));
         variable.addAttribute(new Attribute("long_name", template.getLongName()));
         final String standardName = template.getStandardName();

post-processing-tool/src/test/java/com/bc/fiduceo/post/plugin/era5/SatelliteFieldsTest.java

@@ -4,9 +4,7 @@
 import org.junit.Test;
 import ucar.ma2.Array;
 import ucar.ma2.DataType;
-import ucar.nc2.Dimension;
-import ucar.nc2.NetcdfFile;
-import ucar.nc2.NetcdfFileWriter;
+import ucar.nc2.*;
 
 import java.util.List;
 import java.util.Map;
@@ -106,6 +104,33 @@ public void testGetNwpOffset() {
         assertEquals(1, nwpOffset[2]);
     }
 
+    @Test
+    public void testAddAttributes() {
+        final TemplateVariable templateVariable = new TemplateVariable("theName", "metres", "a_long_name", "a_standard_name", true);
+        final Variable variable = mock(Variable.class);
+
+        SatelliteFields.addAttributes(templateVariable, variable);
+
+        verify(variable, times(1)).addAttribute(new Attribute("units", "metres"));
+        verify(variable, times(1)).addAttribute(new Attribute("long_name", "a_long_name"));
+        verify(variable, times(1)).addAttribute(new Attribute("standard_name", "a_standard_name"));
+        verify(variable, times(1)).addAttribute(new Attribute("_FillValue", 9.96921E36f));
+        verifyNoMoreInteractions(variable);
+    }
+
+    @Test
+    public void testAddAttributes_missingStandarName() {
+        final TemplateVariable templateVariable = new TemplateVariable("Carola", "gramm", "Heffalump", null, true);
+        final Variable variable = mock(Variable.class);
+
+        SatelliteFields.addAttributes(templateVariable, variable);
+
+        verify(variable, times(1)).addAttribute(new Attribute("units", "gramm"));
+        verify(variable, times(1)).addAttribute(new Attribute("long_name", "Heffalump"));
+        verify(variable, times(1)).addAttribute(new Attribute("_FillValue", 9.96921E36f));
+        verifyNoMoreInteractions(variable);
+    }
+
     @Test
     public void testSetGetDimensions_2D() {
         final NetcdfFile ncFile = mock(NetcdfFile.class);
@@ -136,6 +161,7 @@ public void testSetGetDimensions_2D() {
         assertEquals(12, dimension.getLength());
 
         verify(writer, times(3)).addDimension(anyString(), anyInt());
+        verifyNoMoreInteractions(writer);
     }
 
     @Test
@@ -174,6 +200,7 @@ public void testSetGetDimensions_3D() {
         assertEquals(12, dimension.getLength());
 
         verify(writer, times(3)).addDimension(anyString(), anyInt());
+        verifyNoMoreInteractions(writer);
     }
 
     private SatelliteFieldsConfiguration createConfig() {