performance boost - move writing from inner loop

Author: TomBlock

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/MatchupFields.java

@@ -139,9 +139,12 @@ void compute(Configuration config, NetcdfFile reader, NetcdfFileWriter writer) t
                         targetArray.setFloat(targetIndex, (float) interpolated);
                     }
                 }
+            }
 
+            for (final String variableKey : variableKeys) {
                 final TemplateVariable templateVariable = variables.get(variableKey);
                 final Variable targetVariable = writer.findVariable(NetCDFUtils.escapeVariableName(templateVariable.getName()));
+                final Array targetArray = targetArrays.get(variableKey);
                 writer.write(targetVariable, targetArray);
             }
         } finally {

post-processing-tool/src/main/java/com/bc/fiduceo/post/plugin/era5/SatelliteFields.java

@@ -300,12 +300,17 @@ void compute(Configuration config, NetcdfFile reader, NetcdfFileWriter writer) t
                     } else {
                         throw new IllegalStateException("Unexpected variable rank: " + rank + "  " + variableKey);
                     }
-
-                    final TemplateVariable templateVariable = variables.get(variableKey);
-                    final Variable targetVariable = writer.findVariable(NetCDFUtils.escapeVariableName(templateVariable.getName()));
-                    writer.write(targetVariable, targetArray);
                 }
             }
+
+            final Set<String> variableKeys = variables.keySet();
+            for (final String variableKey : variableKeys) {
+                final TemplateVariable templateVariable = variables.get(variableKey);
+                final Array targetArray = targetArrays.get(variableKey);
+                final Variable targetVariable = writer.findVariable(NetCDFUtils.escapeVariableName(templateVariable.getName()));
+                writer.write(targetVariable, targetArray);
+            }
+
         } finally {
             variableCache.close();
         }