Skip to content

Commit 23af378

Browse files
committed
handled case where extensions not configured
1 parent cabd9c6 commit 23af378

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

dashipy/dashipy/controllers/callback.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66

77
# POST /dashi/callback
8-
def get_callback_results(ext_ctx: ExtensionContext, data: dict[str, Any]):
8+
def get_callback_results(ext_ctx: ExtensionContext | None, data: dict[str, Any]):
99
"""Generate the response for `POST /dashi/callback`.
1010
1111
Args:
@@ -15,6 +15,11 @@ def get_callback_results(ext_ctx: ExtensionContext, data: dict[str, Any]):
1515
Returns:
1616
A JSON-serializable list.
1717
"""
18+
if ext_ctx is None:
19+
return Response.failed(
20+
404, f"no contributions configured"
21+
)
22+
1823
# TODO: validate data
1924
callback_requests: list[dict] = data.get("callbackRequests") or []
2025

dashipy/dashipy/controllers/contributions.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,13 @@
22
from dashipy.response import Response
33

44

5-
def get_contributions(ext_ctx: ExtensionContext) -> Response:
5+
def get_contributions(ext_ctx: ExtensionContext | None) -> Response:
66
"""Generate the response for `GET /dashi/contributions`."""
7+
if ext_ctx is None:
8+
return Response.failed(
9+
404, f"no contributions configured"
10+
)
11+
712
extensions = ext_ctx.extensions
813
contributions = ext_ctx.contributions
914
return Response.success(

dashipy/dashipy/controllers/layout.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66

77
def get_layout(
8-
ext_ctx: ExtensionContext,
8+
ext_ctx: ExtensionContext | None,
99
contrib_point_name: str,
1010
contrib_index: int,
1111
data: dict[str, Any],
@@ -22,6 +22,11 @@ def get_layout(
2222
Returns:
2323
A JSON-serializable dictionary.
2424
"""
25+
if ext_ctx is None:
26+
return Response.failed(
27+
404, f"no contributions configured"
28+
)
29+
2530
# TODO: validate data
2631
input_values = data.get("inputValues") or []
2732

0 commit comments

Comments
 (0)